From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Fri, 01 Sep 2023 09:46:27 +0300 Organization: LINKOV.NET Message-ID: <8634zyjt0k.fsf@mail.linkov.net> References: <86wn10e1wl.fsf@mail.linkov.net> <482a1ebc-165c-a0a4-98c0-5c404d1b1d0d@gutov.dev> <86jzwyxnxb.fsf@mail.linkov.net> <86o7m91z22.fsf@mail.linkov.net> <86pm6py6k4.fsf@mail.linkov.net> <86bki9y68h.fsf@mail.linkov.net> <86cz2f7bvo.fsf@mail.linkov.net> <86353axu48.fsf@mail.linkov.net> <87o7jfi00b.fsf@catern.com> <86msyhwrrg.fsf@mail.linkov.net> <86y1hs4kkg.fsf@mail.linkov.net> <86h6of66o3.fsf@mail.linkov.net> <86wmxb2qvh.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13502"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Spencer Baugh , 63648@debbugs.gnu.org, sbaugh@catern.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 01 09:05:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbyDf-0003EV-Lm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Sep 2023 09:05:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbyDH-0003sv-DI; Fri, 01 Sep 2023 03:05:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbyD7-0003s2-9s for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 03:04:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbyD7-0002dK-1V for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 03:04:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbyDF-0004gO-LH for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 03:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2023 07:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.169355189617979 (code B ref 63648); Fri, 01 Sep 2023 07:05:01 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 1 Sep 2023 07:04:56 +0000 Original-Received: from localhost ([127.0.0.1]:59759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbyD9-0004fv-R5 for submit@debbugs.gnu.org; Fri, 01 Sep 2023 03:04:56 -0400 Original-Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:34897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbyD7-0004ff-OI for 63648@debbugs.gnu.org; Fri, 01 Sep 2023 03:04:54 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 289014000A; Fri, 1 Sep 2023 07:04:34 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Fri, 1 Sep 2023 04:11:40 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268870 Archived-At: >> (let ((default-directory "/tmp/")) >> (list default-directory >> (buffer-local-value 'default-directory (current-buffer)))) >> => ("/tmp/" "/tmp/") >> Here is the shortest test case: 'C-x p p C-b' shows buffers >> from two projects when using let-binding for default-directory, >> because 'project-buffers' relies on >> (buffer-local-value 'default-directory buf) >> This could be fixed by adding special-handling of the default-directory >> for the current buffer in 'project-buffers'. > > What kind of special handling? The "real" buffer-local value is hidden > until the "let" exists, the global value is nil, and if the buffer is not > a file-visiting one, there is no other file name to test against. Additional buffer-local variable like 'buffer-default-directory' could help. Or additional global variable 'global-default-directory'. Or even using the global value of the existing variable 'default-directory'. > Finally, whatever special handling we invent, would have to be mirrored by > all subsequent new commands (built-in and third-party) which look up the > value of default-directory. Especially project-related ones. How to > popularize that knowledge, would be the next question for whatever solution > we invent. Hopefully there should be not much trouble such as in 'project-buffers'. >>> A general question regarding this approach, for me, is: is a "prefix >>> command" a real command? >> It's a real command that prepares some transient values for the next >> command. >> Most existing prefix commands have no problems because they modify global >> values. But 'default-directory' is the first buffer-local variable >> used for the next command, therefore it requires special-handling. >> Too bad that 'default-directory' is not a function. > > I suppose the new code could check against some property or dynamic var to > distinguish prefix commands from "terminal" ones. Currently I see no need for this. >>> And would they "swallow" these prepared variable bindings too early? >> The scope of the modified variable depends on concrete needs. >> For example, set-transient-map restores its old value in pre-command-hook, >> but display-buffer-override-next-command does this in post-command-hook. > > That can also work - though the odds of getting into an unrecoverable state > (such as one I described) would be higher. This is strange, no one reported an unrecoverable state for set-transient-map.