From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69056: 30.0.50; history-add-new-input and recursive minibuffers Date: Thu, 15 Feb 2024 21:27:44 +0200 Message-ID: <8634ttwmrz.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11281"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69056@debbugs.gnu.org, me@eshelyaron.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 15 20:32:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rahT1-0002jq-EP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Feb 2024 20:32:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rahS3-0004zY-7s; Thu, 15 Feb 2024 14:31:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rahRV-0004L4-Tb for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 14:30:49 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rahRU-0005A4-6C for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 14:30:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rahRm-0005G8-DN for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 14:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Feb 2024 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69056 X-GNU-PR-Package: emacs Original-Received: via spool by 69056-submit@debbugs.gnu.org id=B69056.170802542720168 (code B ref 69056); Thu, 15 Feb 2024 19:31:02 +0000 Original-Received: (at 69056) by debbugs.gnu.org; 15 Feb 2024 19:30:27 +0000 Original-Received: from localhost ([127.0.0.1]:57098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rahRD-0005FE-CR for submit@debbugs.gnu.org; Thu, 15 Feb 2024 14:30:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rahRA-0005Ey-PO for 69056@debbugs.gnu.org; Thu, 15 Feb 2024 14:30:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rahOe-0004cf-Iq; Thu, 15 Feb 2024 14:27:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zT7krack6pLGNZa/JVFw93aJaLAGfcX0EH0g59hRLTA=; b=OnL43HSsB20L wyT93oTjPqqSXkaiwqBVp+nl9u9hI0fhgX44HUzGeJJP09Wr3g0dS4i5knL5XBDRa2LySqUMLvIw+ /nU979NSb/nPZmzVmyBja638A2eQSZVMdfWYQFoASsNgYArLtqSOHGoa54t5huvygRuyBmTPwWF9p p6856Osv7oYo5wsMJp/GthO86ezvoz3lyo83YmCTlpwtPMUt3eZgPN7boUCxn0XHJWu/GvwvRG4Me N7EuXvjbkKPszjKHoBB4vrXPMxoYD6g4SOorhzRvJiekHnJDTmBzXPUbKFdUNkSj/SXhff7Bb65d6 KgqjN/jlKKBDZ/T50BzXBQ==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280076 Archived-At: > Cc: 69056@debbugs.gnu.org > Date: Thu, 15 Feb 2024 12:56:43 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Thanks, that's what I thought too. Here's an attempt do just that: > > Looks pretty good. Is this really worthwhile? It might solve some problems with commands invoked from the recursive edit, but it doesn't solve all of them, because the value of history-add-new-input is still set in that minibuffer. And it introduces tricky effects due to the variable being buffer-local for any code that let-binds history-add-new-input, and could potentially break something because of that. I'm afraid I don't like this change, for those reasons.