From: Eli Zaretskii <eliz@gnu.org>
To: Vincenzo Pupillo <v.pupillo@gmail.com>
Cc: 71380@debbugs.gnu.org
Subject: bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php
Date: Fri, 07 Jun 2024 16:44:44 +0300 [thread overview]
Message-ID: <8634pog94j.fsf@gnu.org> (raw)
In-Reply-To: <21747651.4csPzL39Zc@3-191.divsi.unimi.it> (message from Vincenzo Pupillo on Fri, 07 Jun 2024 14:50:24 +0200)
> From: Vincenzo Pupillo <v.pupillo@gmail.com>
> Cc: 71380@debbugs.gnu.org
> Date: Fri, 07 Jun 2024 14:50:24 +0200
>
> In data venerdì 7 giugno 2024 13:12:25 CEST, Eli Zaretskii ha scritto:
>
> > > > > +(defun php-ts-mode--array-element-heuristic (node parent bol &rest _)
> > > > > + "Return of the position of the first element of the array.
> > > >
> > > > The "of" part should be deleted here, I think.
> > > >
> > > I'm not sure how to explain it. Different indentation styles indent the
> > > elements of an array differently when written on multiple rows. For example.
> > > in PSR2 it is like this:
> > > $a = array("a" => 1,
> > > "b" => 2,
> > > "c" => 3);
> > > while with Zend it is like this:
> > > $a = array("a" => 1,
> > > "b" => 2,
> > > "c" => 3);
> > > What do you suggest?
> >
> > What does the function return in each of these two cases?
> >
> If '$a = array(' is on the same line as '“a” => 1,' it returns the initial position of '“a”,
> otherwise the starting position of 'array(', like PSR2.
> In terms of tree-sitter-php the first case is:
> (treesit-node-start (treesit-node-child parent 2))
> while the second is: parent indentation + offset.
Does it return a buffer position or a column? You seem to say that
sometimes it returns the former and sometimes the latter.
next prev parent reply other threads:[~2024-06-07 13:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 13:59 bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php Vincenzo Pupillo
2024-06-06 6:58 ` Eli Zaretskii
2024-06-07 10:45 ` Vincenzo Pupillo
2024-06-07 11:12 ` Eli Zaretskii
2024-06-07 12:50 ` Vincenzo Pupillo
2024-06-07 13:44 ` Eli Zaretskii [this message]
2024-06-07 15:05 ` Vincenzo Pupillo
2024-06-08 9:31 ` Vincenzo Pupillo
2024-06-08 10:45 ` Eli Zaretskii
2024-06-08 11:15 ` Vincenzo Pupillo
2024-06-09 13:54 ` Eli Zaretskii
2024-06-09 17:23 ` Vincenzo Pupillo
2024-06-09 17:49 ` Eli Zaretskii
2024-06-09 19:37 ` Vincenzo Pupillo
2024-06-09 20:36 ` Vincenzo Pupillo
2024-06-12 9:25 ` Vincenzo Pupillo
2024-06-12 18:27 ` Eli Zaretskii
2024-06-12 20:44 ` Vincenzo Pupillo
2024-06-09 13:53 ` Eli Zaretskii
2024-06-06 14:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 9:04 ` Vincenzo Pupillo
2024-06-07 12:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 13:25 ` Vincenzo Pupillo
2024-06-07 13:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 14:37 ` Vincenzo Pupillo
2024-06-06 14:54 ` Andrea Corallo
2024-06-07 8:36 ` Vincenzo Pupillo
2024-06-07 13:39 ` Andrea Corallo
2024-06-07 17:02 ` Vincenzo Pupillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634pog94j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71380@debbugs.gnu.org \
--cc=v.pupillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).