From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73359: 30.0.91; editorconfig does not work on xml files Date: Sat, 21 Sep 2024 13:36:25 +0300 Message-ID: <8634lt47km.fsf@gnu.org> References: <86msk38w0e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33042"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73359-done@debbugs.gnu.org, nqminhuit@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 21 12:37:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srxU7-0008PS-GL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Sep 2024 12:37:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srxTn-0002q4-U7; Sat, 21 Sep 2024 06:36:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srxTm-0002pc-G7 for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 06:36:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srxTm-0006CR-7J for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 06:36:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=9pL0ruxr3uEMN6NGxwrsWCfnlKMvBwHNVO+hXx24crc=; b=fniIZvPE6mZiw/BW0Tkg5poiroPD3ELLar+2SPeO7tjkZwVix7OXJsblB8BXPqTprZ4t0UFx2IaAz0nYcmYS4j6fN/ts0GNRYEZEkC6wwDyaFCaRAyB5HmFWhGdk3mDN+ZLY19IsK6me2iyvuekXrwaiFZVyDLkOHVgp2OGd/0zPebnfb9b6jTtIYL07qr8mHMal4GZNY+OJao2u27IiVeP1nICaNiOo2MyuMDrGRPApx8htCEM6xpljMz4UatUnoSJjjLXYDf27NKYE7H16VNolkJVwA9+p5/coL8aSssYOE/IT4b8nhxRPvueeEtc5DzPzzScSO0GSA1JpOAtOnA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srxU6-0006bs-8I for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 06:37:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2024 10:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73359 X-GNU-PR-Package: emacs Mail-Followup-To: 73359@debbugs.gnu.org, eliz@gnu.org, nqminhuit@gmail.com Original-Received: via spool by 73359-done@debbugs.gnu.org id=D73359.172691501725392 (code D ref 73359); Sat, 21 Sep 2024 10:37:01 +0000 Original-Received: (at 73359-done) by debbugs.gnu.org; 21 Sep 2024 10:36:57 +0000 Original-Received: from localhost ([127.0.0.1]:37402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srxU0-0006bU-M6 for submit@debbugs.gnu.org; Sat, 21 Sep 2024 06:36:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srxTy-0006bF-6j for 73359-done@debbugs.gnu.org; Sat, 21 Sep 2024 06:36:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srxTY-0006BL-BK; Sat, 21 Sep 2024 06:36:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9pL0ruxr3uEMN6NGxwrsWCfnlKMvBwHNVO+hXx24crc=; b=jQugAuos16952MurAUoM HUkAdVomK67kKAsQ/XTvCZ0q+JvbvOTU0tPyiarMkHP1b/mLeej5vOATe+uh/G42lRv/H67GBqt7W qCXGaJB2ggp6rFvAR7ua5e/TMgvvWgvmKjI320fTO8Jlai6OGvXMihJiN+pemM2sGuqEDmOmM5mfb 257CmGfDiyE/AuIu7xz7GlDGZlsGj67mC1KamgGRqQkmva7QMeeHclUWoOVteXsi4ZX2LxklyT1A0 3wc+5QbGE9EVrfvN3XmmbOafjZfA8woZ1Ud6pKdvvG9Lv+8Ok+e0w5FVqHgYUGlPyP0TEPVrcqsGm KMLLNtuL0IefVQ==; In-Reply-To: (message from Stefan Monnier on Fri, 20 Sep 2024 14:58:54 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292177 Archived-At: > From: Stefan Monnier > Cc: Nguyễn Quốc Minh , > 73359@debbugs.gnu.org > Date: Fri, 20 Sep 2024 14:58:54 -0400 > > > Stefan, this element of editorconfig-indentation-alist: > > > > (nxml-mode nxml-child-indent (nxml-attribute-indent . 2)) > > > > seems to violate the expected form of the elements, which is > > (MODE . SETTING). It was added as part of commit 8e143a2f300, whose > > log says "Sync with upstream", so I suppose this form of the element > > is supported by upstream, but not by Emacs? I guess we need to > > replace it with a function or something? > > Yup. I pushed the patch below to `emacs-30` for it. Thanks, I'm therefore closing this bug. > > Btw, can we clarify the doc string of editorconfig-indentation-alist, > > where it says "where SETTING should obey the same rules as > > `editorconfig-indent-size-vars'"? Because if one looks at the doc > > string of editorconfig-indent-size-vars, the "rules" are either > > trivial or unclear. If SETTING above should be one or more symbols > > ("list of variables that need to be set to SIZE") or a function that > > returns a list of (VAR . VAL) pairs, then why not say that in the doc > > string of editorconfig-indentation-alist? > > I didn't want to do it because it's redundant with the docstring of > `editorconfig-indent-size-vars`, but see the patch where I tried to > address your request. Thanks.