From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 73359-done@debbugs.gnu.org, nqminhuit@gmail.com
Subject: bug#73359: 30.0.91; editorconfig does not work on xml files
Date: Sat, 21 Sep 2024 13:36:25 +0300 [thread overview]
Message-ID: <8634lt47km.fsf@gnu.org> (raw)
In-Reply-To: <jwvldzm17lj.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Fri, 20 Sep 2024 14:58:54 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Nguyễn Quốc Minh <nqminhuit@gmail.com>,
> 73359@debbugs.gnu.org
> Date: Fri, 20 Sep 2024 14:58:54 -0400
>
> > Stefan, this element of editorconfig-indentation-alist:
> >
> > (nxml-mode nxml-child-indent (nxml-attribute-indent . 2))
> >
> > seems to violate the expected form of the elements, which is
> > (MODE . SETTING). It was added as part of commit 8e143a2f300, whose
> > log says "Sync with upstream", so I suppose this form of the element
> > is supported by upstream, but not by Emacs? I guess we need to
> > replace it with a function or something?
>
> Yup. I pushed the patch below to `emacs-30` for it.
Thanks, I'm therefore closing this bug.
> > Btw, can we clarify the doc string of editorconfig-indentation-alist,
> > where it says "where SETTING should obey the same rules as
> > `editorconfig-indent-size-vars'"? Because if one looks at the doc
> > string of editorconfig-indent-size-vars, the "rules" are either
> > trivial or unclear. If SETTING above should be one or more symbols
> > ("list of variables that need to be set to SIZE") or a function that
> > returns a list of (VAR . VAL) pairs, then why not say that in the doc
> > string of editorconfig-indentation-alist?
>
> I didn't want to do it because it's redundant with the docstring of
> `editorconfig-indent-size-vars`, but see the patch where I tried to
> address your request.
Thanks.
prev parent reply other threads:[~2024-09-21 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 7:29 bug#73359: 30.0.91; editorconfig does not work on xml files Nguyễn Quốc Minh
2024-09-19 16:10 ` Eli Zaretskii
2024-09-20 18:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-21 10:36 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634lt47km.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73359-done@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nqminhuit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).