* bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil
@ 2024-10-15 11:01 jixiuf@qq.com via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 16:43 ` Juri Linkov
0 siblings, 1 reply; 8+ messages in thread
From: jixiuf@qq.com via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-10-15 11:01 UTC (permalink / raw)
To: 73820; +Cc: jixiuf
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
I would like to use `icomplete-mode`/`icomplete-vertical-mode` with
(setq icomplete-in-buffer t)
but I don't want to display the `*Completions*` buffer.
How about adding a new value for `completion-auto-help` to achieve this?
[-- Attachment #2: icomplete-in-buffer --]
[-- Type: image/png, Size: 802211 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil 2024-10-15 11:01 bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil jixiuf@qq.com via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-10-15 16:43 ` Juri Linkov 2024-10-16 1:23 ` Sean Whitton 0 siblings, 1 reply; 8+ messages in thread From: Juri Linkov @ 2024-10-15 16:43 UTC (permalink / raw) To: jixiuf@qq.com; +Cc: 73820 > I would like to use `icomplete-mode`/`icomplete-vertical-mode` with > > (setq icomplete-in-buffer t) > > but I don't want to display the `*Completions*` buffer. > > How about adding a new value for `completion-auto-help` to achieve this? As suggested in https://debbugs.gnu.org/67661#114 this is currently achievable by (advice-add 'completion-at-point :after #'minibuffer-hide-completions) But adding a new option is also an option. ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil 2024-10-15 16:43 ` Juri Linkov @ 2024-10-16 1:23 ` Sean Whitton 2024-10-16 5:33 ` Eli Zaretskii 0 siblings, 1 reply; 8+ messages in thread From: Sean Whitton @ 2024-10-16 1:23 UTC (permalink / raw) To: Juri Linkov; +Cc: 73820, jixiuf@qq.com Hello, On Tue 15 Oct 2024 at 07:43pm +03, Juri Linkov wrote: >> I would like to use `icomplete-mode`/`icomplete-vertical-mode` with >> >> (setq icomplete-in-buffer t) >> >> but I don't want to display the `*Completions*` buffer. >> >> How about adding a new value for `completion-auto-help` to achieve this? > > As suggested in https://debbugs.gnu.org/67661#114 > this is currently achievable by > > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) > > But adding a new option is also an option. Right. This is also stated in NEWS. -- Sean Whitton ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil 2024-10-16 1:23 ` Sean Whitton @ 2024-10-16 5:33 ` Eli Zaretskii 2024-10-16 7:37 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors 0 siblings, 1 reply; 8+ messages in thread From: Eli Zaretskii @ 2024-10-16 5:33 UTC (permalink / raw) To: Sean Whitton; +Cc: jixiuf, 73820-done, juri > Cc: 73820@debbugs.gnu.org, "jixiuf@qq.com" <jixiuf@qq.com> > From: Sean Whitton <spwhitton@spwhitton.name> > Date: Wed, 16 Oct 2024 09:23:52 +0800 > > On Tue 15 Oct 2024 at 07:43pm +03, Juri Linkov wrote: > > >> I would like to use `icomplete-mode`/`icomplete-vertical-mode` with > >> > >> (setq icomplete-in-buffer t) > >> > >> but I don't want to display the `*Completions*` buffer. > >> > >> How about adding a new value for `completion-auto-help` to achieve this? > > > > As suggested in https://debbugs.gnu.org/67661#114 > > this is currently achievable by > > > > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) > > > > But adding a new option is also an option. > > Right. This is also stated in NEWS. If this is important enough, it should be in the doc string. So I've now added this tip to the doc string, and I'm therefore closing this bug. Thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil 2024-10-16 5:33 ` Eli Zaretskii @ 2024-10-16 7:37 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors 2024-10-16 9:07 ` Eli Zaretskii 2024-10-16 10:13 ` Sean Whitton 0 siblings, 2 replies; 8+ messages in thread From: Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-10-16 7:37 UTC (permalink / raw) To: 73820; +Cc: Juri Linkov, eliz, jixiuf, Sean Whitton Hi, Eli Zaretskii <eliz@gnu.org> writes: >> Cc: 73820@debbugs.gnu.org, "jixiuf@qq.com" <jixiuf@qq.com> >> From: Sean Whitton <spwhitton@spwhitton.name> >> Date: Wed, 16 Oct 2024 09:23:52 +0800 >> >> On Tue 15 Oct 2024 at 07:43pm +03, Juri Linkov wrote: >> >> >> I would like to use `icomplete-mode`/`icomplete-vertical-mode` with >> >> >> >> (setq icomplete-in-buffer t) >> >> >> >> but I don't want to display the `*Completions*` buffer. >> >> >> >> How about adding a new value for `completion-auto-help` to achieve this? >> > >> > As suggested in https://debbugs.gnu.org/67661#114 >> > this is currently achievable by >> > >> > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) >> > >> > But adding a new option is also an option. >> >> Right. This is also stated in NEWS. > > If this is important enough, it should be in the doc string. So I've > now added this tip to the doc string, and I'm therefore closing this > bug. Hmm, I'm not sure that that's really such a good recommendation. Adding this advice breaks M-: completion, for example. I think a more refined solution is due, if this is to be considered a supported use case... Namely, I suggest implementing icomplete-in-buffer as a completion-in-region-function, like some other in-buffer completion frontends are implemented. Best, Eshel ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil 2024-10-16 7:37 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-10-16 9:07 ` Eli Zaretskii 2024-10-16 9:36 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors 2024-10-16 10:13 ` Sean Whitton 1 sibling, 1 reply; 8+ messages in thread From: Eli Zaretskii @ 2024-10-16 9:07 UTC (permalink / raw) To: Eshel Yaron; +Cc: juri, 73820, jixiuf, spwhitton > From: Eshel Yaron <me@eshelyaron.com> > Cc: eliz@gnu.org, jixiuf@qq.com, Sean Whitton <spwhitton@spwhitton.name>, > Juri Linkov <juri@linkov.net> > Date: Wed, 16 Oct 2024 09:37:19 +0200 > > >> Right. This is also stated in NEWS. > > > > If this is important enough, it should be in the doc string. So I've > > now added this tip to the doc string, and I'm therefore closing this > > bug. > > Hmm, I'm not sure that that's really such a good recommendation. Adding > this advice breaks M-: completion, for example. I think a more refined > solution is due, if this is to be considered a supported use case... > Namely, I suggest implementing icomplete-in-buffer as a > completion-in-region-function, like some other in-buffer completion > frontends are implemented. Of course, a better solution, especially if it is not based on advising functions, are always welcome. But I'm guessing the solution you have in mind is not for the release branch, though? ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil 2024-10-16 9:07 ` Eli Zaretskii @ 2024-10-16 9:36 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors 0 siblings, 0 replies; 8+ messages in thread From: Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-10-16 9:36 UTC (permalink / raw) To: Eli Zaretskii; +Cc: juri, 73820, jixiuf, spwhitton Eli Zaretskii <eliz@gnu.org> writes: >> From: Eshel Yaron <me@eshelyaron.com> >> Cc: eliz@gnu.org, jixiuf@qq.com, Sean Whitton <spwhitton@spwhitton.name>, >> Juri Linkov <juri@linkov.net> >> Date: Wed, 16 Oct 2024 09:37:19 +0200 >> >> >> Right. This is also stated in NEWS. >> > >> > If this is important enough, it should be in the doc string. So I've >> > now added this tip to the doc string, and I'm therefore closing this >> > bug. >> >> Hmm, I'm not sure that that's really such a good recommendation. Adding >> this advice breaks M-: completion, for example. I think a more refined >> solution is due, if this is to be considered a supported use case... >> Namely, I suggest implementing icomplete-in-buffer as a >> completion-in-region-function, like some other in-buffer completion >> frontends are implemented. > > Of course, a better solution, especially if it is not based on > advising functions, are always welcome. But I'm guessing the solution > you have in mind is not for the release branch, though? Right, it'd probably be too big of a change to make it into Emacs 30. ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil 2024-10-16 7:37 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors 2024-10-16 9:07 ` Eli Zaretskii @ 2024-10-16 10:13 ` Sean Whitton 1 sibling, 0 replies; 8+ messages in thread From: Sean Whitton @ 2024-10-16 10:13 UTC (permalink / raw) To: Eshel Yaron; +Cc: eliz, 73820, jixiuf, Juri Linkov Hello, On Wed 16 Oct 2024 at 09:37am +02, Eshel Yaron wrote: > Hmm, I'm not sure that that's really such a good recommendation. Adding > this advice breaks M-: completion, for example. I think a more refined > solution is due, if this is to be considered a supported use case... > Namely, I suggest implementing icomplete-in-buffer as a > completion-in-region-function, like some other in-buffer completion > frontends are implemented. If you were to look into that change, I would be very happy to review. -- Sean Whitton ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-10-16 10:13 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-10-15 11:01 bug#73820: 31.0.50; [Feature Request]how to hide *Completions* buffer when icomplete-in-buffer is not nil jixiuf@qq.com via Bug reports for GNU Emacs, the Swiss army knife of text editors 2024-10-15 16:43 ` Juri Linkov 2024-10-16 1:23 ` Sean Whitton 2024-10-16 5:33 ` Eli Zaretskii 2024-10-16 7:37 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors 2024-10-16 9:07 ` Eli Zaretskii 2024-10-16 9:36 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors 2024-10-16 10:13 ` Sean Whitton
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).