From: Eli Zaretskii <eliz@gnu.org>
To: john muhl <jm@pub.pink>
Cc: 74235-done@debbugs.gnu.org
Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options
Date: Thu, 14 Nov 2024 10:26:02 +0200 [thread overview]
Message-ID: <8634jukyqt.fsf@gnu.org> (raw)
In-Reply-To: <87y11r87qw.fsf@pub.pink> (message from john muhl on Sun, 10 Nov 2024 08:48:39 -0600)
> From: john muhl <jm@pub.pink>
> Cc: 74235@debbugs.gnu.org
> Date: Sun, 10 Nov 2024 08:48:39 -0600
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: john muhl <jm@pub.pink>
> >> Cc: 74235@debbugs.gnu.org
> >> Date: Sat, 09 Nov 2024 14:54:47 -0600
> >>
> >> + (if (or (not lua-ts-inferior-program)
> >> + (not (executable-find lua-ts-inferior-program)))
> >> + (user-error "You must set `lua-ts-inferior-program' to use this command")
> >
> > The text of user-error should say something about being unable to find
> > the program, not just about the variable being nil, since you use
> > executable-find.
> >
> > Otherwise, LGTM, thanks.
>
> I guess the executable-find check is redundant anyway since
> comint/process will tell you “Searching for program: No such file
> or directory, luaz” if you get it wrong.
Thanks, installed on the emacs-30 branch, and closing the bug.
Btw, I noticed that you are marking with ";" the log entries of
changes which should definitely appear in the produced ChangeLog. Is
this on purpose, or did you misunderstand the meaning of the
semi-colon in the first line of the commit log messages?
next prev parent reply other threads:[~2024-11-14 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 21:19 bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options john muhl
2024-11-06 21:22 ` john muhl
2024-11-07 5:58 ` Eli Zaretskii
2024-11-07 15:04 ` john muhl
2024-11-08 14:57 ` john muhl
2024-11-08 15:24 ` Eli Zaretskii
2024-11-09 20:54 ` john muhl
2024-11-10 5:43 ` Eli Zaretskii
2024-11-10 14:48 ` john muhl
2024-11-14 8:26 ` Eli Zaretskii [this message]
2024-11-10 5:45 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634jukyqt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74235-done@debbugs.gnu.org \
--cc=jm@pub.pink \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).