From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Mon, 18 Nov 2024 19:03:08 +0200 Message-ID: <8634jov5ir.fsf@gnu.org> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27977"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 18 18:04:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tD5B0-00076t-JN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Nov 2024 18:04:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tD5AZ-0003lR-AQ; Mon, 18 Nov 2024 12:04:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD5AR-0003k4-1A for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 12:04:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tD5AQ-0000Pm-OW for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 12:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=11YGAbpUTyEW4SB9GGnbZTcxAZF+UHiVvm2B7b8wJ90=; b=QIO7JFDAp2LdUIfVes7ohQAPKsZqGCa7jEiTv1OhBpS9mtl1iEDtJVJtdMe8bpl39WH2u+A4jpBjsLEE8olUe2wTBq/humadeRXJE4gIATo00NyYhSiVPhN3+jThhx+F5059yX59IR+ZkfCdv0OQlZx6AGrec+EMvPxbQ+CJtJI/m8aVPIu89xKLjT2gPJiqxYdIpy9YIB+ip3H62bDTkYSB049ofGMCV9M2xosLLDyOPmPdA/7bNO/ClxoQr5NRqFypAKnHj64HdXcxN206BYPBcH7gjxltQkU7QX3WqLrO728gNMW4OSrpm5UDrk8P2lxYcug49Ge3n7Fwh91NfA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tD5AQ-0004To-AR for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 12:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2024 17:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173194940317166 (code B ref 74361); Mon, 18 Nov 2024 17:04:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 18 Nov 2024 17:03:23 +0000 Original-Received: from localhost ([127.0.0.1]:34997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD59m-0004So-I9 for submit@debbugs.gnu.org; Mon, 18 Nov 2024 12:03:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD59i-0004SY-Gr for 74361@debbugs.gnu.org; Mon, 18 Nov 2024 12:03:20 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD59c-0000Nu-7e; Mon, 18 Nov 2024 12:03:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=11YGAbpUTyEW4SB9GGnbZTcxAZF+UHiVvm2B7b8wJ90=; b=MKQYs2l35Yuz vB1IHj2sh/ZDTGUbYebiW+ino798zYK/5VuX9JlFqFPJN2XXgoGM4OMOMILDbB5uMLyxhdVZVveTi 5PmztqgrMfVdVEz/xSboYbwGN7PnD3YlsPj5mvnVIXZe6CZAvuAZHUwMSTrloll8w8fzbaDifxVHD 0/rD2pkTwLGQ3GqaghMqtNLPD/Es6RUfZhuPHhWVeHTM6OvNX6U3Jy8YMoaNxwEu8EKoA4amoGyIh JG6AYg6CuFnpkqDSVp0h1Hfiu33t/kzgPOrDK9PnMoIFtq8qJvoM1k1SQMBrsBFBUKpokRiwF3jYp IRQ11SxxdvS/9+MvxFXZ3A==; In-Reply-To: <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> (message from Dmitry Gutov on Mon, 18 Nov 2024 18:10:02 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295603 Archived-At: > Date: Mon, 18 Nov 2024 18:10:02 +0200 > Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > >> xref-query-replace-in-results will not (or its twin > >> xref-find-references-and-replace). I suppose not many people would > >> expect them to. > > > > This seems to indicate that my proposal is actually okay, since the > > above two commands do not "show results of Xref commands"? > > IIUC your suggestion was: > > If non-nil, the `display-buffer' action for showing results of Xref > commands. > > And those are commands belonging to the package (for the moment), and as > such fitting the description. Not in my book (they are replacement commands), but feel free to find better text. > >> Also, there is a nuance: when the Xref buffer itself is shown (i.e. when > >> there are multiple locations matching a xref-find-definitions search), > >> we're not going to pass (category . xref) to display-buffer either - it > >> is reserved for displaying the buffers of destination locations. > > > > And this is a separate issue, not related to the doc string? > > Still about the doc string. But not important enough to affect the first line of it. > If we say "showing results of Xref > commands", then the Xref buffer with the list of locations also matches > that description, doesn't it? Or rather it might be the first thing a > user would think of - but our customization wouldn't apply to it > immediately. The rest of the doc string could explain this subtlety.