From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Sat, 23 Nov 2024 21:36:10 +0200 Message-ID: <8634jhlp3p.fsf@gnu.org> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> <86serntf0h.fsf@gnu.org> <86h680rhxr.fsf@gnu.org> <87h680fotv.fsf@mail.linkov.net> <864j40pfbw.fsf@gnu.org> <87bjy8e5qc.fsf@mail.linkov.net> <86y11cnyws.fsf@gnu.org> <87iksfpwlr.fsf@mail.linkov.net> <86jzcvof10.fsf@gnu.org> <87h67xren9.fsf@mail.linkov.net> <864j3xlr2r.fsf@gnu.org> <87r071oj96.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6370"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 74361@debbugs.gnu.org, rudalics@gmx.at To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 23 20:39:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEvyV-0001Ww-6e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Nov 2024 20:39:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEvyC-0000JZ-SY; Sat, 23 Nov 2024 14:39:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEvyB-0000JQ-9L for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:39:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEvyB-0007Jz-1K for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:39:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=n47nYCElnmjcnuZKNeWaripvxigRA2rBnSearBmTvqI=; b=s7j76ID9Sz4UkUBKETRVBCdplEGE6AFhXi7u/78mWIJZj8QnnfGvzv7khv8SOAhOns26g6qRGvLgzE9NnK2h/ACjy86EQ2Os5bid6ZmcvtIWp14tnSvpSBXlnVWAF7gu9PqFh3dL9lcIPW7k76q3ocie0k0RsHm0Z5DcGRiMz6m6Hw9MGXVjQzehljRJJdCr5UsgG31a/Jc6bMhLdxqnzRLhbHb3ipJ9BhLRCqkHzkA12hN5D6E6BimSn7Qdekquqv1I+mH9qsFF3Yu2XdNZRwqZHknKl8ClGu6ZbxtmMHU+zQwUoQcB3A8FoyiuVo1e19QvJrSp2+RuB4mZzNRpxQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEvyA-0001hq-Jp for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2024 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.17323907136497 (code B ref 74361); Sat, 23 Nov 2024 19:39:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 23 Nov 2024 19:38:33 +0000 Original-Received: from localhost ([127.0.0.1]:59201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEvxg-0001gi-TA for submit@debbugs.gnu.org; Sat, 23 Nov 2024 14:38:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEvxe-0001gP-GR for 74361@debbugs.gnu.org; Sat, 23 Nov 2024 14:38:31 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEvvS-0006lv-Ck; Sat, 23 Nov 2024 14:36:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n47nYCElnmjcnuZKNeWaripvxigRA2rBnSearBmTvqI=; b=bB53U5Jdhw5+ WeJ60O2ZU+THmLwZKP56IyM9dA8xR543uOpvVvfkkdbU6yplAX/nFsyp8clrsF6VOTE0ji1FlyFAk 0hmOlMmulRlA13HSaoURGOkuu9Yg21rQ64Y+rcB081cVdxX+c6EDjYSv97nJFSrKKm6UDkmeQTxD+ 9Mcg0Pdc17B5NrCb2izO5NwQe8qUYZHqKUmBklAq55rd7xRJG8ipWAvUqy+3CpdUpmEBFVyUx8kF3 RIKkiDzT42likG//+V3FEafLMR9MT9a8yeKWCpJUcn+ekcD28Hm5tZCmpJOEJhlcJQtW+NhBGM1sc JextQK6ZMLezzNZI8QCk2A==; In-Reply-To: <87r071oj96.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 23 Nov 2024 21:14:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295865 Archived-At: > From: Juri Linkov > Cc: dmitry@gutov.dev, rudalics@gmx.at, 74361@debbugs.gnu.org > Date: Sat, 23 Nov 2024 21:14:13 +0200 > > >> >> 1. Demote these options to variables not intended for customization. > >> >> 2. Move their current default values to display-buffer calls. > >> > > >> > I expected to see us do #2 at the same time we deprecated the user > >> > options. I don't understand why we didn't do that. The deprecation > >> > message clearly tells users not to use these variables, so it's > >> > reasonable to expect them to be deleted. Moreover, their presence in > >> > our sources is a potential cause for byte-compilation warnings. > >> > >> Immediate #2 will break customization for many users. > >> We have to give enough time between two releases > >> to allow the users to see a warning and adapt their > >> config files to upcoming deletion of these options. > > > > But isn't it true that if users adapt their config files, the > > customization will stop working for them because category is not used > > by comint? > > Adapting config files means replacing such settings > > (setopt display-comint-buffer-action > '((display-buffer-same-window) > (inhibit-same-window . nil))) > > with > > (add-to-list 'display-buffer-alist > '((category . comint) > (display-buffer-same-window) > (inhibit-same-window . nil))) > > This already works since all corresponding display-buffer calls > already provide the 'comint' category. They do? I thought they use display-comint-buffer-action instead? I just searched the entire Lisp tree, and didn't find even a single match for "(category . comint)" except in the default value of display-comint-buffer-action. So if that user option's value is changed, the replacement above will stop working, no? But I already said that, and it doesn't seem to worry you. So what am I missing here?