bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

[Drew Adams]

FWIW, this crash makes this build unusable for me.
There is no such crash in a build from 2010-07-19.
 
emacs -Q
 
1. Load frame-fns.el, then frame-cmds.el, then thumb-frm.el.
   These libraries are available here:
http://www.emacswiki.org/cgi-bin/wiki?action=index;match=%5C.(el%7Ctar)(%5C.gz)%
3F%24
 
2. (global-set-key [(control ?z)] 'iconify/map-frame)
 
This is the call that crashes (from the debugger):
 
* modify-frame-parameters(#<frame frame-cmds.el
  0x3f54400> ((tool-bar-position
  . top) (parent-id) (explicit-name . t) (display
  . "") (visibility . t) (icon-name) (window-id . "3409140") (top
  . 4) (left . 408) (buried-buffer-list) (buffer-list #<buffer
  frame-cmds.el> #<buffer *Minibuf-1*> #<buffer
  drews-lisp-20>) (unsplittable) (minibuffer) (modeline
  . t) (width . 104) (height . 59) (name
  . "frame-cmds.el") (background-mode . light) (display-type
  . color) (fringe . 0) (alpha) (scroll-bar-width
  . 17) (cursor-type
  . bar) (auto-lower) (auto-raise) (icon-type) (fullscreen) (title)
         (buffer-predicate) (tool-bar-lines
  . 0) (menu-bar-lines . 1) (right-fringe . 0) (left-fringe
  . 0) (line-spacing) (screen-gamma) (border-color
  . "black") (cursor-color . "Red") (mouse-color
  . "Red") (background-color . "LightBlue") (foreground-color
  . "Black") (vertical-scroll-bars
  . right) (internal-border-width . 0) (border-width . 2) (font
  . "-outline-Lucida
  Console-normal-normal-normal-mono-14-*-*-*-c-*-iso8859-1") (font-parameter
  . "-*-Lucida
  Console-normal-r-*-*-14-112-96-96-c-*-iso8859-1") (font-backend
  uniscribe gdi)))
 
 
 
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-08-02 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
 

bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

[Drew Adams]

I still get this crash systematically in the latest build from yesterday.

GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-08-16 on 3249CTO

It crashes systematically with the same simple recipe in every build I have
since 7/19 - that means builds of 8/02, 8/09, and 8/16.

Emacs 24 is now unusable for me, so I hope this will be fixed soon.

bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

[Eli Zaretskii]

> From: "Drew Adams" <drew.adams@oracle.com>
> Date: Tue, 17 Aug 2010 08:53:53 -0700
> Cc: 
> 
> I still get this crash systematically in the latest build from yesterday.
> 
> GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-08-16 on 3249CTO
> 
> It crashes systematically with the same simple recipe in every build I have
> since 7/19 - that means builds of 8/02, 8/09, and 8/16.
> 
> Emacs 24 is now unusable for me, so I hope this will be fixed soon.

I cannot get the packages you cite as needed to reproduce the problem;
the URL seems to be invalid.

Also, is it really a crash, or does Emacs just enters the Lisp
debugger?

bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

[Drew Adams]

> I cannot get the packages you cite as needed to reproduce the problem;
> the URL seems to be invalid.

The URL is perfectly valid, though it might have been split across two lines in
the mail so that you need to sew it together again.  Here it is again:

http://www.emacswiki.org/cgi-bin/wiki?action=index;match=%5C.(el%7Ctar)(%5C.gz)%
3F%24

This is simply the Elisp area of Emacs Wiki.
Here is another URL to the Elisp area, unsorted:
http://www.emacswiki.org/emacs/ElispArea

The first URL I posted is what you get by clicking the link under 1.
Downloading, 1. Elisp Files - Alphabetical.

> Also, is it really a crash, or does Emacs just enters the Lisp
> debugger?

It is really a crash. I showed as much of the Lisp debugger as I was able to see
before Emacs crashed.

bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

[Lennart Borgman]

On Tue, Aug 17, 2010 at 6:53 PM, Drew Adams <drew.adams@oracle.com> wrote:
>> I cannot get the packages you cite as needed to reproduce the problem;
>> the URL seems to be invalid.
>
> The URL is perfectly valid, though it might have been split across two lines in
> the mail so that you need to sew it together again.  Here it is again:
>
> http://www.emacswiki.org/cgi-bin/wiki?action=index;match=%5C.(el%7Ctar)(%5C.gz)%
> 3F%24
>
> This is simply the Elisp area of Emacs Wiki.
> Here is another URL to the Elisp area, unsorted:
> http://www.emacswiki.org/emacs/ElispArea
>
> The first URL I posted is what you get by clicking the link under 1.
> Downloading, 1. Elisp Files - Alphabetical.
>
>> Also, is it really a crash, or does Emacs just enters the Lisp
>> debugger?
>
> It is really a crash. I showed as much of the Lisp debugger as I was able to see
> before Emacs crashed.


I have not looked at this bug at all, but I wonder if it is related to
the crahes I reported before. I think the patch I sent never got
installed, but I am not sure.

bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

[Eli Zaretskii]

> From: "Drew Adams" <drew.adams@oracle.com>
> Cc: <6796@debbugs.gnu.org>
> Date: Tue, 17 Aug 2010 09:53:25 -0700
> 
> > Also, is it really a crash, or does Emacs just enters the Lisp
> > debugger?
> 
> It is really a crash. I showed as much of the Lisp debugger as I was able to see
> before Emacs crashed.

I cannot reproduce this, sorry.  I have 2 builds, one from Aug 8, the
other one from Aug 14, and none of them crashes with your recipe.

One question, to be sure I did what you did: How did you invoke this
line:

  (global-set-key [(control ?z)] 'iconify/map-frame)

I pasted it to *scratch* and then typed C-j after the right paren to
evaluate it.

bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

[Drew Adams]

> I cannot reproduce this, sorry.  I have 2 builds, one from Aug 8, the
> other one from Aug 14, and none of them crashes with your recipe.
> 
> One question, to be sure I did what you did: How did you invoke this
> line:
> 
>   (global-set-key [(control ?z)] 'iconify/map-frame)
> 
> I pasted it to *scratch* and then typed C-j after the right paren to
> evaluate it.

Yes, doing that way reproduces the crash.

But you must also do the following steps to get the crash.
Sorry that I forgot to mention them:

3. C-z
4. C-z

Step 3 thumbifies the frame. Step 4 should dethumbify it. C-z is a toggle to
replace iconify/map by thumbify/dethumbify.  Step 4 crashes Emacs.

Compare with a build of 7/19 or prior, to see the expected behavior.

Thx.

bug#6796: 24.0.50; crash - regression in build of 2010-08-02, modify-frame-parameters

[Eli Zaretskii]

> From: "Drew Adams" <drew.adams@oracle.com>
> Cc: <6796@debbugs.gnu.org>
> Date: Tue, 17 Aug 2010 11:37:46 -0700
> 
> But you must also do the following steps to get the crash.
> Sorry that I forgot to mention them:
> 
> 3. C-z
> 4. C-z
> 
> Step 3 thumbifies the frame. Step 4 should dethumbify it. C-z is a toggle to
> replace iconify/map by thumbify/dethumbify.  Step 4 crashes Emacs.

C-z did the trick.  The problem was caused by Jan's changes from July
29 to support tool bar positioning in GTK builds: this change added a
new frame parameter tool-bar-position, but the array of w32 handlers
for frame parameters was not extended to add a slot for this
parameter.

This bug is now fixed (revno 101110).