unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 54733@debbugs.gnu.org
Subject: bug#54733: Match again in perform-replace
Date: Tue, 21 Jun 2022 20:55:19 +0300	[thread overview]
Message-ID: <861qvhj3j4.fsf@mail.linkov.net> (raw)
In-Reply-To: <9d54db84-77ba-6453-dcfa-864a7c05e692@yandex.ru> (Dmitry Gutov's message of "Tue, 21 Jun 2022 02:59:06 +0300")

>> +				(replace-search search-string limit
>> +						regexp-flag delimited-flag
>> +						case-fold-search backward))
>
> I don't know this code too well, but perhaps SEARCH_STRING here should be
> anchored with something like "\\=" at the beginning?
>
> Otherwise the search can succeed here even if the next match is not
> here. Not sure how important that is, though.

I'm afraid that prepending "\\=" might break a complex regexp somehow.
So maybe using replace-search is not the best thing to do.  I'm inclined
to leave looking-at, but only when the default search function is used.
Currently I'm writing a new function to search in rectangular regions
in bug#14013, but there are many corner cases, so it will take more time.
Then this new function could be used in xref as well since the rectangular
region uses the same pairs of points as xref--query-replace-1 does.
Then perform-replace could detect if this search function is used,
and not to do "the next match now" hack.

>> -         ;; Counteract the "do the next match now" hack in
>> -         ;; `perform-replace'.  And still, it'll report that those
>> -         ;; matches were "filtered out" at the end.
>> -         (isearch-filter-predicate
>> -          (lambda (beg end)
>> -            (and current-beg
>> -                 (>= beg current-beg)
>> -                 (<= end current-end))))
>
> Please note that we'll likely have to keep this code here for a number of
> Emacs releases. So the patch should be tested with both versions: with this
> code present and with it removed, to ensure present and future
> compatibility.

Keeping compatibility should be concerned here definitely.
I hope to post the complete patch in a few days.





  reply	other threads:[~2022-06-21 17:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 17:16 bug#54733: Match again in perform-replace Juri Linkov
2022-04-05 17:53 ` Juri Linkov
2022-04-29 17:41   ` Juri Linkov
2022-05-03  7:10     ` Juri Linkov
2022-06-20 23:59       ` Dmitry Gutov
2022-06-21 17:55         ` Juri Linkov [this message]
2022-06-22  7:36           ` Juri Linkov
2022-06-24 17:25             ` Juri Linkov
2022-06-30 17:52         ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861qvhj3j4.fsf@mail.linkov.net \
    --to=juri@jurta.org \
    --cc=54733@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).