From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Date: Tue, 27 Sep 2022 21:59:04 +0300 Organization: LINKOV.NET Message-ID: <861qrwocbb.fsf@mail.linkov.net> References: <87czbxub4b.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> <86v8pc5yff.fsf@mail.linkov.net> <87r100bbto.fsf@melete.silentflame.com> <86o7v3kj30.fsf@mail.linkov.net> <87r0zxlqa5.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17684"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 57807@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 21:57:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odGi7-0004Pg-Dr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 21:57:43 +0200 Original-Received: from localhost ([::1]:40898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odGi6-0000wT-HF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 15:57:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odGeb-0005T1-0S for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 15:54:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odGeY-0007O4-VZ for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 15:54:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odGeY-0005Gn-Rt for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 15:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs Original-Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166430840020189 (code B ref 57807); Tue, 27 Sep 2022 19:54:02 +0000 Original-Received: (at 57807) by debbugs.gnu.org; 27 Sep 2022 19:53:20 +0000 Original-Received: from localhost ([127.0.0.1]:56862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odGdr-0005FZ-LR for submit@debbugs.gnu.org; Tue, 27 Sep 2022 15:53:19 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:33163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odGdi-0005F1-OM for 57807@debbugs.gnu.org; Tue, 27 Sep 2022 15:53:11 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 55D102000D; Tue, 27 Sep 2022 19:52:58 +0000 (UTC) In-Reply-To: <87r0zxlqa5.fsf@melete.silentflame.com> (Sean Whitton's message of "Mon, 26 Sep 2022 15:33:22 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243762 Archived-At: >> Thanks, I'm going to try it out. > > It looks like I need to call (minibuffer-depth) like > display-buffer-override-next-command does. Updated patch attached. I tested your latest patch with many vc commands, and everything works nicely, even M-x for vc commands without a keybinding and with a prefix arg is supported like in C-x v ! C-u M-x vc-log-search RET (C-u is not needed for vc-log-search anymore, it's just for testing a prefix arg here). > I realised that we could add an override inside vc-read-revision, and > potentially other places, which makes it considerably less annoying. > Done in the attached. Maybe it's fine to disable editing for vc-read-revision, but I'm not sure about other commands, such as e.g. vc-git-log-incoming that runs two git commands: vc-git-command fetch vc-git-command log I see no problem to type an extra RET even for a secondary git command. But it helps in case when someone really wants to edit it.