From: Juri Linkov <juri@linkov.net>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 57807@debbugs.gnu.org
Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches
Date: Tue, 27 Sep 2022 21:59:04 +0300 [thread overview]
Message-ID: <861qrwocbb.fsf@mail.linkov.net> (raw)
In-Reply-To: <87r0zxlqa5.fsf@melete.silentflame.com> (Sean Whitton's message of "Mon, 26 Sep 2022 15:33:22 -0700")
>> Thanks, I'm going to try it out.
>
> It looks like I need to call (minibuffer-depth) like
> display-buffer-override-next-command does. Updated patch attached.
I tested your latest patch with many vc commands, and everything
works nicely, even M-x for vc commands without a keybinding
and with a prefix arg is supported like in
C-x v ! C-u M-x vc-log-search RET
(C-u is not needed for vc-log-search anymore,
it's just for testing a prefix arg here).
> I realised that we could add an override inside vc-read-revision, and
> potentially other places, which makes it considerably less annoying.
> Done in the attached.
Maybe it's fine to disable editing for vc-read-revision,
but I'm not sure about other commands, such as e.g.
vc-git-log-incoming that runs two git commands:
vc-git-command fetch
vc-git-command log
I see no problem to type an extra RET even for a secondary git command.
But it helps in case when someone really wants to edit it.
next prev parent reply other threads:[~2022-09-27 18:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 17:19 bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Sean Whitton
2022-09-14 17:41 ` Eli Zaretskii
2022-09-14 22:42 ` Sean Whitton
2022-09-15 5:33 ` Eli Zaretskii
2022-09-15 16:18 ` Sean Whitton
2022-09-15 16:48 ` Eli Zaretskii
2022-09-15 22:29 ` Sean Whitton
2022-09-14 19:17 ` Juri Linkov
2022-09-14 22:44 ` Sean Whitton
2022-09-15 6:59 ` Juri Linkov
2022-09-15 16:15 ` Sean Whitton
2022-09-15 17:27 ` Juri Linkov
2022-09-15 22:29 ` Sean Whitton
2022-09-16 6:59 ` Juri Linkov
2022-09-18 21:48 ` Sean Whitton
2022-09-19 6:42 ` Juri Linkov
2022-09-20 22:54 ` Sean Whitton
2022-09-21 18:52 ` Juri Linkov
2022-09-21 19:39 ` Sean Whitton
2022-09-22 6:39 ` Juri Linkov
2022-09-22 16:10 ` Sean Whitton
2022-09-22 18:44 ` Juri Linkov
2022-09-22 21:20 ` Sean Whitton
2022-09-23 6:42 ` Juri Linkov
2022-09-23 16:34 ` Sean Whitton
2022-09-24 19:20 ` Sean Whitton
2022-09-24 19:57 ` Juri Linkov
2022-09-24 23:18 ` Sean Whitton
2022-09-25 7:29 ` Juri Linkov
2022-09-26 22:33 ` Sean Whitton
2022-09-27 18:59 ` Juri Linkov [this message]
2022-09-28 1:15 ` bug#57807: vc-edit-next-command (was bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches) Sean Whitton
[not found] ` <87k05ofgfe.fsf_-_@melete.silentflame.com>
2022-09-28 17:53 ` Juri Linkov
[not found] ` <86pmff5qtf.fsf@mail.linkov.net>
2022-09-28 20:41 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861qrwocbb.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=57807@debbugs.gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).