From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "H. Dieter Wilhelm" Newsgroups: gmane.emacs.bugs Subject: bug#60587: Patch for adding links to symbols' help documentation Date: Sun, 22 Jan 2023 14:00:00 +0100 Message-ID: <861qnmvi5r.fsf@duenenhof-wilhelm.de> References: <86y1qgr1bf.fsf@duenenhof-wilhelm.de> <86tu13qydg.fsf@duenenhof-wilhelm.de> <83h6x2u74b.fsf@gnu.org> <863588rfos.fsf@duenenhof-wilhelm.de> <83o7qw0yjy.fsf@gnu.org> <864jskx6a8.fsf@duenenhof-wilhelm.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12050"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 60587@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 22 14:01:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJZyc-0002xH-8j for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Jan 2023 14:01:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJZy5-0006HC-MB; Sun, 22 Jan 2023 08:01:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJZy2-0006Go-LJ for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 08:01:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJZy2-0005hd-Ab for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 08:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJZy2-0007Mv-2S for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 08:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "H. Dieter Wilhelm" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jan 2023 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60587-submit@debbugs.gnu.org id=B60587.167439241828267 (code B ref 60587); Sun, 22 Jan 2023 13:01:02 +0000 Original-Received: (at 60587) by debbugs.gnu.org; 22 Jan 2023 13:00:18 +0000 Original-Received: from localhost ([127.0.0.1]:50863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJZxJ-0007Lr-KJ for submit@debbugs.gnu.org; Sun, 22 Jan 2023 08:00:17 -0500 Original-Received: from mout.kundenserver.de ([217.72.192.75]:44187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJZxH-0007LW-La for 60587@debbugs.gnu.org; Sun, 22 Jan 2023 08:00:16 -0500 Original-Received: from ping ([109.250.147.186]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mofx1-1ovCQq3q49-00p2yg; Sun, 22 Jan 2023 14:00:02 +0100 In-Reply-To: (Stefan Monnier's message of "Fri, 20 Jan 2023 18:32:32 -0500") X-Provags-ID: V03:K1:taBxOSZCZPE717FBK5RYcYVjS5j3mr5qx/bG+4NiqIs5alIsOXt 7GsPYMiZCYp7Y2GYsd1aBSAGrLYlCo3lQLFw0DGEyBC4N9pf4NZHR9nBuHLpLqvdEK+lRcO zTp4lbIhK8EC5cpMsCv6gfko77Wb87+LDVqBcmU9mTQMI10fc9IBozgRfz1h3257XbnJlYH QGVskSlM1raF44TZkhYgA== UI-OutboundReport: notjunk:1;M01:P0:4FGfnt85yAk=;UxEW956pZgIW2Ja/h4x9i5uHtot Ye/CsLpBPV7uXwEfxOQ5WTu4TBIB7M+wp7CpVvb/mnZErLvMkx1232RwaZsOwUcRr50JgYPxK QspUZPGh+uTIK8gzHnggP4F9LhPDeidu+y1ZoB6tAFkMeE+37uca2YbkM5QQl+HEHgxRMrl/y +L22jcKd9LKBFqTSatuPvpVc8dYP0kNKH93b4JCihJGf6+EBIo2XyfJwPFhnJt1Szq216Wtg+ bRFc7NzXOx97TG53qxVcXkfRxBeDrJyoR+Ny0kWdmYNVWdiEJ+HgYNW4lOrz3JGb8aUZNh58M zwd9BrVFvEkREVyGR2vveWqh/sluOMhyVlmDXAo/KqWd+TuUNb5siEKgbQ7RLfOJRbAdz08Zk 47Cak1160V+DiE+iqafFMIj6Tt8T7d7oVpnzRy1tcNs7/YBRD/LYedZy0kB9f9feQyyeijdbA dpQPZKbqXNPQz9LAxD27K+VMFaBznV3F+mYT763UQ+KAbKap+3IZB3wdBUCrf0k3FiFdQQmJt w8yVGkMggS3egM1lhxIgXowF56BBsYTcpa0BAszN5iBw7GeHC8XyhqekQ+O8M63xtfVYUEosb t/Gq7ZfmVNc+2aV484ahEW15I7GlNUm5S7XfiOUjJr+2OhJ5cLKs4EcWyZedP/VezqHenYQ2Q HjjzPPTLrr9/OqNIifzKjVHKaDsI4gc+K/dYqSdy3g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253931 Archived-At: Stefan Monnier writes: >> Unfortunately I also need to investigate the code anew. Yesterday I >> realised a regression starting with Emacs-29! `Tab' and `S-Tab' aren't >> working any longer for Info references. (E.g. the `Tab' keybinding is >> switched from `Info-next-reference' to `forward-button'..) Above information is, in fact, true but too narrow, since the "switching" of keybindings is not occurring in general but only happening when point sits directly on a button. In regular Info text either links, buttons and Info references, can still be reached by Tab (or S-Tab). > My crystal ball suggests that some code somewhere binds > `forward-button` to the "tab" event rather than to the "TAB" event. > "tab" should usually stay unbound (it is then remapped to "TAB" by > `function-key-map`). Poked around in button.el, info.el and help.el but couldn't find any "tab" event binding (only "TAB"). But I think, I found the reason why it appears since Emacs-29, when commenting out the following line in lisp/button.el the keybindings are working as before Emacs-29: (defvar-keymap button-buffer-map :doc "Keymap useful for buffers containing buttons. Mode-specific keymaps may want to use this as their parent keymap." "TAB" #'forward-button "ESC TAB" #'backward-button "" #'backward-button) (defvar-keymap button-map :doc "Keymap used by buttons." -->;; :parent button-buffer-map "RET" #'push-button "" #'push-button "" 'mouse-face ;; FIXME: You'd think that for keymaps coming from text-properties on the ;; mode-line or header-line, the `mode-line' or `header-line' prefix ;; shouldn't be necessary! " " #'push-button " " #'push-button) It seems to me that this is not a regression but some additional functionality of Emacs. I've yet to figure out how to deal with the enhanced keymap of buttons.. -- Thank you for your interest Dieter Best wishes H. Dieter Wilhelm Zwingenberg, Germany