From: Juri Linkov <juri@linkov.net>
To: hugo@heagren.com
Cc: 62606@debbugs.gnu.org
Subject: bug#62606: [PATCH] function to align mode-line elements to right
Date: Sun, 02 Apr 2023 19:19:01 +0300 [thread overview]
Message-ID: <861ql2g0i2.fsf@mail.linkov.net> (raw)
In-Reply-To: <d41f7452947c09b93fa6bc86ceb3f883@heagren.com> (hugo@heagren.com's message of "Sat, 01 Apr 2023 23:27:31 +0100")
> I wanted to be able to right-align some elements of the mode-line. I
> used `tab-bar-format-align-right' as a base and modified it to work with
> the mode-line.
>
> The functin aligns to the right /fringe/ rather than the margin because
> some modes (e.g. [visual-fill-column-mode]) mess around the margin size,
> but the right-align should be unaffected by this.
Does this mean that currently `tab-bar-format-align-right'
doesn't work with `visual-fill-column-mode'? Ok, I tried it out,
and see no problems.
> Patch attached. I want to know that the code is good before I do NEWS
> and docs etc. Obviously it would be useful to document this in info
> (elisp) Mode Line Variables and maybe in the `mode-line-format'
> docstring.
Thanks, everything works nicely when I tried your patch,
but one change was needed:
> + (let* ((rest (cdr (memq 'mode-line-format-right-align
> + mode-line-format)))
> + (rest-str (format-mode-line rest))
Here `format-mode-line' returns an empty string when
`mode-line-format-right-align' was added in the middle
of `mode-line-format'. For a strange reason, it expects
that `mode-line-format' should start with a string.
So everything is fine after replacing in your patch
(rest-str (format-mode-line rest))
with
(rest-str (format-mode-line (append '("") rest)))
next prev parent reply other threads:[~2023-04-02 16:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 22:27 bug#62606: [PATCH] function to align mode-line elements to right hugo
2023-04-02 5:47 ` Eli Zaretskii
2023-05-06 14:14 ` hugo
2023-05-06 14:39 ` Eli Zaretskii
2023-06-05 20:45 ` hugo
2023-06-06 11:24 ` Eli Zaretskii
2023-06-09 12:47 ` hugo
2023-06-09 13:13 ` Eli Zaretskii
[not found] ` <f60acc21a937b413f6528264f233ebfe@heagren.com>
2023-06-09 14:52 ` Eli Zaretskii
2023-04-02 16:19 ` Juri Linkov [this message]
2023-06-09 16:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-09 16:17 ` Eli Zaretskii
2023-06-09 16:52 ` bug#62606: R2L modelines (was: bug#62606: [PATCH] function to align mode-line elements to right) Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-19 19:06 ` bug#62606: [PATCH] function to align mode-line elements to right hugo
2023-06-24 12:05 ` Eli Zaretskii
2023-06-26 10:06 ` hugo
2023-06-26 11:55 ` Eli Zaretskii
2023-07-02 12:43 ` hugo
2023-07-06 7:35 ` Eli Zaretskii
[not found] ` <handler.62606.D62606.168862894016990.notifdone@debbugs.gnu.org>
2023-07-14 16:37 ` Juri Linkov
2023-07-17 17:56 ` Juri Linkov
[not found] ` <CALDnm53v4O9cYcYwcqGpYVb4xVOw6t+FM1xX21k7HFxWyuiSaQ@mail.gmail.com>
[not found] ` <83fryrs1l8.fsf@gnu.org>
[not found] ` <87edebjcku.fsf@gmail.com>
[not found] ` <835xznro5i.fsf@gnu.org>
2024-01-21 10:20 ` João Távora
2024-01-21 10:27 ` Eli Zaretskii
2024-01-21 10:39 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861ql2g0i2.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=62606@debbugs.gnu.org \
--cc=hugo@heagren.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).