From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#67310: [PATCH] Include the project--list as history when prompting for a project Date: Mon, 11 Dec 2023 19:12:23 +0200 Organization: LINKOV.NET Message-ID: <861qbtq630.fsf@mail.linkov.net> References: <421e3ea8-d150-566e-f645-cbf1ccbcba61@gutov.dev> <81b6ed58-3fdc-3b5a-41a9-84d66475d5f1@gutov.dev> <5c3eb6a1-38da-8af4-419a-e0567b163e3a@gutov.dev> <8634wr6s1t.fsf@mail.linkov.net> <861qbujehq.fsf@mail.linkov.net> <780dbb13-c0ca-9082-936b-3c2ab34084dc@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27492"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 67310@debbugs.gnu.org, Spencer Baugh , eliz@gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 18:23:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCjzq-0006vT-Dw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 18:23:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCjyX-0005H7-5j; Mon, 11 Dec 2023 12:21:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCjyV-0005GY-Gw for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 12:21:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCjyV-0002jI-6t for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 12:21:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCjyk-0001vx-0u for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 12:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 17:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67310 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67310-submit@debbugs.gnu.org id=B67310.17023153217419 (code B ref 67310); Mon, 11 Dec 2023 17:22:01 +0000 Original-Received: (at 67310) by debbugs.gnu.org; 11 Dec 2023 17:22:01 +0000 Original-Received: from localhost ([127.0.0.1]:54502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCjyi-0001vb-Km for submit@debbugs.gnu.org; Mon, 11 Dec 2023 12:22:00 -0500 Original-Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:46539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCjyd-0001uq-Pd for 67310@debbugs.gnu.org; Mon, 11 Dec 2023 12:21:57 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 682F460007; Mon, 11 Dec 2023 17:21:33 +0000 (UTC) In-Reply-To: <780dbb13-c0ca-9082-936b-3c2ab34084dc@gutov.dev> (Dmitry Gutov's message of "Sun, 10 Dec 2023 22:32:27 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275999 Archived-At: >>>> This change broke the order of 'C-x p p M-n M-n ...', >>> Could you remind me which behavior in 'M-n M-n' the aforementioned change >>> relates to? Is this supposed to be like input history as well, or the >>> contents of the completions table in a certain order? >> It's inappropriate to overwrite the history with the recently visited projects. >> Only user input should be added to history variables because it's actually >> the history of user input. Therefore, the remaining way to access a list >> of recently visited projects is the future history with 'M-n M-n'. > > But... we do overwrite it now, manually constructing the value of input > history from project--list every time. > > So it seems like both "past history" and "future history" show the same > information now. If so, it might make sense to keep only one. It's usually not good to overwrite past history. So it's better to keep only future history. >>> I just tried find-file, and the future history is empty there, so I suppose >>> this is something we added particularly for project-find-file. >> Unlike with project--list, we don't keep a list of recently visited files. >> Once we conducted an experiment to add all visited files to the input file history, >> even when a file was visited without reading a file name in the minibuffer, >> e.g. by typing RET in Dired. But no one liked this behavior. > > I don't remember that experiment, It was in https://debbugs.gnu.org/12915#121 #+begin_src emacs-lisp (add-hook 'first-change-hook 'add-file-name-to-history) (add-hook 'find-file-hook 'add-file-name-to-history) (defun add-file-name-to-history () (when (and buffer-file-name (not buffer-read-only)) (add-to-history 'file-name-history buffer-file-name))) #+end_src but this clutters the file history too much. > but the description sounds like recentf. Which must have its audience > (and I use it through Ido's "virtual buffers"). 'recentf-list' looks like the right thing to add to future history of 'C-x C-f', but not to its past history. This prototype works nicely: #+begin_src emacs-lisp (define-advice find-file (:around (ofun &rest args) recentf-list) (interactive (lambda (spec) (minibuffer-with-setup-hook (lambda () (when (featurep 'recentf) (setq-local minibuffer-default-add-function (lambda () recentf-list)))) (advice-eval-interactive-spec spec)))) (apply ofun args)) #+end_src so this could be enabled by default when recentf.el is loaded.