From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69187: 29.2; Poor compatibility in align.el Date: Sat, 06 Apr 2024 09:21:18 +0300 Message-ID: <861q7j57vl.fsf@gnu.org> References: <55489.1708171413@localhost> <2214.1708282932@localhost> <2125.1712336273@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14293"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69187@debbugs.gnu.org, ikumi@ikumi.que.jp, John Wiegley To: Arash Esbati Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 06 08:22:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rszRf-0003Vb-0c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Apr 2024 08:22:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rszRB-0004ub-OI; Sat, 06 Apr 2024 02:22:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rszR8-0004uC-7G for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 02:21:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rszR7-0003ci-Tf for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 02:21:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rszRD-00032v-Pv for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 02:22:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2024 06:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69187 X-GNU-PR-Package: emacs Original-Received: via spool by 69187-submit@debbugs.gnu.org id=B69187.171238450811661 (code B ref 69187); Sat, 06 Apr 2024 06:22:03 +0000 Original-Received: (at 69187) by debbugs.gnu.org; 6 Apr 2024 06:21:48 +0000 Original-Received: from localhost ([127.0.0.1]:37978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rszQw-00031y-Ur for submit@debbugs.gnu.org; Sat, 06 Apr 2024 02:21:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rszQt-00031A-U7 for 69187@debbugs.gnu.org; Sat, 06 Apr 2024 02:21:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rszQg-0003Zo-6L; Sat, 06 Apr 2024 02:21:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FwQUUWLuvtNLrOcfoY3UDp7bQRvkQehh4z5VjY7OzOM=; b=OZFP9YFzqON5 4vSu19OT+GExv/nhVyESKVIsy5v/MZxO41pAyocVshTQKLcHQ670b2KGi3oyK4691StYeFCiBdIaD WAhmEeFna3WW1FUwVrY73xJybmigFy908aF6VnrSaC2EH2IK7INXrTo07WX3OY+dKFzFR1WBWSu53 Hhop+yJTCGdzi7JPi2Tz2xaRUN9zd4gXXebpprYpePokckOzHvQ7uGhjIjkwzM58/ZoLjUKGc/Ez7 hhw+rdb9+kQClFzHczJSB2Yw4zZNRPLC0y/quSl3Epd+yEyZCe1DoUh4cqRlAw6l502o74T/ixgWS FPcStsi3Fen8VIdGM7CGLQ==; In-Reply-To: (message from Arash Esbati on Fri, 05 Apr 2024 21:59:06 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282739 Archived-At: > Cc: 69187@debbugs.gnu.org > From: Arash Esbati > Date: Fri, 05 Apr 2024 21:59:06 +0200 > > Ikumi Keita writes: > > > That would practically do the job as well, because this entry wouldn't > > be relevant in buffers in modes other than latex (LaTeX) mode > > actually. My proposal is just to keep the precise behavior the same. > > Agreed, so the change would look like this, right? > > --8<---------------cut here---------------start------------->8--- > diff --git a/lisp/align.el b/lisp/align.el > index 81ccc4b5e2d..0e77a857585 100644 > --- a/lisp/align.el > +++ b/lisp/align.el > @@ -537,10 +537,8 @@ align-rules-list > (regexp . ,(lambda (end reverse) > (align-match-tex-pattern "\\\\[=>]" end reverse))) > (group . (1 2)) > - (modes . align-tex-modes) > - (repeat . t) > - (run-if . ,(lambda () > - (eq major-mode 'latex-mode)))) > + (modes . '(latex-mode)) > + (repeat . t)) > > (tex-record-break > (regexp . "\\(\\s-*\\)\\\\\\\\") > --8<---------------cut here---------------end--------------->8--- > > @Maintainers: How do you want to proceed with this proposal? Do you > like to ask John W., or should I prepare a patch and send/install it, or > anything else? > > For bonus points, I offer to delete the unnecessary ":group 'align" in > the defcustom's in align.el. > > Please advise. Thanks. Please explain the issue in more detail and in terms that someone who doesn't use AUCTeX and has only superficial understanding of align.el can understand and reason about. Three questions that pop up immediately, perhaps because I'm missing something: . what is the rationale for not using align-tex-modes here, only latex-mode? . why not just add the new LaTeX-mode to the list in align-tex-modes, so that people who use an old AUCTeX will not have their align rules broken? . why not use derived-mode-p instead of 'equal' in the run-if form (and why remove it in the first place)? (And, btw, why did AUCTeX change the name of the mode? What useful purpose could that possibly serve? Changing names of major modes is the last thing I'd expect from a veteran package that respects its users.)