From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70230: 30.0.50; [PATCH] * lisp/master.el (master-says): check nil parameter Date: Sat, 06 Apr 2024 18:30:10 +0300 Message-ID: <861q7i33wd.fsf@gnu.org> References: <86h6ge5313.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30873"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70230@debbugs.gnu.org To: Lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 06 17:31:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rt80n-0007ri-9r for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Apr 2024 17:31:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rt80c-0006d8-TH; Sat, 06 Apr 2024 11:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rt80X-0006Zu-89 for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 11:31:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rt80O-0000Kt-7t for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 11:31:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rt80U-0003tb-EG for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 11:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2024 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70230-submit@debbugs.gnu.org id=B70230.171241742814929 (code B ref 70230); Sat, 06 Apr 2024 15:31:02 +0000 Original-Received: (at 70230) by debbugs.gnu.org; 6 Apr 2024 15:30:28 +0000 Original-Received: from localhost ([127.0.0.1]:40641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7zw-0003sj-7W for submit@debbugs.gnu.org; Sat, 06 Apr 2024 11:30:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7zt-0003rs-Cw for 70230@debbugs.gnu.org; Sat, 06 Apr 2024 11:30:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rt7zh-000097-JK; Sat, 06 Apr 2024 11:30:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=o3AjKbpYIRlshLULj1kOakNS1YP7twX35xJ0eFWioJA=; b=lMEpolICl3o0rtoMMRLL c8c/yNnAKZW29iu7V8od6emU/nIJmnuXO57BQD6D88+mJ6xUtaGr4SpEinNPtJb3aN9b9Bn6NNpuu qL3GqPLqL6JjUoS7qtZnDgalyP1UTjyTIujtMsz/FNLq1vMafszuns+5jfMXMRX/pGsU55GK3sn7e gbOJGvCdzHLbBbSwbqjkSjKH1+EnjfMiLlhi80fzf5YiHQL7AlUpB2YRCcvFOtdpjFvG76m2X5aul c7Z3VKtGgPgfE5utVyDSpa2sJK3jJxXq3UPQUuYygVyFXg8+drDAO8jEXhs8zSmmnam50cY7rFe17 ZA/geZucbwy9Vg==; In-Reply-To: (message from Lin Sun on Sat, 6 Apr 2024 15:25:35 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282801 Archived-At: > From: Lin Sun > Date: Sat, 6 Apr 2024 15:25:35 +0000 > Cc: 70230@debbugs.gnu.org > > On Sat, Apr 6, 2024 at 8:06 AM Eli Zaretskii wrote: > > Thanks, but "Slave buffer has disappeared" doesn't sound like a good > > error message when master-of is nil, does it? > Totally, the message will confuse the user. I modified the patch and > it checks the parameter `master-of' and gives a message "Slave buffer > does not exist" when it's nil. I think "Slave buffer does not exist" is not the best message, since the slave master is simply undefined in that case. A better message would be something like "Current buffer is not a master of any other buffer".