From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70697: 30.0.50; Frame parameter alpha-background is ignored for fringe bitmaps & internal borders Date: Thu, 27 Jun 2024 10:41:29 +0300 Message-ID: <861q4i7ryu.fsf@gnu.org> References: <86eda1kf2w.fsf@NOAH310-L.mail-host-address-is-not-set> <86y17ooj45.fsf@gnu.org> <87a5k4kb8o.fsf@yahoo.com> <87bk4hai6c.fsf@aleks.bg> <86v82avd5j.fsf@gnu.org> <87tthu5u6i.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39758"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70697@debbugs.gnu.org To: mail@aleks.bg, Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 09:42:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMjlk-000A5h-Tj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 09:42:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMjla-0006eX-1j; Thu, 27 Jun 2024 03:42:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjlX-0006e9-Ev for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:41:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMjlX-0002v0-7F for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:41:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMjlZ-00069J-UL for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 07:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70697 X-GNU-PR-Package: emacs Original-Received: via spool by 70697-submit@debbugs.gnu.org id=B70697.171947410223603 (code B ref 70697); Thu, 27 Jun 2024 07:42:01 +0000 Original-Received: (at 70697) by debbugs.gnu.org; 27 Jun 2024 07:41:42 +0000 Original-Received: from localhost ([127.0.0.1]:40908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMjlG-00068c-93 for submit@debbugs.gnu.org; Thu, 27 Jun 2024 03:41:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMjlE-00068P-KD for 70697@debbugs.gnu.org; Thu, 27 Jun 2024 03:41:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjl6-0002tK-9X; Thu, 27 Jun 2024 03:41:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/8YCDV++L1Ml1dFLizy/Uvf22k5ZDHs8N5uO/xtFCoY=; b=k7GjBebVzkhq 2uTVW6nYw7I0ZzI8cxaONnkr7YJJYpxM6dLxvU70YRoJi3jIEzLp5QCle3Ab8dXUhyqBF0opf7Crg d+1VYZma+h3uDxQwEFRKP8c5mbewLhfgLdpnMRiy1QKLUu2sSqaI4G9dJ17icNu509UBZRTDXx8fU 5nuenQzl+tk2if6fxgyxeyZAhSGW3+Vu0QfM6ZwwTwsKItH8rUSq/uYPvxOIJcPTR1a0fdy8HoSGt 2gvZLfPa8nK1pLBnTfZi1/f5ZoZ5p6gfUtMQN2mmLQwCDFGvqG47n/zrKHxn5FM/WneUn9WwS077R K2i+TtB6t+EmDo76hIOnSQ==; In-Reply-To: <87tthu5u6i.fsf@yahoo.com> (message from Po Lu on Sat, 15 Jun 2024 19:20:21 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287994 Archived-At: Ping! Aleksandar, can you please try Po Lu's patch and report back? > From: Po Lu > Cc: Aleksandar Dimitrov , 70697@debbugs.gnu.org > Date: Sat, 15 Jun 2024 19:20:21 +0800 > > Eli Zaretskii writes: > > > Ping! How should we proceed with this issue? > > > >> From: Aleksandar Dimitrov > > Alexander, is there something suspicious as to your mail host that is > prompting mine to discard your responses? They aren't even classified > Bulk Mail, just quietly disposed of. > > >> Welp, I never said I'm good at this :D > >> I didn't know there was a difference between the --with-toolkit and > >> --with-x-toolkit options. The former isn't documented in ./configure > >> --help, it seems. I've opted to only use --with-x-toolkit from now on. > >> > >> I have conducted some experiments now: > >> --with-x-toolkit=lucid & your patch: > >> No transparency support. > >> > >> --with-x-toolkit=gtk3 & your patch: > >> Transparency in fringes works. > >> Internal borders are NOT transparent. > >> This is identical to my previous test with --with-toolkit=lucid, which > >> wasn't doing what I expected it to. > >> > >> --with-pgtk & your patch: > >> Transparency in fringes DOES NOT work > >> Internal borders ARE transparent > >> (also, Emacs is very slow, e.g. when rendering company popups, but > >> that's unrelated) > >> > >> All of these tests are conducted with the above Emacs version and on > >> Wayland. > > Yes, thanks. Please try the patch attached: its effect should be to > homogenize PGTK's display with the X port's. > > diff --git a/src/pgtkterm.c b/src/pgtkterm.c > index 49b7ea406f8..e379ed33c01 100644 > --- a/src/pgtkterm.c > +++ b/src/pgtkterm.c > @@ -3594,20 +3594,7 @@ pgtk_draw_fringe_bitmap (struct window *w, struct glyph_row *row, > pgtk_clip_to_row (w, row, ANY_AREA, cr); > > if (p->bx >= 0 && !p->overlay_p) > - { > - /* In case the same realized face is used for fringes and for > - something displayed in the text (e.g. face `region' on > - mono-displays, the fill style may have been changed to > - FillSolid in pgtk_draw_glyph_string_background. */ > - if (face->stipple) > - fill_background_by_face (f, face, p->bx, p->by, p->nx, p->ny); > - else > - { > - pgtk_set_cr_source_with_color (f, face->background, true); > - cairo_rectangle (cr, p->bx, p->by, p->nx, p->ny); > - cairo_fill (cr); > - } > - } > + fill_background_by_face (f, face, p->bx, p->by, p->nx, p->ny); > > if (p->which > && p->which < max_fringe_bmp > @@ -5014,14 +5001,16 @@ pgtk_clear_under_internal_border (struct frame *f) > > if (face) > { > - fill_background_by_face (f, face, 0, margin, width, border); > - fill_background_by_face (f, face, 0, 0, border, height); > - fill_background_by_face (f, face, width - border, 0, border, > - height); > - fill_background_by_face (f, face, 0, (height > - - bottom_margin > - - border), > - width, border); > + pgtk_fill_rectangle (f, face->foreground, 0, margin, width, > + border, false); > + pgtk_fill_rectangle (f, face->foreground, 0, 0, border, height, > + false); > + pgtk_fill_rectangle (f, face->foreground, width - border, 0, > + border, height, false); > + pgtk_fill_rectangle (f, face->foreground, 0, (height > + - bottom_margin > + - border), > + width, border, false); > } > else > { >