From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72405: 29.4; Doc string of `org-indent-mode' Date: Wed, 14 Aug 2024 10:55:20 +0300 Message-ID: <861q2ra68n.fsf@gnu.org> References: <86cymsyguu.fsf@gnu.org> <877cd0iyw4.fsf@gmail.com> <8734noiy1b.fsf@gmail.com> <86zfpwwyu4.fsf@gnu.org> <87frr7zv3b.fsf@gmail.com> <86le0zfx9l.fsf@gnu.org> <877ccjzk0m.fsf@gmail.com> <86ed6rfvm0.fsf@gnu.org> <87y14zy36y.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31678"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72405@debbugs.gnu.org, monnier@iro.umontreal.ca, drew.adams@oracle.com To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 14 09:56:45 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1se8s9-00084i-8m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Aug 2024 09:56:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1se8rs-0007t8-Uy; Wed, 14 Aug 2024 03:56:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se8rr-0007sb-Ei for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 03:56:27 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1se8rr-00071k-4z for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 03:56:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=PPxaZP3WcNPasDAm8B6thby/GwL9avPJry7rdq0DXnQ=; b=kPQIi0dRIcTRqwKT1H0LRxTT3d6C4cQ+FLFvrZlOXFpeeX4kcIu5DH1ZZVorzD9k2qL4i7TVlC9g+EwCtpa7YscGJKk7RhtMECkOOsie7aADLVFytb3tFZv5zIyGAhrhruJ7+3l9vlD8c++aWmUVo57M1rUD5R0vHuOUtdssvaiXgYl8I4jf4fxemDLrWB9Senc8B4rJwbPg4WcO8CCltleMfv6bdCi0iOgpz6UnFZMkeVwcUqnXYtYRmdTNcJ/ignD03hFuAwqkt7HhB2SVJaPvf3nUL1l05ZHLAIrGVzwX2n+p2f0qhNUKSWeHiz+nhxWDnjFOi/SVBdQhsMz8TQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1se8sP-0003f2-JW for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 03:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Aug 2024 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72405 X-GNU-PR-Package: emacs Original-Received: via spool by 72405-submit@debbugs.gnu.org id=B72405.172362216714001 (code B ref 72405); Wed, 14 Aug 2024 07:57:01 +0000 Original-Received: (at 72405) by debbugs.gnu.org; 14 Aug 2024 07:56:07 +0000 Original-Received: from localhost ([127.0.0.1]:45966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1se8rW-0003dl-RC for submit@debbugs.gnu.org; Wed, 14 Aug 2024 03:56:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1se8rV-0003dI-AJ for 72405@debbugs.gnu.org; Wed, 14 Aug 2024 03:56:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se8qr-0006vz-1W; Wed, 14 Aug 2024 03:55:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PPxaZP3WcNPasDAm8B6thby/GwL9avPJry7rdq0DXnQ=; b=ALkb4wTsfPWY op0Gun+//nOcBH3Zm+a7KlAvSxlCVdvZAu1JPVHbs1yHPhJ4Av4XSY0zfviqrMdchE6j9vHWjZkby oKCV6rHHVgOcUyZGppdo2N+KLylNq321mheBOSjq1TQkXXQNsfuvnjN4NxjOVpDgEvmK3N3BBWEwP h6wKWgho/bn9HHLA03SHQVr184KYqltfwAko4ebCPqyDMGKybeVtlpp38m+Yd0OffQa4JiUKGqCPE f2Cltt7+dtX9MsUvYXpD8rZNzPH4SQa4sScqzM+ujmEAOSitW2xOnlg9AH+nMSec1mEWlNQkwX9Kw BVR5yZfF2fiaK2Ao9p7b2g==; In-Reply-To: <87y14zy36y.fsf@gmail.com> (message from Visuwesh on Wed, 14 Aug 2024 12:57:17 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290120 Archived-At: > From: Visuwesh > Cc: monnier@iro.umontreal.ca, 72405@debbugs.gnu.org, drew.adams@oracle.com > Date: Wed, 14 Aug 2024 12:57:17 +0530 > > >> Is the attached patch fine? > > > > Yes, but please use 'if' rather than 'when'. > > Sorry, but I'm confused. I used 'when' because > > (concat nil "xxx") ;; => "xxx" Yes, of course. But 'if' also returns nil if its condition is false: (if (symbolp 1) "symbol") => nil So you can still use the original code, which uses the above behavior of 'concat', after replacing 'when' with 'if' in your original code. The reason I asked to use 'if' is that there's no reason to use 'when' here, as the BODY of 'when' will only ever be a single string.