From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: rudalics@gmx.at, 73734@debbugs.gnu.org
Subject: bug#73734: [PATCH] Fix tmm menu layout
Date: Sat, 12 Oct 2024 17:44:18 +0300 [thread overview]
Message-ID: <861q0lwfct.fsf@gnu.org> (raw)
In-Reply-To: <87wmidbef1.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 12 Oct 2024 16:10:10 +0200)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: rudalics@gmx.at, 73734@debbugs.gnu.org
> Date: Sat, 12 Oct 2024 16:10:10 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> [...]
>
> > This doesn't align bindings if a variable-pitch font is used, but
> > it still produces a better display than the current code does when
> > variable-pitch font is the default font.
>
> Thanks, yes this is better to remove the confusion (but sometimes misses
> bindings alignment). To finalize this patch, I still have two questions
> left:
>
> - What is the purpose of the "(min 30)"? Because if the window
> is large enough this will always return 30.
First, I didn't write this code and don't consider myself an expert,
so what follows are basically my guesses. (In the code I proposed I
simply didn't touch those parts to clearly separate my changes from
the rest.)
I think the minimum of 30 is there to make sure we don't produce just
2 sets of columns when the window is wide enough to allow more. This
uses the screen real estate more efficiently, so the *Completions*
window is not as tall as it would be with just 2 sets of columns.
> - Should we use frame-width instead of window-width? It seems
> that when this function is called (get-buffer-window
> "*Completions*") always returns nil.
I think we should fall back to frame-width, but use the width of the
*Completions* window if it exists. I'm quite sure there's a sequence
of commands which will leave the *Completions* buffer on display, and
in that case the window showing it will be reused.
next prev parent reply other threads:[~2024-10-12 14:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 13:53 bug#73734: [PATCH] Fix tmm menu layout Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 16:14 ` Eli Zaretskii
2024-10-10 18:00 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 18:29 ` Eli Zaretskii
2024-10-11 6:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 6:51 ` Eli Zaretskii
2024-10-11 7:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 8:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 9:26 ` Eli Zaretskii
2024-10-11 10:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 16:44 ` Eli Zaretskii
2024-10-12 14:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 14:44 ` Eli Zaretskii [this message]
2024-10-12 15:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 16:26 ` Eli Zaretskii
2024-10-12 16:40 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 8:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 9:46 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 7:29 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 7:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 8:15 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 9:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861q0lwfct.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73734@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).