unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Ship Mints <shipmints@gmail.com>
Cc: 74087@debbugs.gnu.org
Subject: bug#74087: Bug patch: invoke tab-bar-tab-post-open-functions during tabs initialization
Date: Tue, 29 Oct 2024 20:52:02 +0200	[thread overview]
Message-ID: <861pzy3fot.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAN+1HbrBWxQX0gEs22ysnfqnKAyXvdCtVsX-ceC5Vq5u8gUs3A@mail.gmail.com> (Ship Mints's message of "Tue, 29 Oct 2024 14:29:48 -0400")

>> I'm trying to align all tab creation behavior with
>> tab-bar-tab-post-open-functions. Even the first tab should be
>> considered "opened" by the system and call people's functions on the
>> hook. That tab, if you close it, does call the close hooks correctly
>> and that's aligned, at least.

Calling the close hooks currently doesn't look correct:

      (run-hook-with-args 'tab-bar-tab-pre-close-functions
                          (nth close-index tabs)
                          last-tab-p)
      (if last-tab-p
          (pcase tab-bar-close-last-tab-choice
            ('nil
             (user-error "Attempt to delete the sole tab in a frame"))

where first it makes an attempt to close the tab, calls the hook,
then fails with the user-error.  I think the hook should be called
when the tab is really closed.

>> If the open hook doesn't get called, then
>> those tabs have to be treated in a special way and that creates bugs
>> and burden. Not sure how relevant it is what I do in my custom hook
>> that should get called for the implied opened first frames but doesn't.
>
> If you're really curious, one use case is auto-assigning a tab group. When
> one makes a frame, the tab bar defaults to showing the window from which it
> was created and any custom tab-bar symbols attached to the tab have to be
> recreated. Another use case is optionally keeping tabs "pinned" to their
> user-specified positions and the post-open hook can help track the first
> and subsequent positions. I'll surely add more over time. tab-bar is great
> and fun to use and enhance with cool productivity tools.

Thanks, this is an interesting case.  Indeed, currently
there is an inconsistency.  For example, start `emacs -Q`.
Even if there is no tab-bar initially, we can say that
the first tab is already created.  Later, after creating
the second tab with 'C-x t 2', we have two tabs where
the post-open hook was called only in the second tab.

A possible solution would be to detect such situation
in 'tab-bar-new-tab-to' with the same code that
enables the tab-bar initially with:

    (when tab-bar-show
      (if (not tab-bar-mode)
          ;; Turn on `tab-bar-mode' since a tab was created.
          ;; Note: this also updates `tab-bar-lines'.
          (tab-bar-mode 1)
        (tab-bar--update-tab-bar-lines)))

then run the hook in the first tab as well.





  parent reply	other threads:[~2024-10-29 18:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 14:12 bug#74087: Bug patch: invoke tab-bar-tab-post-open-functions during tabs initialization Ship Mints
2024-10-29 18:13 ` Juri Linkov
2024-10-29 18:19   ` Ship Mints
2024-10-29 18:29     ` Ship Mints
2024-10-29 18:43       ` Ship Mints
2024-10-29 18:52       ` Juri Linkov [this message]
2024-10-29 19:03         ` Ship Mints
2024-10-29 19:07           ` Juri Linkov
2024-10-29 19:18             ` Ship Mints
2024-10-29 19:23               ` Ship Mints
2024-10-29 19:32                 ` Ship Mints
2024-10-29 19:46                   ` Juri Linkov
2024-10-29 20:04                     ` Ship Mints
2024-10-29 20:05                       ` Ship Mints
2024-10-30  7:24                         ` Juri Linkov
2024-10-30 12:41                           ` Ship Mints
2024-10-30 18:32                             ` Juri Linkov
2024-10-30 18:38                               ` Ship Mints
2024-10-30 19:02                                 ` Eli Zaretskii
2024-10-30 19:29                                   ` Juri Linkov
2024-10-30 13:44         ` Ship Mints
2024-10-30 18:30           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861pzy3fot.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=74087@debbugs.gnu.org \
    --cc=shipmints@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).