From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74413: [PATCH] Allow to store and read repository information of VCS builds Date: Mon, 18 Nov 2024 21:03:11 +0200 Message-ID: <861pz8uzyo.fsf@gnu.org> References: <86frnovhg8.fsf@gnu.org> <867c90vbfk.fsf@gnu.org> <87frnowkhp.fsf@> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13743"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 74413@debbugs.gnu.org, stefankangas@gmail.com To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 18 20:04:43 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tD73D-0003RY-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Nov 2024 20:04:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tD72k-0003Mq-Cx; Mon, 18 Nov 2024 14:04:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD72c-0003MX-CW for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 14:04:10 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tD72Y-000769-Or for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 14:04:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=p650dfUq6XslKIhYENY3Uxqw7p4cbI0ExEIMcjLy3Wg=; b=iN4Adt5aT9HTmsz4NBXSrMh+UAvhs0tuf4x6m0k7p21BlYijudT3zdjdu964pxcR7Duifw4GQFthgQiQyMzcmTNhwP9Y80WK4pe+dQTuCPcXWSdGypYsxVP9ej8OYFLXfreygkeyrO6+Jhxehnc8Fvp/6X3IU/4vrLcSKpZSDlYeXPvXXflzXynLgGfRERx/+cDDenQLit3q4cj1zcO9xMA9+w86HAVXMtv2Ou5oGpbLg0WMsG4JU0+klnexzxiEal5N+z7vZb0hOoluWmuKcC08Uhr8iehUzRme298Qbe3L2wJ+Ws0x+53Ijaz3rm/Xp2GEEjCPWlOaGJf2hZgKJQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tD72Y-0001V7-FK for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 14:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2024 19:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74413-submit@debbugs.gnu.org id=B74413.17319566055703 (code B ref 74413); Mon, 18 Nov 2024 19:04:02 +0000 Original-Received: (at 74413) by debbugs.gnu.org; 18 Nov 2024 19:03:25 +0000 Original-Received: from localhost ([127.0.0.1]:35169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD71w-0001Tu-QM for submit@debbugs.gnu.org; Mon, 18 Nov 2024 14:03:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD71t-0001Tc-Sz for 74413@debbugs.gnu.org; Mon, 18 Nov 2024 14:03:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD71n-0006zx-SY; Mon, 18 Nov 2024 14:03:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=p650dfUq6XslKIhYENY3Uxqw7p4cbI0ExEIMcjLy3Wg=; b=NJ3t1y2LfoqYdYZeOiQ3 Huym1nL4ZhffTCP1C/DgrKgEOgjGB3kCujZ21IgawqWEKiORbjr9VlfhjThj9xTVvz6tvvvZ6+ZnD oRUnhYQPEzBvWMsxxt0CDw7QPzfzd1JOpw1G7+ZAxC7RlqD5ze5FIsOcXOQewPSTahPLr3MVps4xi RpyBqT8RwR5ByyNOWGCSNiVVi0YwZulXW7wHVzm65od9zPxbd3II1V1u5t3HCwYmWsJrKXTbLLWxk sl6pEb9/rSxnwY9zlJXK7qAVcjzIigEty5M1O79AXsTP+R9+Z9pr1KmHCAKQXlXYyyBVi8tBhxIio OLEa6BJO/NjnUA==; In-Reply-To: <87frnowkhp.fsf@> (message from =?UTF-8?Q?Bj=C3=B6rn?= Bidar on Mon, 18 Nov 2024 18:54:26 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295606 Archived-At: > From: Björn Bidar > Cc: Stefan Kangas , luangruo@yahoo.com, > 74413@debbugs.gnu.org > Date: Mon, 18 Nov 2024 18:54:26 +0200 > > Eli Zaretskii writes: > > > This is already available if Emacs is built in a Git repository, and > > the information is stored in the dumped Emacs. So what is gained by > > also recording the repository version on a disk file external to > > Emacs? > > The information is only stored if the worker already had git installed > and checked out the sources with git inside the worker. > Also the function currently fails unless the system the user uses also happens to > have git installed and the sources if the are installed also contain the > VCS metadata. > Storing the VCS metadata in the sources doesn't happen usually as it > increases the size of a good chunk. In my case e.g. from 188MB to 788MB. > Why not have the same feature for other platforms too? Sorry, I don't understand this explanation; I'm probably missing something. The feature you propose requires to build Emacs inside a Git repository, is that correct? Because otherwise "git rev-parse" will not work, right? If that is correct, then building Emacs inside a Git repository already calls this Git command and records the result in 2 Emacs Lisp variables. So why do you also want to record the same information on a file? What kind of scenario do you have in mind in which building Emacs with its current code will not record the branch and the revision, but your additions to Makefile will record that?