From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image Date: Sat, 07 Dec 2024 18:21:25 +0200 Message-ID: <861pyjihve.fsf@gnu.org> References: <2304cad6-884f-4528-a85e-ab9c06b80016@orange.fr> <868qsrim4a.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25757"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74725@debbugs.gnu.org, da_vid@orange.fr To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 17:22:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJxZZ-0006Ug-Lo for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 17:22:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJxZE-000254-PH; Sat, 07 Dec 2024 11:22:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJxZD-00024j-9z for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:22:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJxZD-0006Rf-1t for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:22:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=cyKOPtbOl8BDXErVUXy3M7j4dQlWjywe6x65XgBAM/8=; b=kjSunlpUQWD7pCl+b2fwsLuZaSLVU1esGxs/NkaQxqflbkjhAdeJedwokxKm/mq+y0LdRO5YOs/u9ANMuST50CBVEPrb1pOYGRweZq23QlFysFdEvQDf4AAPiLlIea6y2VDU+G/uCvM8aqDSdXLCQq0KnuHxy12/S+AffvVedBeYsBaTHJomG0tKDFiOh8jRRuc/Szr8U7JmQD8i659CPBSLQDXkctZuSceZ8BFId1nZdgAZJdhOobbyMUAKVFz1rtNq2m1q6FIR1CE8tyP7MoTxWRgz7f2gdoOd4HTAXowq2B/9rMawFZDvMfn9nIXXlewWkIn+5x5mdobgLOYmDQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJxZC-0005r0-Fw for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74725 X-GNU-PR-Package: emacs Original-Received: via spool by 74725-submit@debbugs.gnu.org id=B74725.173358851622484 (code B ref 74725); Sat, 07 Dec 2024 16:22:02 +0000 Original-Received: (at 74725) by debbugs.gnu.org; 7 Dec 2024 16:21:56 +0000 Original-Received: from localhost ([127.0.0.1]:48278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJxZ6-0005qa-B4 for submit@debbugs.gnu.org; Sat, 07 Dec 2024 11:21:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJxZ1-0005qF-KR for 74725@debbugs.gnu.org; Sat, 07 Dec 2024 11:21:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJxYt-0006PT-GN; Sat, 07 Dec 2024 11:21:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cyKOPtbOl8BDXErVUXy3M7j4dQlWjywe6x65XgBAM/8=; b=HJieaeMuew9j se/+We2QzPf1qKQJG+58pPHBA/NzVsFEGFvlggu6hdjmTmPqBGfVl+Arl+v1TjLqoTGP4pXz30N5g x3s4ItY0DIGndx7HAtjdjaH9/1ZBZXTSrMkPOAeLp211pLFYKD3D+VZMHnoajw7owqsWWiM1m+Kke jfcx/YyyS316R5KFk4+hqbTo8V8cp4NOODRmdl7sCi0Yzy5scXTtArdKC3V+aelb8Nfa7yV6mYp9u Bp3fbNpihjGeQI2zViumeH4QdlvrquVVTgzpVG/sl4vVwbLazO1CYdHiCLrdGxGXD0+dhFoE6Sh9r UF0jw65HjzNghIq52Kh4+w==; In-Reply-To: (message from Alan Third on Sat, 7 Dec 2024 15:49:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296578 Archived-At: > Date: Sat, 7 Dec 2024 15:49:47 +0000 > From: Alan Third > Cc: David Ponce , 74725@debbugs.gnu.org > > On Sat, Dec 07, 2024 at 04:49:41PM +0200, Eli Zaretskii wrote: > > > Date: Sat, 7 Dec 2024 13:13:58 +0100 > > > From: David Ponce via "Bug reports for GNU Emacs, > > > the Swiss army knife of text editors" > > > > > > While working with images, I found what seems an issue to me with > > > `create-image' which unconditionally set the :scale image property to > > > 'default' when not specified, ignoring the value of the option > > > `image-scaling-factor'. > > > > > > Here is an illustration: > > > > > > (let ((image-scaling-factor 1.0)) > > > (image-size > > > (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg"))) > > > t)) > > > => (63 . 63) > > > > > > (let ((image-scaling-factor 2.0)) > > > (image-size > > > (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg"))) > > > t)) > > > => (63 . 63) > > > > > > (image-size > > > (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg" :scale 1))) > > > t) > > > => (48 . 48) > > > > > > (image-size > > > (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg" :scale 2))) > > > t) > > > => (96 . 96) > > > > > > You can replace `image-size' with `insert-image' and observe the same. > > > > > > Here is a simple patch which fix the issue for me: > > > > > > diff --git a/lisp/image.el b/lisp/image.el > > > index ce97eeb3ca1..2c1e865c336 100644 > > > --- a/lisp/image.el > > > +++ b/lisp/image.el > > > @@ -536,7 +536,9 @@ create-image > > > file-or-data) > > > (and (not (plist-get props :scale)) > > > ;; Add default scaling. > > > - (list :scale 'default)) > > > + (list :scale (if (numberp image-scaling-factor) > > > + image-scaling-factor > > > + 'default))) > > > props))) > > > ;; Add default smoothing. > > > (unless (plist-member props :transform-smoothing) > > > > AFAIU, this is supposed to be taken care of in image.c. > > > > Alan, any ideas why this doesn't seem to work? > > It's because the image spec doesn't change so the image is pulled from > the cache each time. > > Flushing the image between calls to image-size fixes it: > > (image-flush (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg")))) > > I'm not sure what the solution is here. My feeling is that > image-scaling-factor isn't intended as something you set for each > image as you load it, it's a set-and-forget setting, so perhaps we > just need to document that in order for it to take effect the image > cache needs to be flushed. > > Alternatively we make the image cache aware of it. > > Perhaps we can flush the cache automatically when it changes? That > might give unexpected results too. I think recording the scale in the cache, and rejecting the cached image if the scale doesn't match, will cause the least surprise. But I'm open to other opinions and suggestions. Thanks.