From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73472: [PATCH] Substitute quotation marks in Eglot messages Date: Sat, 28 Dec 2024 13:00:19 +0200 Message-ID: <861pxsul6k.fsf@gnu.org> References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17178"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@thomasvoss.com, 73472@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 28 12:01:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRUZG-0004HL-En for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Dec 2024 12:01:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRUZ6-0003mi-Jz; Sat, 28 Dec 2024 06:01:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRUZ4-0003mA-Q8 for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 06:01:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRUZ4-0003jM-H1 for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 06:01:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=3x1dPN5RoDodccu3ErbtPAeIH5s76M6Rd6osTSYisMI=; b=VlH0kJzHqGuWIJJ4FHkzYllHyNjZdzUyqRXy4CicsvxPqD3cMthHRhMwzpk8Ly52KlvNZ4ufAWFn6PFQ0UrxyRjxwsqgIKsKxX3U/byHi96revfvoclmwAwTF1Zn6ZmiG9K2OsvDsAguJNL7kx4LVm6eFQPc3t6AjZ8C/28Pk8a/6GSCoxLkBra+SlmnAgDdv7G5g9MJSxMgpsUKVle1AbN1j1WXFQN4i2GWJyq6WzO6CbbYIC4C6TaCmEoIbfcsJpdttu72nynhZflRE2eeMYjlmd9wbOV0zXyU3QgkECrTZtiEeuXtuZ+k06fTuCUnxVUllv82anidiDQVu2gwpQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRUZ4-00066G-9V for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 06:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2024 11:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73472-submit@debbugs.gnu.org id=B73472.173538363123397 (code B ref 73472); Sat, 28 Dec 2024 11:01:02 +0000 Original-Received: (at 73472) by debbugs.gnu.org; 28 Dec 2024 11:00:31 +0000 Original-Received: from localhost ([127.0.0.1]:48920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRUYY-00065J-Pm for submit@debbugs.gnu.org; Sat, 28 Dec 2024 06:00:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRUYW-000654-MK for 73472@debbugs.gnu.org; Sat, 28 Dec 2024 06:00:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRUYQ-0003gd-Ez; Sat, 28 Dec 2024 06:00:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3x1dPN5RoDodccu3ErbtPAeIH5s76M6Rd6osTSYisMI=; b=hCn+6PJoYtWS8+iSrXRf bSzB+dEvX1AUqlZth/8hx5ij2h3jMaigNy51BMAbW74nS0CkNgIL/C94z+zk+MThitK3C/Om4yH7d sh7zM0o/QzmfUtlmyMR861uyNIWmvgyYNjS3TNCZWWsOf3nno9BrISzBwy6p6epR4cplS4Q4VAcD1 XGgYgs/ISwLdiijuPQEybOue5BDUToenaAbYbb/EO0+/CmDezPiMDbeX4/J2BVNHi+u3dtRsVSftE arjZJnJ5Sp3TXrDtV1LSBgLwwdfOLaj577B14f73SfFhCZWsv5M1HP+6IK02XcZOoHH0CY6tCcXQS K9UY7A/6gQGB3w==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Thu, 12 Dec 2024 10:57:48 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297868 Archived-At: > From: João Távora > Date: Thu, 12 Dec 2024 10:57:48 +0000 > Cc: Thomas Voss , 73472@debbugs.gnu.org > > On Thu, Dec 12, 2024 at 10:50 AM Eli Zaretskii wrote: > > > > > Date: Mon, 09 Dec 2024 19:01:28 +0100 > > > From: "Thomas Voss" > > > > > > Apologies for the long delay; I have been super busy recently. > > > > > > > Ping! > > > > > > > > > Thanks. João, any comments? > > > > > > > > > > My only comment is that the log message says "format-prompt", but the > > > > > code actually uses substitute-quotes. > > > > > > Uh… are we looking at the same patch? The log message in the patch I > > > last sent does say ‘substitute-quotes’ for all the places where I used > > > that function, and only says ‘format-prompt’ for the place where I used > > > that function (‘eglot-rename’). > > > > > > Just in case, I attached the patch again to this email. > > > > Thanks. > > > > João, are you okay with me installing this? > > Just had a look. The patch won't break anything, but it has some problems > around the part where substitute quotes isn't around a literal, but wraps > a bigger block. I'll try to fix it. It would also be great to have some file > local symbol-shortening mechanism to avoid that long name, but I'm > not going to worry about that. Ping! Did you have time to look into this?