From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#20084: comint-highlight-prompt overrides ANSI colors in 24.4 Date: Sun, 22 Mar 2015 17:29:15 +0100 Message-ID: <85zj75gfki.fsf@iznogoud.viz> References: <1vy4n3gxzr.fsf@fencepost.gnu.org> <85k2ynexw9.fsf@iznogoud.viz> <85d244tmzb.fsf@iznogoud.viz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1427041886 18500 80.91.229.3 (22 Mar 2015 16:31:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Mar 2015 16:31:26 +0000 (UTC) Cc: 20084@debbugs.gnu.org, Charles Tam To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 22 17:31:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZimL-0007zI-MF for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 17:31:09 +0100 Original-Received: from localhost ([::1]:51633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZimK-0006YZ-M7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 12:31:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZimH-0006YS-Hb for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 12:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZimE-0008Ok-B1 for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 12:31:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZimE-0008Og-7r for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 12:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZimE-0003cf-2C for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 12:31:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Mar 2015 16:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20084 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 20084-submit@debbugs.gnu.org id=B20084.142704184913906 (code B ref 20084); Sun, 22 Mar 2015 16:31:01 +0000 Original-Received: (at 20084) by debbugs.gnu.org; 22 Mar 2015 16:30:49 +0000 Original-Received: from localhost ([127.0.0.1]:60814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZim1-0003cE-4j for submit@debbugs.gnu.org; Sun, 22 Mar 2015 12:30:49 -0400 Original-Received: from b2bfep12.mx.upcmail.net ([62.179.121.57]:35257) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZily-0003bx-CZ for 20084@debbugs.gnu.org; Sun, 22 Mar 2015 12:30:47 -0400 Original-Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep12.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150322163039.JMPR4373.b2bfep12-int.chello.at@edge12.upcmail.net> for <20084@debbugs.gnu.org>; Sun, 22 Mar 2015 17:30:39 +0100 Original-Received: from iznogoud.viz ([91.119.116.94]) by edge12.upcmail.net with edge id 6gWe1q00N22GXxF0CgWeev; Sun, 22 Mar 2015 17:30:39 +0100 X-SourceIP: 91.119.116.94 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.85 (FreeBSD)) (envelope-from ) id 1YZilq-0000Tp-7T; Sun, 22 Mar 2015 17:30:38 +0100 User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100785 Archived-At: On Fri, Mar 20 2015, Stefan Monnier wrote: >> * lisp/font-lock.el (remove-single-text-property): Uncomment. >> Hack it a bit. > > Please add a "font-lock--" prefix to it, or move it to comint.el and add > a "comint--" prefix to it. We could also move it to something more > generic but its name should include "-face-" since its behavior is > specific to the way `face' properties are merged. I think it is a companion of font-lock-append-text-property and friends and should be allowed to stay in font-lock.el as well. All those functions do something reasonable (though perhaps not particularly useful) for arbitrary properties - and are documented to do so - the only `face' or `font-lock-face' specific quirk being that `anonymous faces' have to be treated like atoms. Also, am I wrong that foo-- is used for symbols which are private to the `foo' library whereas `private to emacs' is achieved by not documenting things in the manual? So, I would choose a name like `font-lock-remove-from-text-property' and leave it undocumented. (I'm talking about pushing it to the master branch only, since it's not a regression against 24.4, as the OP noted).