From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 07 Feb 2020 09:43:51 -0500 Message-ID: <85y2texxso.fsf@gmail.com> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="21125"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) Cc: 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 07 16:00:03 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j056w-0005Lu-Me for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 16:00:02 +0100 Original-Received: from localhost ([::1]:58691 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j056v-0006bl-JK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 10:00:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54457) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j04sR-0006Oa-Ci for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 09:45:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j04sQ-0005XI-Cq for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 09:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43060) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j04sQ-0005Wu-9P for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 09:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j04sQ-0005Zu-6V for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 09:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Feb 2020 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.158108664221337 (code B ref 39452); Fri, 07 Feb 2020 14:45:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 7 Feb 2020 14:44:02 +0000 Original-Received: from localhost ([127.0.0.1]:49033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j04rR-0005Y2-G8 for submit@debbugs.gnu.org; Fri, 07 Feb 2020 09:44:01 -0500 Original-Received: from mail-qt1-f193.google.com ([209.85.160.193]:46973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j04rP-0005Xc-PX for 39452@debbugs.gnu.org; Fri, 07 Feb 2020 09:44:00 -0500 Original-Received: by mail-qt1-f193.google.com with SMTP id e25so1955014qtr.13 for <39452@debbugs.gnu.org>; Fri, 07 Feb 2020 06:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=B+1+tc76Pr2QbTN4rLIIPoASmc518FuAcs7HYEHVMVw=; b=ccLb54mF/tAp+BnDLuzVvDfNr/+bxekfqQh4L9qkyQsxpnQ8EOrm6FJ6l2BB5bFQiJ 4Lo8VXPCnY09pFgezVgxpz0iGf1z3JWpYIPcGX3Ga3Cc9b+BM4+VXAEksY2juW6vrP5I epgovl9bfjF9hDeYfI0FaKd2AJBpwqfzD34lgdRxFV1XBtBwyIwjHivFhpqc13Nr7kxr CeGo8iiaeDz9gPHBuLHFdzKB3Q7VbHNmHKhN3euHy5rqov86RYJ46pWvrPBkUyT6Ptgw d4ZN8DdQjttwZ9nHjsBBHIWrInGy7C3JLqMNNEnXsazKUNjNY4S3X8pnGcJvUM+jYzQV AWow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=B+1+tc76Pr2QbTN4rLIIPoASmc518FuAcs7HYEHVMVw=; b=r+fh8uMKXf95kTb8LCsGqRDysRXJCnZ5kPbZnZKx4iKDv3KLEiSbjBXWcT0/M58BfA RWP3F6lyQULhJOu3yQRAUhO5rA41fXb0npMvPEhI1Bydp2dW3RScKtE6zGIuXxLgB+6P r3535jo27U+PSS+HpIRtnpPFMWkis1xpGwE0qlOI3VskswMwjFY4PMntBzXgX5cZUMTS qUPUCkEHxj5i3ZWojB0dbtbl46F7WAR6yuqvQbJpT3if60dq4fZGK9qSezRM3syWAr31 I+Tx0tDsoPmSZNll0AIzCVBaT5FgAdG+Y8bkP9F0X4HfSh4nVaVw2PrkJqg0MeBSAK0v yEYQ== X-Gm-Message-State: APjAAAUktK4kW+34XyFZB10O4XxRobMHf7CKR//POnAnovzHaUKDnqm2 LYmkYfLVJO/V8pVS2o+nZYg= X-Google-Smtp-Source: APXvYqzh6QjrDTNDiTrEoILZv6gwgKCJKL5l3jKy2AXsSfIQqTKQ9UlP/geVeWhIRtvPIgX4YXoFPw== X-Received: by 2002:ac8:6b98:: with SMTP id z24mr7710479qts.392.1581086634216; Fri, 07 Feb 2020 06:43:54 -0800 (PST) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id v78sm1386510qkb.48.2020.02.07.06.43.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Feb 2020 06:43:53 -0800 (PST) In-Reply-To: <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> (Dmitry Gutov's message of "Fri, 7 Feb 2020 11:43:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175749 Archived-At: Dmitry Gutov writes: > It's not so simple. FILE already goes through call-process. But Git > expects a pathspec, not just a file name. So if it's a glob, it is > expanded. You can pass --literal-pathspecs to tell git not to expand. Magit does this. But there is a downside due to the way git implements it, which is by setting an environment variable: it affects all subprocesses git calls, including git-hook scripts which tends to trip people up.