From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kazuhiro Ito Newsgroups: gmane.emacs.bugs Subject: bug#74312: 31.0.50; Cygw32 build break Date: Wed, 13 Nov 2024 01:14:54 +0900 Message-ID: <85y11o1la9.wl--xmue@d1.dion.ne.jp> References: <858qtpkemi.wl--xmue@d1.dion.ne.jp> <86serxkb3x.fsf@gnu.org> <0f292392-7a84-4427-a9ed-9a4dc4014a85@cornell.edu> <86wmh9il65.fsf@gnu.org> <4add61f6-3654-4b9f-913b-ec3a52981aea@cornell.edu> <86jzd8ipxj.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35499"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/31.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) Cc: Eli Zaretskii , Ken Brown To: 74312@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 12 17:16:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tAtZ0-0008zZ-FH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Nov 2024 17:16:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAtYm-0000Ep-54; Tue, 12 Nov 2024 11:16:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAtYh-0000EN-3C for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2024 11:16:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAtYg-0003wB-G6 for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2024 11:16:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=zKvYtjmdsi0WEfH67OuM7umn7XPgG/JTc9PnVa1sBT8=; b=fGkjT2i/Rf0LOYvHWIbpo1rv4eecRoK9HPkNAQAEWpM1An/3c9/zqXcXJWyzXmnG2EOonooW7sejzAmZdpwS/bwRUJTxc9DVkMgoz0Ru9R6cZQZuQ+DL8Wfckg212Or/JHVudqqCdpBjpRbpYAvPKXFkBSMhuWupvn0I6WZa5Wvi2VQk5O2WbM9Kxh2jYALnjmIaUSzNzq5H9wX3AucAeJxo8sqDoTcqjZyWLIDi0+OXv+n98b4ZO7Ub2plYc5X7GvztrDrqWdJySbWkZioz6ymZ+JYFhIZPfezTQ/1/BpFBQ/raHI9T3g7udsdqMOsNzF4w0a7aZfHwGJdS/sh9pQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAtYg-0008AQ-0x for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2024 11:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Nov 2024 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74312 X-GNU-PR-Package: emacs Original-Received: via spool by 74312-submit@debbugs.gnu.org id=B74312.173142810431006 (code B ref 74312); Tue, 12 Nov 2024 16:16:01 +0000 Original-Received: (at 74312) by debbugs.gnu.org; 12 Nov 2024 16:15:04 +0000 Original-Received: from localhost ([127.0.0.1]:39006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAtXj-00083f-Qt for submit@debbugs.gnu.org; Tue, 12 Nov 2024 11:15:04 -0500 Original-Received: from mta-snd-e06.auone-net.jp ([111.86.247.6]:51040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAtXf-00082b-97 for 74312@debbugs.gnu.org; Tue, 12 Nov 2024 11:15:03 -0500 Original-Received: from kzhr.d1.dion.ne.jp by mta-snd-e06.auone-net.jp with ESMTP id <20241112161455246.PJTC.9150.kzhr.d1.dion.ne.jp@mta-snd-e06.auone-net.jp>; Wed, 13 Nov 2024 01:14:55 +0900 In-Reply-To: <86jzd8ipxj.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d1.dion.ne.jp; s=default-1; t=1731428095; bh=zKvYtjmdsi0WEfH67OuM7umn7XPgG/JTc9PnVa1sBT8=; h=Date:From:Cc:To:Subject:In-Reply-To:References; b=AzegpcLZ8+zp9Hykvv1eWB0PKdRmkNgHNJWoFQT2IA8B4Yn7QL8RqlNaO0LyRWs/AqRgiGKS oUydneF+6H2N+UmQaW8xg3CzsjBoEGi8SSjP9qF4nFenUz8ucBUFb3txue3ADbDVvhB+BxeoAO kYWFXuMW04PX2MkMTM5al14kUIcyIrUN2a34jmZWcwBXAnxAcDdoWUL/a7eUImo8lom1ZEHqsX zRAwLBondWBuiyXKstr6PvJrdHbavCpEzFwCPmUKUO2g8MKwAi68D1zxfQfy9ZBg+86/1NkHVL tudB55++c5q0Im1fYaBzCZAo8xqYqn50U7Gf0Iygmw9EWSUg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295248 Archived-At: > > ../../src/w32menu.c: In function =A1w32_popup_dialog=A2: > > ../../src/w32menu.c:200:21: warning: implicit declaration of function=20 > > =A1pMultiByteToWideChar=A2; did you mean =A1MultiByteToWideChar=A2?=20 > > [-Wimplicit-function-declaration] > > 200 | * pMultiByteToWideChar (CP_UTF8, 0, title,=20 > > -1, NULL, 0)); > > | ^~~~~~~~~~~~~~~~~~~~ > > | MultiByteToWideChar > > ../../src/w32menu.c:200:21: warning: nested extern declaration of=20 > > =A1pMultiByteToWideChar=A2 [-Wnested-externs] > >=20 > > ../../src/w32dwrite.c:41: warning: macro "INITGUID" is not used=20 > > [-Wunused-macros] > > 41 | # define INITGUID > > | > > ../../src/w32dwrite.c: In function =A1w32_dwrite_encode_char=A2: > > ../../src/w32dwrite.c:662:51: warning: pointer targets in passing=20 > > argument 2 of =A1dwrite_font_face->lpVtbl->GetGlyphIndicesA=A2 differ i= n=20 > > signedness [-Wpointer-sign] > > 662 | &c, 1, &inde= x); > > | ^~ > > | | > > | int * > > ../../src/w32dwrite.c:662:51: note: expected =A1const UINT32 *=A2 {aka = > > =A1const unsigned int *=A2} but argument is of type =A1int *=A2 > >=20 > > /usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld:=20 > > w32menu.o: in function `w32_popup_dialog': > > /home/kbrown/src/emacs/master/build-w32/src/../../src/w32menu.c:200:(.t= ext+0xb6a):=20 > > undefined reference to `pMultiByteToWideChar' > > /usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld:=20 > > /home/kbrown/src/emacs/master/build-w32/src/../../src/w32menu.c:202:(.t= ext+0xba5):=20 > > undefined reference to `pMultiByteToWideChar' > > /usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld:=20 > > /home/kbrown/src/emacs/master/build-w32/src/../../src/w32menu.c:252:(.t= ext+0xc1e):=20 > > undefined reference to `pMultiByteToWideChar' > > /usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld:=20 > > /home/kbrown/src/emacs/master/build-w32/src/../../src/w32menu.c:256:(.t= ext+0xc6a):=20 > > undefined reference to `pMultiByteToWideChar' > > /usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld:=20 > > /home/kbrown/src/emacs/master/build-w32/src/../../src/w32menu.c:230:(.t= ext+0xdfe):=20 > > undefined reference to `pMultiByteToWideChar' > > /usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld:=20 > > w32menu.o:/home/kbrown/src/emacs/master/build-w32/src/../../src/w32menu= .c:233:=20 > > more undefined references to `pMultiByteToWideChar' follow > > Thanks, I tried to fix those. As far as I tested, modifying your change as below was needed. =20 diff --git a/src/w32menu.c b/src/w32menu.c index b5f87ebb42c..e5415b89bcb 100644 --- a/src/w32menu.c +++ b/src/w32menu.c @@ -187,8 +187,8 @@ task_dialog_callback (HWND hwnd, UINT msg, WPARAM wPara= m, w32_popup_dialog (struct frame *f, Lisp_Object header, Lisp_Object content= s) { #ifdef NTGUI_UNICODE - typedef int (WINAPI *WideCharToMultiByte_Proc)(UINT,DWORD,LPCWSTR,int,LP= STR, - int,LPCSTR,LPBOOL); + typedef int (WINAPI *MultiByteToWideChar_Proc)(UINT,DWORD,LPCSTR,int, + LPWSTR,int); static MultiByteToWideChar_Proc pMultiByteToWideChar =3D MultiByteToWide= Char; #endif /* NTGUI_UNICODE */ check_window_system (f); > And when it does build, please try the drag-n-drop feature, both with > dropping files and with dropping text on Emacs. Dropping multiple files or text works the same as MingW build except files and directories with non-ascii name. When I dragged such files in Emacs frame, mouse cursor changed into red NO ENTRY SIGN (U+1F6AB) and no response for dropping. --=20 Kazuhiro Ito