From: npostavs@gmail.com
To: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
Cc: 35708@debbugs.gnu.org, npostavs@gmail.com
Subject: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant
Date: Tue, 14 May 2019 10:34:55 -0400 [thread overview]
Message-ID: <85tvdxw1dc.fsf@gmail.com> (raw)
In-Reply-To: <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> ("Andreas \=\?iso-8859-1\?Q\?R\=F6hler\=22's\?\= message of "Tue, 14 May 2019 12:49:07 +0200")
Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>> Hmm, current thing-at-point-looking-at might be slow with large
>> buffers. The slightly modified test should reveal it:
>>
>> (ert-deftest thing-at-point-looking-at-2 ()
>> (with-temp-buffer
>> (insert "1abcd 222abcd")
>> (dotimes (_ 99999) (insert " asdf "))
>> (goto-char (point-min))
>> (search-forward "2ab")
>> (should (thing-at-point-looking-at "2abcd"))
Yes, in this case, since the loop over looking-at only needs to iterate
twice, so it will be faster. But what about when there is no match?
E.g.,
(with-temp-buffer
(dotimes (_ 99999) (insert " asdf "))
(goto-char (point-max))
(list :ar-regexp-atpt (benchmark-run (ar-regexp-atpt "foo"))
:thing-at-point-looking-at (benchmark-run (thing-at-point-looking-at "foo"))))
> Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"):
>
> (defun ar-regexp-atpt (regexp)
> "Return t if REGEXP matches at or before point, nil otherwise.
>
> Changes match-data"
> (save-excursion
> (if (looking-at regexp)
> (while
> (and (not (bobp))
> (or (progn (backward-char) (looking-at regexp))
> (forward-char 1))))
> (while (not (or (bobp) (backward-char) (looking-at regexp))))
> (ar-regexp-atpt regexp))
What's this recursive call for? It triggers (error "Lisp nesting
exceeds ‘max-lisp-eval-depth’") in the benchmark above.
> (looking-at regexp)))
next prev parent reply other threads:[~2019-05-14 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 7:19 bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant Andreas Röhler
2019-05-13 12:41 ` Noam Postavsky
2019-05-13 18:31 ` Andreas Röhler
2019-05-13 19:25 ` npostavs
2019-05-14 10:02 ` Andreas Röhler
2019-05-14 10:49 ` Andreas Röhler
2019-05-14 14:34 ` npostavs [this message]
2019-05-15 6:59 ` Andreas Röhler
2019-05-15 10:11 ` Andreas Röhler
2019-05-20 17:17 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85tvdxw1dc.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=35708@debbugs.gnu.org \
--cc=andreas.roehler@easy-emacs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).