From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#19401: 25.0.50; metar.el (metar-convert-temperature) wrong type argument stringp nil Date: Wed, 14 Jan 2015 02:47:28 +0100 Message-ID: <85sifem7yq.fsf@iznogoud.viz> References: <87oar2x9is.fsf@udel.edu> <87egrx1162.fsf@web.de> <87egrxqaeb.fsf@udel.edu> <87a92k28rk.fsf@web.de> <85mw5m91um.fsf@iznogoud.viz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1421201237 8214 80.91.229.3 (14 Jan 2015 02:07:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Jan 2015 02:07:17 +0000 (UTC) Cc: Mario Lang , Mark Oteiza , 19401@debbugs.gnu.org To: Ulf Jasper Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 14 03:07:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YBDMU-00085R-6j for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jan 2015 03:07:10 +0100 Original-Received: from localhost ([::1]:42160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBDMT-0000VQ-5y for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Jan 2015 21:07:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBDMQ-0000VI-69 for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 21:07:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBDMM-0008SX-S3 for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 21:07:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBDMM-0008SS-NX for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 21:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YBDMM-0001sY-F9 for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 21:07:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87oar2x9is.fsf@udel.edu> Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jan 2015 02:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19401-submit@debbugs.gnu.org id=B19401.14212012127203 (code B ref 19401); Wed, 14 Jan 2015 02:07:02 +0000 Original-Received: (at 19401) by debbugs.gnu.org; 14 Jan 2015 02:06:52 +0000 Original-Received: from localhost ([127.0.0.1]:55995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBDMB-0001s7-CL for submit@debbugs.gnu.org; Tue, 13 Jan 2015 21:06:51 -0500 Original-Received: from b2bfep12.mx.upcmail.net ([62.179.121.57]:36900) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBDM7-0001ro-HJ for 19401@debbugs.gnu.org; Tue, 13 Jan 2015 21:06:49 -0500 Original-Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep12.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150114020640.KHPN14748.b2bfep12-int.chello.at@edge12.upcmail.net> for <19401@debbugs.gnu.org>; Wed, 14 Jan 2015 03:06:40 +0100 Original-Received: from iznogoud.viz ([85.127.90.213]) by edge12.upcmail.net with edge id fe6e1p0014cBfQ50Ce6eCs; Wed, 14 Jan 2015 03:06:40 +0100 X-SourceIP: 85.127.90.213 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YBDLx-0008eo-UX; Wed, 14 Jan 2015 03:06:37 +0100 User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98339 Archived-At: --=-=-= Content-Type: text/plain On Tue, Jan 13 2015, Wolfgang Jenkner wrote: > Please note that this patch assumes that the patch from (Bug#19582) has > been applied. Actually, the following patch (on top of the last one) might be enough for metar to avoid the need for that fix from bug#19582, and so to remain compatible with older (than the future trunk ;-) emacs versions. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-metar-Add-a-work-around-for-bug-19582.patch Content-Description: calc bug work-around for metar >From ad084a9b35e79f3524e4ef01137cf256c0509266 Mon Sep 17 00:00:00 2001 From: Wolfgang Jenkner Date: Wed, 14 Jan 2015 02:31:01 +0100 Subject: [PATCH] [metar] Add a work-around for bug#19582. * packages/metar/metar.el (metar-convert-unit): Rewrite expr if it starts with the `neg' operator. Technically, this is wrong because various functions in calc-units expect already simplified expressions. In practice, it should work around the above bug. --- packages/metar/metar.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/metar/metar.el b/packages/metar/metar.el index 9575313..a05a353 100644 --- a/packages/metar/metar.el +++ b/packages/metar/metar.el @@ -249,6 +249,9 @@ It must have the signature of `math-convert-units', which is the default." (unless (symbolp new-unit) (setq new-unit (intern new-unit))) (let ((expr (math-simplify (math-read-expr value)))) + ;; Sneakily work around bug#19582. + (when (eq (car-safe expr) 'neg) + (setq expr `(* -1 ,(cadr expr)))) (cl-assert (or (math-zerop expr) (not (memq (math-single-units-in-expr-p expr) '(nil wrong)))) nil -- 2.2.1 --=-=-=--