From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#40148: 26.3; Custom package header checked out from GIT in Windows will not parse Date: Fri, 20 Mar 2020 15:47:27 -0400 Message-ID: <85sgi2olkg.fsf@gmail.com> References: <83o8srdt6t.fsf@gnu.org> <85v9mznlx4.fsf@gmail.com> <83lfnvdqw5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="11263"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) Cc: 40148@debbugs.gnu.org, mangelozzi@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 20 20:48:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jFNcr-0002nP-Rv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Mar 2020 20:48:13 +0100 Original-Received: from localhost ([::1]:58490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFNcq-000829-TA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Mar 2020 15:48:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60172) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFNch-000820-FH for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2020 15:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFNcg-0000g9-D7 for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2020 15:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39720) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFNcg-0000g3-9k for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2020 15:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFNcg-0008PN-6A for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2020 15:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2020 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40148 X-GNU-PR-Package: emacs Original-Received: via spool by 40148-submit@debbugs.gnu.org id=B40148.158473365632285 (code B ref 40148); Fri, 20 Mar 2020 19:48:02 +0000 Original-Received: (at 40148) by debbugs.gnu.org; 20 Mar 2020 19:47:36 +0000 Original-Received: from localhost ([127.0.0.1]:45693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFNcF-0008Of-RA for submit@debbugs.gnu.org; Fri, 20 Mar 2020 15:47:36 -0400 Original-Received: from mail-qt1-f196.google.com ([209.85.160.196]:38698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFNcD-0008OR-W4 for 40148@debbugs.gnu.org; Fri, 20 Mar 2020 15:47:34 -0400 Original-Received: by mail-qt1-f196.google.com with SMTP id z12so6052887qtq.5 for <40148@debbugs.gnu.org>; Fri, 20 Mar 2020 12:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yiGx2TJKKzrHOO54Dwc2y/gmQdCJJJpDG/RbLVNzSWs=; b=CRHrKIBeA4OdAFR9Tw+kd8TxoiBi+ichidpvjmEnEzsuaz1jy6ETxWGdDCNcT41vA/ NAViLyx1RJSM2zXZJaU4SKRcnhmGvqabs9ScbZ+Y+V+CmeBbyGtfoicPYc9yIk4/XibG YDHsNIxgBfwLJIJelsaWevmdWlbHWyyWk6jSjW1IxSFwCAEedSQsAA6owjKP2b0WXyLj alYxugo5F5so73+ToIM4M/zDgW8ahrU+DOP7Foqsp87kXKm/+h3Vjf29wdWbYiGkx71R byQ4oeI2eLyqWppIGMo3gM8lJKPajNREJGLA2KJenvQrzjNJAeQZ23ymC2UkTgldD2qi wdkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yiGx2TJKKzrHOO54Dwc2y/gmQdCJJJpDG/RbLVNzSWs=; b=NtXkBNiaD15HT40P8buYlUeMJPueFOXcHu5VX7YKcOjU4nkwBnOd0+tRobzYQsamPO YpGW5oEYE/GvoTfnMjVtatTVUEvNx72BmEUw8KJNVcb93RxAcMRBMbGLNYmbrd2FheZG QwSow2Ht9ivZvGJSQ5Lbs4Fyniq/Hz4rww/DcKjvQvr1A75FUPe21y4Fl6iZryOMKxx/ P+79pMuQzp0pRGo5NHV2x5dQjvqIzUMIADd00kICnGS1zcSRlEfo3pZhm2IlcJuAb0BA irU5VXQ/gvBIxJdkKNjQ7CItsoBIrJlGzI/1JTh3sk0g1qGNV89BeQuw/ulp4Z7wDn+0 w+5g== X-Gm-Message-State: ANhLgQ0tGJqjb73B9WygNjAerlhzZeITpaDjG9PwbL7zJNfnjjVf6WbG GPQIVe71jsJ/IsVgY4MatVQ= X-Google-Smtp-Source: ADFU+vvc51YZYMWWnssdEBO0FbJuoidiGtgYft4yKVdu7t3vOd8XZA0TElg+3axO6nqSD2Kp2sFzFA== X-Received: by 2002:ac8:7444:: with SMTP id h4mr2395186qtr.247.1584733648375; Fri, 20 Mar 2020 12:47:28 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id 128sm5006757qki.103.2020.03.20.12.47.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Mar 2020 12:47:27 -0700 (PDT) In-Reply-To: <83lfnvdqw5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Mar 2020 16:47:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177576 Archived-At: Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: Michael Angelozzi , 40148@debbugs.gnu.org >> Date: Fri, 20 Mar 2020 10:25:11 -0400 >> >> Eli Zaretskii writes: >> >> > It may be the case that package.el should be more tolerant in this >> > case, but that's just the tip of an iceberg, because there are files >> > out there where LF to CR-LF conversions are a no-no (just one example: >> > Unix shell scripts). Just say no to this "feature", and Bob's your >> > uncle. >> >> The problem happens without git conversion as well (because Emacs >> defaults to "dos" encoding on windows-nt systems): > > You are saying that creating a package (or a new file in a package) > should leave the EOL format of the Lisp files at "dos", and distribute > the package's files like that via the elpa's? My message above says only what does happen, not what should happen (for the latter, see below). But I'm not sure exactly what you mean by "create a package". I don't think Emacs has a particular action/command which corresponds to that. Distribution via repos is mostly outside the responsibility of Emacs' code (there are some upload functions in package-x.el, but none of the existing repos make use of them, as far as I know). About what should happen: I think detecting and giving a specific error about CRLF from package-buffer-info could be a satisfactory solution to this bug. Or perhaps package-install-file could be more lenient. Actually, if I'm reading the code right, it's already more lenient in case of installing from a .tar file containing CRLF elisp files.