From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#12792: 24.2.50; shell-mode renders all its output in a yellow face Date: Sat, 03 Nov 2012 16:37:59 +0100 Message-ID: <85r4oazoh4.fsf@iznogoud.viz> References: <871ugbxdyr.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1351957093 12777 80.91.229.3 (3 Nov 2012 15:38:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Nov 2012 15:38:13 +0000 (UTC) Cc: 12792@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 03 16:38:22 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TUfnh-0005ck-Ax for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Nov 2012 16:38:21 +0100 Original-Received: from localhost ([::1]:47946 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUfnY-00074m-Gf for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Nov 2012 11:38:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUfnV-000730-Cs for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 11:38:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUfnU-0007mQ-7o for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 11:38:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUfnU-0007mJ-44 for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 11:38:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TUfqI-0001Cy-BC for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 11:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wolfgang Jenkner Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Nov 2012 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12792 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12792-submit@debbugs.gnu.org id=B12792.13519572594636 (code B ref 12792); Sat, 03 Nov 2012 15:41:02 +0000 Original-Received: (at 12792) by debbugs.gnu.org; 3 Nov 2012 15:40:59 +0000 Original-Received: from localhost ([127.0.0.1]:47311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUfqF-0001Ci-7w for submit@debbugs.gnu.org; Sat, 03 Nov 2012 11:40:59 -0400 Original-Received: from mx11.lb01.inode.at ([62.99.145.13]:20139 helo=mx.inode.at) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUfqD-0001Cb-I9 for 12792@debbugs.gnu.org; Sat, 03 Nov 2012 11:40:58 -0400 Original-Received: from [91.119.128.247] (port=5873 helo=iznogoud.viz) by smartmx-11.inode.at with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1TUfnN-0000Kt-JF; Sat, 03 Nov 2012 16:38:01 +0100 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.80 (FreeBSD)) (envelope-from ) id 1TUfnM-0000YM-21; Sat, 03 Nov 2012 16:38:00 +0100 In-Reply-To: <871ugbxdyr.fsf@secretsauce.net> (Dima Kogan's message of "Sat, 03 Nov 2012 01:55:40 -0700") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66384 Archived-At: On Sat, Nov 03 2012, Dima Kogan wrote: > I'm using a very recent emacs snapshot. shell-mode no longer renders the > ANSI-code colors correctly. Even with a relatively stock bash, All > output is rendered in yellow except for the prompt line. The prompt > isn't yellow, but it's wrong also: > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11883 > > This is a regression, since both the output in general and the prompt in > particular have been rendered correctly previously. I did a bisection, > and tracked the issues down to two commits. The prompt coloring broke in > > http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ansi-color.el?id=cd49cea06bb1c492d4d024889f3f320bf4c9b507 > > After that commit the general output still looks correct, but the prompt > isn't colored. Then later on, the rest of the output rendering broke in > > http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ansi-color.el?id=1bc85494c3236fa27cd8456635a4109aeed48344 In bug#11883 you give this example echo -e "\033[31mtest\033[39m" but ansi-color has never supported SGR parameter 39. However, before my change (the latter commit above), any unknown parameter would have the same effect as parameter 0 (turn off all rendition aspects), while it is simply ignored now (well, except for an "Invalid face reference: nil" message), see `ansi-color-apply-sequence'. Perhaps, this explains the problem. Wolfgang