From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: npostavs@gmail.com Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v2] Tweak dired warning about "wildcard" characters Date: Thu, 13 Jun 2019 12:53:08 -0400 Message-ID: <85r27x2zrf.fsf@gmail.com> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87muinyoup.fsf@gmail.com> <87tvcum2h6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="154040"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) Cc: 35564@debbugs.gnu.org, Noam Postavsky , Stefan Monnier To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 13 21:11:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbV7r-000dwA-Ao for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Jun 2019 21:11:07 +0200 Original-Received: from localhost ([::1]:44416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbV7p-0005Ro-Vp for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Jun 2019 15:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57568) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbSzE-0000Ns-5x for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2019 12:54:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbSzD-00036O-4R for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2019 12:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbSzC-000367-Nh for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2019 12:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hbSzC-00010Z-HK for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2019 12:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jun 2019 16:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.15604447973815 (code B ref 35564); Thu, 13 Jun 2019 16:54:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 13 Jun 2019 16:53:17 +0000 Original-Received: from localhost ([127.0.0.1]:36033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbSyT-0000zT-4Y for submit@debbugs.gnu.org; Thu, 13 Jun 2019 12:53:17 -0400 Original-Received: from mail-io1-f54.google.com ([209.85.166.54]:41320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbSyQ-0000zD-V6 for 35564@debbugs.gnu.org; Thu, 13 Jun 2019 12:53:15 -0400 Original-Received: by mail-io1-f54.google.com with SMTP id w25so18432783ioc.8 for <35564@debbugs.gnu.org>; Thu, 13 Jun 2019 09:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8rmcSgjvgHMDVwbuFz19706fMkOVpeOcYPSlCPJ3W/4=; b=g9sDfy2qubqsg0RtHRvZ3vzH90tLjTmRbKXtAyg/eRP+UPCpj6iDVANk8Ol/+IFP4L cdF5Je9Ct3ODU8EHqS/Ch1Iyxwn7ik8gKQSiZNhx5cTKWwv+sDIinWffbmq/pKwdcdHH pygbc/aMDWtN/s8ZBgu6EcgTgj7GpbU1y9VqHAB1YTsZ5J3FZd8fQ2QTbnorXv39yAA5 ABL+tUNDlAEV9LuD6GLL1yfWUbzneR/wypwDRzPeJZiF/im1lxoMWxv3maVCpvyklEok U5fX8+JNER9ljqsO2BCSlbYF/n/Ohezv6gsTkEAJqnshr88X7kuRb8Z1q2FpACKD93Ee D9Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8rmcSgjvgHMDVwbuFz19706fMkOVpeOcYPSlCPJ3W/4=; b=MTAQkrmSog32cE4NNhHcUqFYA0lg0iYTN0i6nObb9Jh7Va/lpg9M1fJAmpdZo+QefQ L8WcG+jNBbxDPYIgdnFfY77EN+HkQr2N5sbiawW7CgymWNezDQwVbRwQ66tnjRKLLjfC +VYSTq3tfEbY3yK/qYnFXgtHqz0GBkAsCtz8VXpqyFZmSSx4XKIR8n05mVRHO2EiRHaq TSLqIxs8apKS3YCo5uSYloKLzK1SHiJdz/LxK0cdqYkk8CtnTsxC1Jfor2mxviQEWFrc cEedKMMZ81dcLlSsXQ3W+gm7prdE5e6zEE8lDgKEKDLXSWucV4ql31bhBOrI2cje5LOw 4x3g== X-Gm-Message-State: APjAAAU9WQuzmJBKBfwxSJkYLUUgsqnuujTtgXgIRHgAVZe92093FTNC qllfcVQfma21SVTT3+YUARc= X-Google-Smtp-Source: APXvYqwaH5vHYj8rHFTRf27HdotDQoF1+jpKz4fzgPGQF7Z2dGGkZgSXYjb9SQ2FUGezAbYWN+QS1Q== X-Received: by 2002:a5d:9282:: with SMTP id s2mr10967549iom.36.1560444789263; Thu, 13 Jun 2019 09:53:09 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id j13sm403966ioa.76.2019.06.13.09.53.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Jun 2019 09:53:08 -0700 (PDT) In-Reply-To: <87tvcum2h6.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Thu, 13 Jun 2019 08:19:33 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160513 Archived-At: > > I think we do care; if I look at what the existing code says, > > (dired--star-or-qmark-p "?`foo`" "?") > ;; => nil > (let ((start (max 0 (1- pos))) > (char (string (aref command pos)))) > (rx-to-string '(seq (or bos blank) > (group char) `char' in this context translates to the "." regexp (i.e., any character). Yeah it's a bit weird. I have a patch in mind to remove the need for eval or rx-to-string. I'll send in a few days (to a new bug, it's getting off-topic here). Meanwhile, I suggest: (let ((start (max 0 (1- pos))) (char (aref command pos))) (and (string-match (rx-to-string `(or (seq (or bos blank) (group-n 1 ,char) (or eos blank)) (seq ?` (group-n 1 ,char) ?`))) command start) (= pos (match-beginning 1))))