From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook Date: Tue, 11 Feb 2020 16:57:04 -0500 Message-ID: <85pnekyehb.fsf@gmail.com> References: <87ziakwifi.fsf@holos> <87val88l0d.fsf@users.sourceforge.net> <20170828031104.GA15524@holos.localdomain> <87shgb89q1.fsf@users.sourceforge.net> <20170830015017.GA28668@holos.localdomain> <87wohasikq.fsf@gmail.com> <20190626140303.quhh4psgvd3aneyr@logos.localdomain> <20200126234731.GA12794@holos.localdomain> <838slnlo16.fsf@gnu.org> <83a75te6pr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="120848"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) Cc: mvoteiza@udel.edu, larsi@gnus.org, 28257@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 11 22:58:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j1dXn-000VFA-NN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Feb 2020 22:58:11 +0100 Original-Received: from localhost ([::1]:57678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1dXm-00049b-QO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Feb 2020 16:58:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52270) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1dXf-00049A-Oq for bug-gnu-emacs@gnu.org; Tue, 11 Feb 2020 16:58:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1dXe-0000jJ-JH for bug-gnu-emacs@gnu.org; Tue, 11 Feb 2020 16:58:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1dXe-0000j8-GJ for bug-gnu-emacs@gnu.org; Tue, 11 Feb 2020 16:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1dXe-0001T1-AS for bug-gnu-emacs@gnu.org; Tue, 11 Feb 2020 16:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Feb 2020 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28257-submit@debbugs.gnu.org id=B28257.15814582335569 (code B ref 28257); Tue, 11 Feb 2020 21:58:02 +0000 Original-Received: (at 28257) by debbugs.gnu.org; 11 Feb 2020 21:57:13 +0000 Original-Received: from localhost ([127.0.0.1]:57669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1dWq-0001Rl-Sa for submit@debbugs.gnu.org; Tue, 11 Feb 2020 16:57:13 -0500 Original-Received: from mail-qt1-f180.google.com ([209.85.160.180]:43780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1dWp-0001RW-Gx for 28257@debbugs.gnu.org; Tue, 11 Feb 2020 16:57:12 -0500 Original-Received: by mail-qt1-f180.google.com with SMTP id d18so32574qtj.10 for <28257@debbugs.gnu.org>; Tue, 11 Feb 2020 13:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NlQTXq5LuZgDzFZOb3RLUUWrcPrZNh8mm104e681Se4=; b=hQW3+mmEVgfPYyAwtyHivMDtQqMpQMRAeQjRvHejM2pWtY2bbu3sbTznHlRgQ8fcD1 VfM/b6I1t4OLG9stA7nNdVud9iSJLYv++g6Fums3s6qzTizAdhEXue9UXh7DBQwRtkTA sG5+EP5iRmamCsrtxiPQKTDLSEFBgFz0JV8ieL9i8VzirStCTGpTAg0xUNQQv17HtGNj XN/79DJusI78YWIBZIUCneczDNajWSDYtSg4vHxxghILvbunGkN23T+gedEnmkKygZVi cJgEBxbALWkBFYfNWCPmtsGGgFzdidYH/VuRut3dEhbM6Z00s2agcVzE9uYWmVMVgycB J68Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NlQTXq5LuZgDzFZOb3RLUUWrcPrZNh8mm104e681Se4=; b=hHtKb5cDW+4jp8a4Bv+LQJZ+N+lfrHvv/8jBUFRiQWpXQ/7vWi6zjKUzr+EmrJGWoN MNo40H1xKy304Vj/8pJYNapJM8s+wHG3YyUS23Tf04NJgxm3S0Z3VFV4+zabbJaVil5T WYeCKRQPMtI/NPi7wx6xZ1zbxCWMOY75g3KYJ5UadrdWaLGuW5ph4A+SFSK77fLzbhFL wTHQdnBFiIgJjtrrfQe/ZgQRwL5b5L8/o6JgOWh+8NJorsP+I3f/cYWPKjOKKD58Eylm 12fa9SEFnUWFqsHjv2SfufFGwaWhO2CJEBxFeqUIBQnY7+4yJaw/cQApWSDx/1tWhZRS bf8w== X-Gm-Message-State: APjAAAWhoBubPZA2Qd6CSCPgskKTGsTiI0ZIk1w5YZm+ucOCdFeu9SZJ cJnVsmqPl5Enmo7lKh5OkduFJ0t/Zc0= X-Google-Smtp-Source: APXvYqwF3NcQ5AQL0ah3Dgg3sVgwtBOOMeeFOX7DxszSqeU5d27ccPBOSO/OZuU3abPffTRQyLu2/Q== X-Received: by 2002:ac8:a83:: with SMTP id d3mr4502123qti.228.1581458225547; Tue, 11 Feb 2020 13:57:05 -0800 (PST) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id p126sm2765598qke.108.2020.02.11.13.57.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2020 13:57:04 -0800 (PST) In-Reply-To: <83a75te6pr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Feb 2020 12:03:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175956 Archived-At: Eli Zaretskii writes: > Ping! > > Can we please review Mark's patch some time soon? TIA. + (if (> emacs-major-version 25) + (add-hook 'eldoc-documentation-functions + #'cfengine3-documentation-function nil t) I think the 25 should be 26? Or 27 if this is going to master (in which case the python.el hunk needs to be adjusted too). Otherwise, the patch itself is fine in terms of coding details, as far as I can tell. I feel somewhat underqualified to decide whether or not the change in the semantics of eldoc-documentation-function is a good idea.