From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#20783: 25.0.50; [PATCH] byte-to-position has internal off-by-one bug Date: Wed, 17 Jun 2015 14:19:10 +0200 Message-ID: <85oakemsbc.fsf@iznogoud.viz> References: <85fv5za8vv.fsf@iznogoud.viz> <83vbevsctb.fsf@gnu.org> <85oakmxn4i.fsf@iznogoud.viz> <83bngms03b.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1434544239 13976 80.91.229.3 (17 Jun 2015 12:30:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Jun 2015 12:30:39 +0000 (UTC) Cc: 20783-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 17 14:30:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z5CTx-00048m-2l for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jun 2015 14:30:17 +0200 Original-Received: from localhost ([::1]:46449 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5CTw-0005cp-Fu for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jun 2015 08:30:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5CTt-0005aK-0Y for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2015 08:30:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5CTn-00080Q-TH for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2015 08:30:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5CTn-00080F-Qx for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2015 08:30:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z5CTn-0005ws-34 for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2015 08:30:07 -0400 In-Reply-To: <85fv5za8vv.fsf@iznogoud.viz> Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jun 2015 12:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 20783 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 20783@debbugs.gnu.org, wjenkner@inode.at, wjenkner@inode.at Original-Received: via spool by 20783-done@debbugs.gnu.org id=D20783.143454417822802 (code D ref 20783); Wed, 17 Jun 2015 12:30:04 +0000 Original-Received: (at 20783-done) by debbugs.gnu.org; 17 Jun 2015 12:29:38 +0000 Original-Received: from localhost ([127.0.0.1]:56993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5CTK-0005vh-8i for submit@debbugs.gnu.org; Wed, 17 Jun 2015 08:29:38 -0400 Original-Received: from b2bfep13.mx.upcmail.net ([62.179.121.58]:55861) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5CTH-0005vS-3l for 20783-done@debbugs.gnu.org; Wed, 17 Jun 2015 08:29:36 -0400 Original-Received: from edge11.upcmail.net ([192.168.13.81]) by b2bfep13.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150617122928.XRYJ20529.b2bfep13-int.chello.at@edge11.upcmail.net> for <20783-done@debbugs.gnu.org>; Wed, 17 Jun 2015 14:29:28 +0200 Original-Received: from iznogoud.viz ([85.127.11.204]) by edge11.upcmail.net with edge id hQVT1q0284Q8eCd0BQVUVo; Wed, 17 Jun 2015 14:29:28 +0200 X-SourceIP: 85.127.11.204 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Z5CT9-0003NB-GB; Wed, 17 Jun 2015 14:29:27 +0200 User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104021 Archived-At: Version: 25.1 On Thu, Jun 11 2015, Eli Zaretskii wrote: > Works for me, thanks. But please add a comment there about > BYTE_TO_CHAR expecting byte positions that are on a character > boundary, so that the reason for the loop is clear. Done and pushed. However, I didn't follow my own suggestion of adding a remark to the comment above BYTE_TO_CHAR, after all, as it is true for most macros or functions with a byte position argument, so adding such a comment to just one of them could be confusing, I think. Thank you for steering this change in the right direction.