From: Ashwin Kafle <ashwin@ashwink.com.np>
To: Juri Linkov <juri@linkov.net>
Cc: 52507@debbugs.gnu.org, Ashwin Kafle <ashwin@ashwink.com.np>
Subject: bug#52507: [PATCH] Option for vc-delete-file to keep file on disk
Date: Wed, 15 Dec 2021 17:41:44 +0000 [thread overview]
Message-ID: <85o85hsr3b.fsf@ashwink.com.np> (raw)
In-Reply-To: <86a6h13j4i.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 15 Dec 2021 18:53:01 +0200")
Juri Linkov <juri@linkov.net> writes:
>> - (interactive (list (read-file-name "VC delete file: " nil
>> - (when (vc-backend buffer-file-name)
>> - buffer-file-name)
>> - t)))
>> + (interactive "f\nP")
>
> I wonder why no prompt? You can add `current-prefix-arg' to the
> interactive list to keep the existing prompt.
Thanks, I didn't knew about that.
>
>> + (let ((backup-inhibited nil)
>> + ;; if you don't set this, then for some reason, the file is never
>> brought back
>> + (backup-by-copying t))
>
> I remember having the same problem while improving `vc-rename-file'.
> To solve the problem, it required adding `vc-file-clearprops'.
> Maybe it could here as well?
There was a call to vc-file-clearprops later. I moved that earlier
before backup and that didn't seem to work.
>
>> - (vc-resynch-buffer file nil t)))
>> + (vc-resynch-buffer file keep-file t)))
>
> It seems vc-resynch-window already uses `vc-file-clearprops'
> when `keep-file' is specified, but also on some more conditions.
I'm sorry, but I didn't really understand the above. I don't really know
elisp to be honest.
next prev parent reply other threads:[~2021-12-15 17:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 9:53 bug#52507: [PATCH] Option for vc-delete-file to keep file on disk Ashwin Kafle
2021-12-15 16:53 ` Juri Linkov
2021-12-15 17:41 ` Ashwin Kafle [this message]
2021-12-15 18:06 ` Juri Linkov
2021-12-15 18:26 ` Ashwin Kafle
2021-12-15 18:34 ` Ashwin Kafle
2021-12-16 17:01 ` Juri Linkov
2021-12-19 23:46 ` Dmitry Gutov
2021-12-23 17:20 ` Juri Linkov
2021-12-24 0:48 ` Dmitry Gutov
2021-12-26 17:43 ` Juri Linkov
2021-12-26 19:12 ` Dmitry Gutov
2021-12-26 14:31 ` Ashwin Kafle
2021-12-26 14:23 ` Ashwin Kafle
2021-12-26 15:38 ` Dmitry Gutov
2021-12-26 15:51 ` Ashwin Kafle
2021-12-26 15:57 ` Dmitry Gutov
2021-12-26 16:12 ` Ashwin Kafle
2021-12-26 16:28 ` Dmitry Gutov
2021-12-26 17:03 ` Ashwin Kafle
2021-12-27 0:03 ` Dmitry Gutov
2021-12-27 4:08 ` Ashwin Kafle
2021-12-28 0:53 ` Dmitry Gutov
2022-09-08 14:17 ` bug#52508: " Lars Ingebrigtsen
2021-12-26 17:41 ` bug#52507: " Juri Linkov
2021-12-27 17:58 ` Juri Linkov
2021-12-15 22:59 ` Dmitry Gutov
2021-12-16 7:12 ` Ashwin Kafle
2021-12-16 10:03 ` Dmitry Gutov
2021-12-16 11:26 ` Ashwin Kafle
2021-12-16 11:27 ` Dmitry Gutov
2021-12-16 14:07 ` bug#52507: [PATCH v3] " Ashwin Kafle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85o85hsr3b.fsf@ashwink.com.np \
--to=ashwin@ashwink.com.np \
--cc=52507@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).