From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#12792: 24.2.50; shell-mode renders all its output in a yellow face Date: Tue, 06 Nov 2012 02:24:29 +0100 Message-ID: <85mwyvplpu.fsf@iznogoud.viz> References: <871ugbxdyr.fsf@secretsauce.net> <85r4oazoh4.fsf@iznogoud.viz> <83y5ii4pfw.fsf@gnu.org> <85d2zuzhxe.fsf@iznogoud.viz> <85hap6yre0.fsf@iznogoud.viz> <20121104004557.00fb50a5@shorty.local> <85txt5eav5.fsf@iznogoud.viz> <20121104122456.3f2c6448@shorty.local> <85sj8prl8d.fsf@iznogoud.viz> <20121104192343.1f243455@shorty.local> <854nl4krvr.fsf@iznogoud.viz> <20121105155711.267e869b@fatty> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1352165098 2720 80.91.229.3 (6 Nov 2012 01:24:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2012 01:24:58 +0000 (UTC) Cc: 12792@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 06 02:25:07 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TVXuc-0001AN-Og for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2012 02:25:06 +0100 Original-Received: from localhost ([::1]:49170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVXuT-0005xk-T3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2012 20:24:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVXuR-0005xd-CX for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2012 20:24:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TVXuQ-0002IW-Go for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2012 20:24:55 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVXuQ-0002IS-DJ for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2012 20:24:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TVXxS-0003AG-CH for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2012 20:28:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <871ugbxdyr.fsf@secretsauce.net> Resent-From: Wolfgang Jenkner Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2012 01:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12792 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12792-submit@debbugs.gnu.org id=B12792.135216526212139 (code B ref 12792); Tue, 06 Nov 2012 01:28:02 +0000 Original-Received: (at 12792) by debbugs.gnu.org; 6 Nov 2012 01:27:42 +0000 Original-Received: from localhost ([127.0.0.1]:51337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVXx7-00039j-NP for submit@debbugs.gnu.org; Mon, 05 Nov 2012 20:27:42 -0500 Original-Received: from mx12.lb01.inode.at ([62.99.145.14]:36002 helo=mx.inode.at) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVXx6-00039c-6V for 12792@debbugs.gnu.org; Mon, 05 Nov 2012 20:27:41 -0500 Original-Received: from [91.119.128.247] (port=8139 helo=iznogoud.viz) by smartmx-12.inode.at with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1TVXu3-0007rM-CP; Tue, 06 Nov 2012 02:24:31 +0100 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.80 (FreeBSD)) (envelope-from ) id 1TVXu1-0000or-Vq; Tue, 06 Nov 2012 02:24:29 +0100 User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66512 Archived-At: On Tue, Nov 06 2012, Dima Kogan wrote: > Previously, I would do M-x shell, and then evaluate the new defun; this produced > the results I described earlier. Too late, the function must be redefined before the first prompt is sent. I thought it would be simpler to give you the rewritten defun separately instead of having you patching ansi-color.el ;-) > You just asked for a different order: load ansi-color, comint, THEN eval defun, > THEN M-x shell. That produces different colored results: everything looks > correct except the prompt is all blue all the time. Nothing has nil face. Is > this the expected behavior with that defun Yes. As you found out in your original report the prompt coloring has been broken for longer. If you customize the comint-highlight-prompt face so that it doesn't inherit from minibuffer-prompt (which does the blue colouring), you'll see that the current prompt is actually coloured correctly but for the previous prompts, comint-highlight-prompt just replaces the ansi-color faces. That's weird. Somebody should at some point do something about it ;-) In any case, you submitted a separate report about the prompt issue, viz. bug#11883. So, I'd say that the issue at hand is solved. I'll just try to rewrite the new ansi-color-apply-sequence in a less ugly way. Wolfgang