From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.bugs Subject: bug#179: 23.0.60; Menu separators are not displayed Date: Wed, 06 Aug 2008 00:10:07 +0200 Message-ID: <85ljzb8668.fsf@lola.goethe.zz> References: <87vdyf86vq.fsf@stupidchicken.com> Reply-To: David Kastrup , 179@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217975269 32460 80.91.229.12 (5 Aug 2008 22:27:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Aug 2008 22:27:49 +0000 (UTC) Cc: 179@emacsbugs.donarmstrong.com To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 06 00:28:39 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KQV1C-0000ca-E4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Aug 2008 00:28:38 +0200 Original-Received: from localhost ([127.0.0.1]:44991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQV0G-0001a3-UU for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Aug 2008 18:27:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQV05-0001Ru-M1 for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2008 18:27:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQV03-0001NM-7n for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2008 18:27:28 -0400 Original-Received: from [199.232.76.173] (port=42789 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQV03-0001NA-1Z for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2008 18:27:27 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43366) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KQV00-0005AT-Lr for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2008 18:27:25 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m75MRMdt020282; Tue, 5 Aug 2008 15:27:23 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m75MK49A017322; Tue, 5 Aug 2008 15:20:04 -0700 X-Loop: don@donarmstrong.com Resent-From: David Kastrup Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 05 Aug 2008 22:20:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: moreinfo patch Original-Received: via spool by 179-submit@emacsbugs.donarmstrong.com id=B179.121797421514463 (code B ref 179); Tue, 05 Aug 2008 22:20:04 +0000 Original-Received: (at 179) by emacsbugs.donarmstrong.com; 5 Aug 2008 22:10:15 +0000 Original-Received: from mail-in-07.arcor-online.net (mail-in-07.arcor-online.net [151.189.21.47]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m75MABSU014218 for <179@emacsbugs.donarmstrong.com>; Tue, 5 Aug 2008 15:10:12 -0700 Original-Received: from mail-in-16-z2.arcor-online.net (mail-in-16-z2.arcor-online.net [151.189.8.33]) by mail-in-07.arcor-online.net (Postfix) with ESMTP id C1DBF24ADDC; Wed, 6 Aug 2008 00:10:09 +0200 (CEST) Original-Received: from mail-in-13.arcor-online.net (mail-in-13.arcor-online.net [151.189.21.53]) by mail-in-16-z2.arcor-online.net (Postfix) with ESMTP id B003425410B; Wed, 6 Aug 2008 00:10:09 +0200 (CEST) Original-Received: from lola.goethe.zz (dslb-084-061-012-041.pools.arcor-ip.net [84.61.12.41]) by mail-in-13.arcor-online.net (Postfix) with ESMTP id 4F36523D1E1; Wed, 6 Aug 2008 00:10:09 +0200 (CEST) Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 44B391CD01DC; Wed, 6 Aug 2008 00:10:07 +0200 (CEST) In-Reply-To: <87vdyf86vq.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 05 Aug 2008 17:54:49 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Virus-Scanned: ClamAV 0.93.3/7949/Tue Aug 5 21:13:13 2008 on mail-in-13.arcor-online.net X-Virus-Status: Clean X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Tue, 05 Aug 2008 18:27:28 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19049 Archived-At: Chong Yidong writes: > Did you ever get the chance to try Stefan's patch from May? > > > Stefan Monnier wrote: > >> Does the patch below fix it? >> >> Stefan > > --- subr.el.~1.594.~ 2008-05-02 12:47:05.000000000 -0400 > +++ subr.el 2008-05-05 02:58:00.000000000 -0400 > @@ -571,10 +571,14 @@ > (let* ((key (car binding)) > (item (cdr binding)) > (oldbind (assq key bindings))) > + (if (null key) > + ;; nil keys are/were used by easy-menu for "separator lines and > + ;; separator titles". Merging them makes no sense. > + (push binding bindings) > ;; Newer bindings override older. > (if oldbind (setq bindings (delq oldbind bindings))) > (when item ;nil bindings just hide older ones. > - (push binding bindings)))) > + (push binding bindings))))) > (nconc map bindings))) > > (put 'keyboard-translate-table 'char-table-extra-slots 0) > My current Emacs does not have this patch applied (or include the equivalent) and does show menu separators. So at least the problem I reported would appear to be fixed (I am judging from the subject line of the bug report, don't have the report itself here). However, that does not mean that Stefan might not have unrelatedly detected some special case not covered by the current code. So while the particular problem I have reported might no longer be present in the code base, you should perhaps ask Stefan what case he had been thinking about when creating the patch. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum