unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Bird <birdsite@airmail.cc>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51578@debbugs.gnu.org
Subject: bug#51578: 29.0.50; error on display-bindings when invoked from a tty
Date: Wed, 03 Nov 2021 18:05:30 +0000	[thread overview]
Message-ID: <85ee7xru6t.fsf@airmail.cc> (raw)
In-Reply-To: <83y265gvrc.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 Nov 2021 16:27:03 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> When emacs -Q is ran in a tty(C-M-F2 on gnu/linux) and invokes
>> describe-bindings, an error occurs. the debug information is:
[snip]
> Thanks.  Does the patch below help?
>
> diff --git a/lisp/outline.el b/lisp/outline.el
> index 2a6f475..5b20a42 100644
> --- a/lisp/outline.el
> +++ b/lisp/outline.el
> @@ -961,7 +961,8 @@ outline--make-button
>                            " " (buffer-substring (point) (1+ (point))))))
>  
>  (defun outline--valid-emoji-p (string)
> -  (when-let ((font (car (internal-char-font nil ?😀))))
> +  (when-let ((font (and (display-multi-font-p)
> +                        (car (internal-char-font nil ?😀)))))
>      (font-has-char-p font (aref string 0))))
>  
>  (defun outline--valid-char-p (string)
Thanks! the above patch does work in a tty.

Is it possible to always use that triange thingy (which is used in a
tty) instead of the emoji in describe-bindings? i much prefer those
compared to emojis ;)

-- 
Smartness runs in my family.  When I went to school I was so smart my
teacher was in my class for five years.
		-- George Burns





  reply	other threads:[~2021-11-03 18:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03  3:00 bug#51578: 29.0.50; error on display-bindings when invoked from a tty Bird
2021-11-03 14:27 ` Eli Zaretskii
2021-11-03 18:05   ` Bird [this message]
2021-11-03 18:15     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85ee7xru6t.fsf@airmail.cc \
    --to=birdsite@airmail.cc \
    --cc=51578@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).