From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#21112: 25; Patch: show minibuffer messages with a face Date: Tue, 25 Jun 2019 13:54:10 -0700 (PDT) Message-ID: <85ec41db-186f-4ab7-8660-5561f4599a27@default> References: <55AF90B9.5040401@gmail.com> <87si0jvkgv.fsf@gnus.org> <87pnn11nm5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71696"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 21112@debbugs.gnu.org, Raffaele Ricciardi To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 22:55:46 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfsTh-000IPn-Sv for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 22:55:46 +0200 Original-Received: from localhost ([::1]:35212 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfsTc-0000Ob-FT for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 16:55:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52362) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfsTP-0000JS-0Y for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 16:55:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfsT9-00043y-Nw for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 16:55:17 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48325) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfsT0-0003ta-JJ for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 16:55:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfsT0-0004yf-HO for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 16:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix patch Original-Received: via spool by 21112-submit@debbugs.gnu.org id=B21112.156149607019080 (code B ref 21112); Tue, 25 Jun 2019 20:55:02 +0000 Original-Received: (at 21112) by debbugs.gnu.org; 25 Jun 2019 20:54:30 +0000 Original-Received: from localhost ([127.0.0.1]:33636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfsST-0004xf-Im for submit@debbugs.gnu.org; Tue, 25 Jun 2019 16:54:30 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:36240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfsSQ-0004xQ-EX for 21112@debbugs.gnu.org; Tue, 25 Jun 2019 16:54:27 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PKsJ7J099090; Tue, 25 Jun 2019 20:54:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=1bCRf4uoxtVtdpSeU3imja9ZRObmCqeLkCHJcpDJvgg=; b=uQ4Xh5ZP8WUGbaaPlTVUhTorHtnB4fO6+fu9mgg6arG8F/xB3/ftBVYa4dZB1YGRXmMv VMVDDLqk+pQ0NlaJUfje2s0Xq0CLKJtFVDJBkPX3CSYgVjsw1qy/gwIrY+fx2mPIC2ws rV9dxX8bDqoV3uyPpAdpD7QutBfzbLXnCGcJqb54wBjnLYhg58qpzwoz/Csv0OLU59+5 XFnryTsXv1vSj6M5ERSNjzvkRba8v8c5rlJTf64JWCw/3S5wq7YFZKbqgh0kJywbV4+L ubVTCCGMDpeZhffc84lsme3hQYoCSObQgNbcfnqr563nsH9gd7jIK/0r502dJjWlH4vT cw== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2t9cyqepnj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 20:54:19 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PKrr8e146511; Tue, 25 Jun 2019 20:54:19 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2t99f43ha6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 20:54:19 +0000 Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5PKsBpj032031; Tue, 25 Jun 2019 20:54:11 GMT In-Reply-To: <87pnn11nm5.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250160 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250160 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161424 Archived-At: > For consistency with isearch messages that are highlighted with the > minibuffer-prompt face, minibuffer-message needs to do the same. Neither Isearch prompts nor `minibuffer-message' output should be highlighted with face `minibuffer-prompt'. Isearch doesn't use the minibuffer. And `minibuffer-message' is not a prompt. > But since a message is displayed at different part of the minibuffer, > it should be highlighted using a new separate customizable variable > similar to minibuffer-prompt-properties: 1. If you go that route, which lets libraries and users easily change the properties (good), please separate Isearch and `minibuffer-message'. Use two different variables. They are not the same species. The default value could be, but it need not be, the same for both. On the other hand, it could be helpful to separate out property `face', defining an actual face (for each of Isearch and `minibuffer-message') that users can customize for this. That also has the benefit that one can inherit from one to the other. The other properties would be applied first, so that if `face' is among them for some reason it will be overridden by the face provided specifically for this. 2. The doc string of `minibuffer-message-properties' should not say that the properties are added to "minibuffer messages" - that's too broad. It should say that they are added to the text shown by function `minibuffer-message' - or else describe that text, and only that text, in another way. The doc string of the similar variable for Isearch should say that the properties are added to "the search prompt" or some such. Not sure whether the right description is "prompt", but whatever is the best way to describe it should be used in the doc string.