From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#12792: 24.2.50; shell-mode renders all its output in a yellow face Date: Sat, 03 Nov 2012 18:59:25 +0100 Message-ID: <85d2zuzhxe.fsf@iznogoud.viz> References: <871ugbxdyr.fsf@secretsauce.net> <85r4oazoh4.fsf@iznogoud.viz> <83y5ii4pfw.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1351965614 16554 80.91.229.3 (3 Nov 2012 18:00:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Nov 2012 18:00:14 +0000 (UTC) Cc: 12792@debbugs.gnu.org, dima@secretsauce.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 03 19:00:23 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TUi18-0000Tz-6n for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Nov 2012 19:00:22 +0100 Original-Received: from localhost ([::1]:45302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUi0z-00066T-FK for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Nov 2012 14:00:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUi0w-00066D-1l for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 14:00:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUi0u-0000Fo-RB for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 14:00:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUi0u-0000F8-OC for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 14:00:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TUi3h-00066n-P9 for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 14:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wolfgang Jenkner Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Nov 2012 18:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12792 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12792-submit@debbugs.gnu.org id=B12792.135196574723438 (code B ref 12792); Sat, 03 Nov 2012 18:03:01 +0000 Original-Received: (at 12792) by debbugs.gnu.org; 3 Nov 2012 18:02:27 +0000 Original-Received: from localhost ([127.0.0.1]:47443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUi38-00065z-NM for submit@debbugs.gnu.org; Sat, 03 Nov 2012 14:02:27 -0400 Original-Received: from mx01.lb01.inode.at ([62.99.145.1]:61290 helo=mx.inode.at) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUi35-00065q-Un for 12792@debbugs.gnu.org; Sat, 03 Nov 2012 14:02:25 -0400 Original-Received: from [91.119.128.247] (port=7460 helo=iznogoud.viz) by smartmx-01.inode.at with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1TUi0G-0000dp-31; Sat, 03 Nov 2012 18:59:28 +0100 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.80 (FreeBSD)) (envelope-from ) id 1TUi0D-00010a-Q0; Sat, 03 Nov 2012 18:59:25 +0100 In-Reply-To: <83y5ii4pfw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 03 Nov 2012 18:32:51 +0200") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66398 Archived-At: On Sat, Nov 03 2012, Eli Zaretskii wrote: >> In bug#11883 you give this example >> >> echo -e "\033[31mtest\033[39m" >> >> but ansi-color has never supported SGR parameter 39. However, before my >> change (the latter commit above), any unknown parameter would have the >> same effect as parameter 0 (turn off all rendition aspects), while it is >> simply ignored now (well, except for an "Invalid face reference: nil" >> message), see `ansi-color-apply-sequence'. Perhaps, this explains the >> problem. > > SGR parameter 39 means go back to the default foreground color. How > can ansi-color not support it and still be useful? Perhaps because that parameter is but rarely observed in the wild? > IIUC, what the old > code did was exactly the right thing (or at least close, since 0 means > turn off _all_ attributes, not just the foreground color), so removing > it without replacing it with something that restores the default > foreground would be a bug, IMO. I'll fix this omission if nobody beats me to it. Wolfgang