From: Noam Postavsky <npostavs@gmail.com>
To: Ken Manheimer <ken.manheimer@gmail.com>
Cc: 36556@debbugs.gnu.org
Subject: bug#36556: 26.2; python.el pdbtracking sometimes kills buffers when it shouldn't (plus fix)
Date: Wed, 17 Jul 2019 11:03:53 -0400 [thread overview]
Message-ID: <85blxsln3a.fsf@gmail.com> (raw)
In-Reply-To: <CAAT_zTHMA9JmohQ9hxi7rm6+jOe_Msa+nEbGF65M0oTAb4BmJg@mail.gmail.com> (Ken Manheimer's message of "Mon, 8 Jul 2019 18:28:53 -0400")
Ken Manheimer <ken.manheimer@gmail.com> writes:
> The problem is that this provision sometimes registers buffers that
> were present in the editing session before the pdbtracking session, so
> that pdbtracking sometimes causes pdbtracked buffers to be deleted
> when it shouldn't.
>
> I'm unsure what exact conditions lead to the problem,
I guess this can happen if your python source files are accessible
through symlinks?
> but I'm pretty sure
> that `python-pdbtrack-set-tracked-buffer()` uses the wrong buffer-finding
> function. Instead of using `get-file-buffer()`, it should be using
> `find-buffer-visiting()`. I believe that this will solve the problem.
I think this should be conditional on (or find-file-existing-other-name
find-file-visit-truename), which is what find-file-noselect checks for.
next prev parent reply other threads:[~2019-07-17 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 22:28 bug#36556: 26.2; python.el pdbtracking sometimes kills buffers when it shouldn't (plus fix) Ken Manheimer
2019-07-17 15:03 ` Noam Postavsky [this message]
2019-07-17 19:31 ` Ken Manheimer
2019-07-17 23:51 ` Noam Postavsky
2020-08-09 19:32 ` Lars Ingebrigtsen
2020-08-09 20:21 ` Ken Manheimer
2020-08-10 10:41 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85blxsln3a.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=36556@debbugs.gnu.org \
--cc=ken.manheimer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).