From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44210: 28.0.50; project.el failed to work after customizing find-program to fd Date: Tue, 27 Oct 2020 00:37:10 +0200 Message-ID: <85912943-41db-4c6c-3764-0aa6d01f54ec@yandex.ru> References: <87zh4ak0lr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20335"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: Zhiwei Chen , 44210@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 26 23:38:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXB8C-00059k-6A for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 23:38:24 +0100 Original-Received: from localhost ([::1]:59474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXB8B-0007Gb-6w for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 18:38:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXB7q-00078V-TD for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 18:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58567) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXB7q-0001w9-IK for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 18:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXB7q-0000I2-F9 for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 18:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44210 X-GNU-PR-Package: emacs Original-Received: via spool by 44210-submit@debbugs.gnu.org id=B44210.16037518401050 (code B ref 44210); Mon, 26 Oct 2020 22:38:02 +0000 Original-Received: (at 44210) by debbugs.gnu.org; 26 Oct 2020 22:37:20 +0000 Original-Received: from localhost ([127.0.0.1]:41877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXB79-0000Gr-Pz for submit@debbugs.gnu.org; Mon, 26 Oct 2020 18:37:19 -0400 Original-Received: from mail-ej1-f51.google.com ([209.85.218.51]:43284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXB78-0000Ge-9a for 44210@debbugs.gnu.org; Mon, 26 Oct 2020 18:37:18 -0400 Original-Received: by mail-ej1-f51.google.com with SMTP id k3so16212296ejj.10 for <44210@debbugs.gnu.org>; Mon, 26 Oct 2020 15:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uuq3KaYJ1Odqu3JC9aAObhLjZQlBqrdtnS+rj9kdto4=; b=KhlZbUN54mR+BYSKi2DAkZ2pLWlJTVVuerAFjX/gCgGplaIM4T2r7rc8Hdicv4FQD2 RxWG5moLBRFaTAbEYFj/dN/tDzRc49D92TB98fQJbCYsxx1dpZKjjwWx500pFRp1hnK8 UwP8fohP9bdRnfHnBqdDQ2vzqMOTrQorGz59hznOh1jg/F49jUduwM6iq1sfQhh5h8Nd ulTROI/18bV1r6yiAfHO6P4tM7gYEIo6EHNAWiamAkQ7P0Ot6FWIHUk7WEKx4e1hM532 Xp+6EMtR7WQUnmRdHp0ET3ZihXdqNg7T1BRrygmOcmAkStxUbw4zEuMHJ2qvvTK+SETU UDug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uuq3KaYJ1Odqu3JC9aAObhLjZQlBqrdtnS+rj9kdto4=; b=WWXq2ujBa8EGl3SklLYlvYRGmMA2gjOfkHaa+OvIczyPLkJaPMbXHIdwmP9P5YY7vU t5e/9sQHjovxhCuXKHb+McCjdaGUIHX4bJfpHpA3bKgGd0Bu1ifZJRskdJdRwOCAOB5p KZPO7WGWFNs3VHZO2H2V4LJWsROjXbmL+p9RyjMsAuaoiGan0Ua9qzlles/Ph7BZCknp 25qHxNerXn0zZkfLNFbbN/w/cKLOY1bdBtqTw7iZpRT2Loe0ZhVnrbR141Iv/eCR2/Qf 5pGXQ3PpsLiKA2o2kYJ5iuv/KvCIUXUGJKKeKhDZDng8msvEWTO8nhVXiDA2Tl+BFTOM W73A== X-Gm-Message-State: AOAM5321NnDbXqQ/kwK8V75Rbf5oOvPE6p3xilCso2qa22yTU/IiF0Bs RFycP/nfX3hfBulCZInz+9uC2azeSi/U0w== X-Google-Smtp-Source: ABdhPJxsFnrymdxgaqPrk8qZn9kcFn0piTs9e8/YDX18325kXDYrJ7h6qdjtE8gIajdpMzUupH7tag== X-Received: by 2002:a17:906:190b:: with SMTP id a11mr18010115eje.260.1603751832155; Mon, 26 Oct 2020 15:37:12 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id ks17sm6587002ejb.41.2020.10.26.15.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 15:37:11 -0700 (PDT) In-Reply-To: <87zh4ak0lr.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191684 Archived-At: Hi! On 25.10.2020 13:26, Zhiwei Chen wrote: > The arguments of `find-program' in function > `project--files-in-directory' is hard coded, which disallows customizing > `find-program' in some means. The arguments are not hardcoded (they are constructed dynamically), but the format is (one expected by 'find'). 'fd' uses a different arguments format, both for the "globs to search for" and the list of ignores. I wish we had a better mechanism in grep.el for a more flexible user ability to choose the tool to list files in a dir (and a search tool, and so on). > `counsel-file-jump` uses `find-program' and provides > `counsel-file-jump-args' which I thought is better. A variable with a flat list of args won't do here, because we actually have to turn two other lists (FILES and IGNORES) into appropriate arguments. What you could do, is do full :override advice on which would construct a proper command line for 'fd' based on these args, then call it and pipe through 'project--remote-file-names' (like 'project--files-in-directory' currently does). Then benchmark them and post the results here. If the result offers a meaningfully better performance, while honoring all ignores, we'll see what we can do to accommodate 'fd'.