unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: npostavs@gmail.com
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alex Branham <alex.branham@gmail.com>, 35967@debbugs.gnu.org
Subject: bug#35967: [PATCH] avoid flyspell error if point is at bob
Date: Tue, 11 Jun 2019 10:12:12 -0400	[thread overview]
Message-ID: <857e9sb48z.fsf@gmail.com> (raw)
In-Reply-To: <83pno1xmz1.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 May 2019 19:08:18 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> +  (unless (bobp)
>> +    (let ((f (get-text-property (- (point) 1) 'face)))
>> +      (memq f flyspell-prog-text-faces))))
>
> Thanks.
>
> Maybe it's just me, but whenever I see bobp, I always have to consult
> the docs regarding what happens in a narrowed buffer.  For that
> reason, I prefer comparison with point-min instead.
>
> Am I the only one troubled by that?

It doesn't take too long to check the docstring, does it?  And it seems
fairly easy to remember that bobp should treat a narrowed buffer the
same way that beginning-of-buffer will.

My only complaint about bobp is that it's abbreviated perhaps a little
too far, to the point of obscurity.  As in, who is "bob" and why are we
asking about him?





  parent reply	other threads:[~2019-06-11 14:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 20:43 bug#35967: [PATCH] avoid flyspell error if point is at bob Alex Branham
2019-05-29 16:08 ` Eli Zaretskii
2019-05-30 11:58   ` Basil L. Contovounesios
2019-06-11 14:12   ` npostavs [this message]
2019-06-11 14:39     ` Eli Zaretskii
2019-06-14 18:17       ` Alex Branham
2019-06-14 18:31         ` npostavs
2019-06-14 18:41           ` Alex Branham
2019-06-14 19:14             ` Andreas Schwab
2019-06-17 19:04               ` Alex Branham
2019-06-18 12:18   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=857e9sb48z.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=35967@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).