From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#28403: 25.2; find-tag works, but xref-find-definitions Date: Sun, 10 Sep 2017 12:01:08 +0300 Message-ID: <85628b7a-3be1-0bea-57d5-1346589f7b8a@yandex.ru> References: <201709092240.v89MeFUo014854@psr.com> <201709100250.v8A2o6nL015568@psr.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1505034141 31157 195.159.176.226 (10 Sep 2017 09:02:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Sep 2017 09:02:21 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 To: Winston , 28403@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 10 11:02:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqy86-0007nU-Nn for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 11:02:14 +0200 Original-Received: from localhost ([::1]:52162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqy8D-0001zh-SE for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 05:02:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqy83-0001zL-0W for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 05:02:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqy7v-0000Zi-L9 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 05:02:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqy7v-0000ZZ-Gn for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 05:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dqy7v-0007ix-8X for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 05:02:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2017 09:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28403-submit@debbugs.gnu.org id=B28403.150503407929632 (code B ref 28403); Sun, 10 Sep 2017 09:02:03 +0000 Original-Received: (at 28403) by debbugs.gnu.org; 10 Sep 2017 09:01:19 +0000 Original-Received: from localhost ([127.0.0.1]:58344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqy7D-0007hs-Fa for submit@debbugs.gnu.org; Sun, 10 Sep 2017 05:01:19 -0400 Original-Received: from mail-lf0-f65.google.com ([209.85.215.65]:34986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqy7B-0007he-Bu for 28403@debbugs.gnu.org; Sun, 10 Sep 2017 05:01:17 -0400 Original-Received: by mail-lf0-f65.google.com with SMTP id c8so2720726lfe.2 for <28403@debbugs.gnu.org>; Sun, 10 Sep 2017 02:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xP6I0/PhsCT79Qa5NLAA4NkNmiho9YGcvJa2nj59At8=; b=rXdKo7IQvg8DZJBiAOcp48lwUglnM440XqxS683mLADqA5M3eT1jMJKZFQGPnx7d3Q kovhxJRYn+23u28i83aekl+ii2lPQp4No/9ShQSTgXdqYm3awquy7NQYFViHTyPPBS2k IOqtu+lIHJlIOZ6mtfXpbSLG0R4WYuSwr89fdQukXhypKSYAHyUgM6hS4VBxR4oTWVUJ Eu0xR8de4OMhlCL3YdMKtXtoX2NBcb4dFEWwOplsB/MXrs603LApELpS3MR0KuPyQ++x 0Gqnvg+/2t/BXBhVYqPtWyIJxTO/8/w6+rxkJpV3ncVyuym7Nnpotht/rIiWjWevGLZJ asYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xP6I0/PhsCT79Qa5NLAA4NkNmiho9YGcvJa2nj59At8=; b=WJmBlID0RB8lLxuG7cr/kOKfWg/TehsckBB/Qrugt6U4SbdIzLfo3ZWUpZHuYXKr5W JadHUZwVixw9SipRkxhsEc5MGEJUFbUPIe+P5Td+w98sllEltwjwqdzN0a+1PH5pqhgJ toNq3OYG4M31Z1IxUMKkNC6/TkrD+fis4APSSUfMpP2G+kAsmg964C3+nx5BVpRowPvf xssQCz7HuOLN6qMNRT+cMPb53rMo9kFe0GZT4vW4XMO42XbOaASF42lKES6fGY4HcGub hw2BWoR7eA2UTRJX65yRtfD6lNA9tVDZ5JNwbI8r0OrCuw0LIigq9VbZ+NuIxMZZosiC ERTw== X-Gm-Message-State: AHPjjUjiwUljSJj3ViRUJ68z62kSkjUg/6ojotpZDV6UtYh41+D+g6p9 VHoUeF3ZFDTtrZjutkY= X-Google-Smtp-Source: AOwi7QCaA8IVNxLsaUz8ffSNO2iQU58nq11nNoXXW0bNP88egTgRDLfnon07+n/arq4+1p/AUAemKA== X-Received: by 10.25.143.199 with SMTP id s68mr2308762lfk.143.1505034070930; Sun, 10 Sep 2017 02:01:10 -0700 (PDT) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id g21sm1194236lje.52.2017.09.10.02.01.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Sep 2017 02:01:09 -0700 (PDT) In-Reply-To: <201709100250.v8A2o6nL015568@psr.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136725 Archived-At: On 9/10/17 5:49 AM, Winston wrote: > Yes, and "etags --version" prints: etags (GNU Emacs 25.2) Thanks. > Exactly. E.g., > name _ARGS1(^?188,5710 > >> which is an "implicit tag name" entry for "_ARGS1", but not for "name". >> IOW, etags doesn't understand macros. > > Whether etags understands macros or not, it is correctly identifying > the lines containing function names, so I see no problem there. It has a line, but it's a line for tag name "_ARGS1", not "name", by etags rules. find-tag just falls back to full text search, which xref-find-definitions doesn't, by default. Because false positives will be more noticeable and annoying in its UI, compared to find-tag's. >> Try adding `tag-symbol-match-p' to >> etags-xref-find-definitions-tag-order. This example should work then, >> but you'll get more false positives (like treating return types as >> function names). > > Noted for future reference... > > Since doing that doesn't change what etags writes to TAGS, I'm not > sure how that elisp change would result in function return types being > matched as function names, but no matter. Have you even tried this? > For the moment I think I'll > just continue to use find-tag and hope that xref-find-definitions will > eventually work as well as find-tag before find-tag disappears. :) It works better already (more precise results, for inputs that etags understands well).