From: Wolfgang Jenkner <wjenkner@inode.at>
To: Leo Liu <sdl.web@gmail.com>
Cc: 20066@debbugs.gnu.org
Subject: bug#20066: 24.4; should-error and cl-assert
Date: Mon, 09 Mar 2015 17:12:35 +0100 [thread overview]
Message-ID: <854mpum9nj.fsf@iznogoud.viz> (raw)
In-Reply-To: <m2bnk2ppbf.fsf@gmail.com>
On Mon, Mar 09 2015, Leo Liu wrote:
> I just compiled emacs 25.0.50 from git and I have immediately noticed
> the following difference:
>
> 1. (should-error (error "yes"))
> 2. (should-error (cl-assert nil t))
>
> Test 1 succeeds but test 2 fails. In emacs 24.4, both tests succeed.
> Could someone investigate what have caused this incompatibility?
commit 61b4c22c6eba96718327a0d208a8492d8bad76e0
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Sat Feb 14 00:46:29 2015 -0500
[...]
(cl--assertion-failed): New function.
+(defun cl--assertion-failed (form &optional string sargs args)
+ (if debug-on-error
+ (debug `(cl-assertion-failed ,form ,string ,@sargs))
So, `debug' is explicitly called now, which circumvents the normal
call-chain: signal > maybe_call_debugger > call_debugger > debug
next prev parent reply other threads:[~2015-03-09 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 8:06 bug#20066: 24.4; should-error and cl-assert Leo Liu
2015-03-09 16:12 ` Wolfgang Jenkner [this message]
2015-04-07 7:44 ` Leo Liu
2015-04-07 12:47 ` Nicolas Richard
2015-04-07 13:10 ` Nicolas Richard
2015-04-08 2:05 ` Stefan Monnier
2015-04-08 4:15 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=854mpum9nj.fsf@iznogoud.viz \
--to=wjenkner@inode.at \
--cc=20066@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).