From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Thu, 1 Oct 2020 12:38:48 -0700 (PDT) Message-ID: <8515e6e4-f3b4-4e81-8aa5-e582de067d9d@default> References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> <87y2kp93dn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15308"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , Lars Ingebrigtsen , 43702@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 21:40:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO4Qz-0003sW-7J for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 21:40:09 +0200 Original-Received: from localhost ([::1]:47596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO4Qy-000316-A7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 15:40:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO4Qs-00030w-SD for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55121) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO4Qs-0004GC-J5 for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO4Qs-0005R6-Fj for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.160158114420825 (code B ref 43702); Thu, 01 Oct 2020 19:40:02 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 1 Oct 2020 19:39:04 +0000 Original-Received: from localhost ([127.0.0.1]:38432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO4Pv-0005Po-Th for submit@debbugs.gnu.org; Thu, 01 Oct 2020 15:39:04 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:43738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO4Pr-0005PH-3b for 43702@debbugs.gnu.org; Thu, 01 Oct 2020 15:39:03 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 091JPJS0085403; Thu, 1 Oct 2020 19:38:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=KZSa9Am+G8Lti6OcqHiTOlIaf+JJUyKIK2QiYDvw7rE=; b=djxkVImzRVVzTZiFuifuCq6BNBSCBxFHmycZmxSMZHbX9B6Pv4X+go/3EJXQnIxrzS0P 2YNRjFpRyCVXyHthmG2AZTX8dq5HEluFagq2UpYNOvQjpIhbSKBPcIFYDy+m5E/X3/cp N2LBN+mtAuQ1ftIoF+j3RRuni+GUZgKfP3LVmcuTi/mUANsU+vhLix5rZfByr6AiwQnW w3nkFq4OY60LXAK3ioMpDTO/s9hTGGk27xmw3WaN18xa2ES20EYwGxj9E0Bm2teib1LP n2aeDbk9Rqm1wP8fgy82joULBiGEXExeOomIRX9TaWIWEQfPu0I3N554EItMIkiaUf7M 3w== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 33sx9nfwb6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 01 Oct 2020 19:38:53 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 091JOsmP098657; Thu, 1 Oct 2020 19:38:52 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 33tfdwbgqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Oct 2020 19:38:52 +0000 Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 091JcnS7012036; Thu, 1 Oct 2020 19:38:49 GMT In-Reply-To: <87y2kp93dn.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9761 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010010157 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9761 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 spamscore=0 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010010157 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189578 Archived-At: > >> Maybe better to do what Drew proposed: to distinguish the odd groups > >> from the even groups, i.e. to have only 2 additional faces > >> (a brighter face like the current isearch-group-1 for the odd groups, > >> and a darker face for the even groups). > > > > To be clear, I didn't propose that. My code has 8 levels > > (groups), with 8 faces. >=20 > My intention was to give credit where credit is due. > Thank you for the idea. >=20 > > What I mentioned about even and odd is for lazy-highlighting. >=20 > Both ordinary and lazy-highlighting matches could be based on > the same idea of odd/even faces. They could. But they shouldn't. For the current search hit, it makes sense to provide as much info as possible visually. That is, in this context (regexp matching), highlight each of the groups in a unique way, so they can be easily identified in the search hit. The idea behind even/odd lazy-highlighting is to just provide a rough idea of some of the matching. The current search hit should show accurate, complete info about the match.