bug#25649: 26.0.50; Decryption of mail fails silently if tmp directory is full

bug#25649: 26.0.50; Decryption of mail fails silently if tmp directory is full

[Marco Wahl]

Precondition:

- Have temp directory 100% full.

- Have an encrypted (for you) email.

Action:

- Trigger the decrypt of that email in gnus.

Effect:

- The mailtext is omitted.  It looks like the email has no content.

Wish:

- Error indication.




In GNU Emacs 26.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.7)
 of 2017-02-01 built on tm6592
Repository revision: 12da2a5beafc4595fe4dd922431ba9f013b84830
Windowing system distributor 'The X.Org Foundation', version 11.0.11901000
System Description:	Arch Linux

Recent messages:
Directory has changed on disk; type g to update Dired
Copy proceeding asynchronously...
error in process sentinel: async-handle-result: Write error: No space left on device, /tmp/dired-async.log
error in process sentinel: Write error: No space left on device, /tmp/dired-async.log
nil [2 times]
History item: 128
Decrypt (PGP) part? (y or n) y
56 entries in the kill ring.    Type M-x browse-kill-ring-quit to quit.  h for help.
Mark set
Auto-saving...done

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 LIBSYSTEMD

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  checkdoc-minor-mode: t
  moz-controller-global-mode: t
  moz-controller-mode: t
  zen-reward-mode: t
  nyan-mode: t
  lispy-mode: t
  global-company-mode: t
  company-mode: t
  diff-auto-refine-mode: t
  magit-auto-revert-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  global-lentic-mode: t
  lentic-mode: t
  ido-hacks-mode: t
  ido-everywhere: t
  on-screen-global-mode: t
  wrap-region-global-mode: t
  wrap-region-mode: t
  keyfreq-autosave-mode: t
  keyfreq-mode: t
  dired-async-mode: t
  dired-async--modeline-mode: t
  override-global-mode: t
  shell-dirtrack-mode: t
  timeclock-mode-line-display: t
  show-paren-mode: t
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  display-time-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  prettify-symbols-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Load-path shadows:
Error during checking
Features:
(shadow macros emacsbug bbdb-snarf smiley reverse-theme gnus-kill
pcmpl-unix em-unix em-term term ehelp em-script em-prompt em-ls em-hist
em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias gnus-dired
tramp-cache conf-mode emms-volume-pulse org-table eieio-opt speedbar
sb-image ezimage dframe shr-color color flow-fill flycheck let-alist
names autoload lisp-mnt tar-mode url-cache rfc2104 gnus-cite
bbdb-message mailalias mm-archive mail-extr gnus-async gnus-bcklg qp
gnus-ml nndraft nnmh nndoc utf-7 network-stream starttls nnfolder
bbdb-gnus nnnil gnus-agent gnus-srvr gnus-score score-mode nnvirtual
gnus-msg gnus-cache gnus-demon nntp smtpmail sendmail ace-window
org-attach python-el-fgallina-expansions python html-mode-expansions
sgml-mode psgml zone zone-nyan esxml evil-numbers ledger-mode
ledger-check ledger-schedule ledger-xact ledger-texi ledger-test
ledger-sort ledger-report ledger-reconcile ledger-post ledger-occur
ledger-init ledger-fontify ledger-state ledger-navigate ledger-fonts
ledger-exec ledger-context ledger-complete ledger-commodities esh-var
esh-io esh-cmd esh-opt esh-ext esh-proc esh-groups eshell esh-module
esh-mode esh-arg esh-util ledger-regex bookmark tabify org-datetree
org-capture sh-script smie executable cal-move misearch multi-isearch
password-store epa-file hl-line cal-iso beacon checkdoc view page-ext
erc-dcc battery cal-china lunar cal-islam cal-hebrew holidays
hol-loaddefs bbdb-anniv appt diary-lib diary-loaddefs warnings emacsshot
rope-read-mode org-timer org-clock disp-table org-velocity dabbrev
org-learn org-invoice org-elisp-symbol org-depend org-w3m org-rmail
org-mhe org-irc org-inlinetask org-info org-id org-habit org-agenda
org-gnus org-eww org-docview doc-view jka-compr image-mode org-ctags
org-crypt org-bibtex bibtex org-bbdb exwm-randr xcb-randr exwm-config
exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor
xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb
xcb-xproto xcb-types jl-encrypt maxima maxima-font-lock moz-controller
moz org-section-numbers org-structure-as-dirs-and-files org-bullets
carry-region hack-time mw-mark auxies-eww hacks auxies-rest
org-supplements little-helpers bbdb-mua bbdb-com gnorb-bbdb bbdb
bbdb-site timezone bbdb-loaddefs emms-librefm-stream
emms-librefm-scrobbler emms-playlist-limit emms-volume
emms-volume-amixer emms-i18n emms-history emms-score emms-stream-info
emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon
emms-browser sort emms-playlist-sort emms-last-played emms-player-xine
emms-player-mpd tq emms-playing-time emms-lyrics emms-url emms-streams
emms-show-all emms-tag-editor emms-mark emms-mode-line emms-cache
emms-info-ogginfo emms-info-mp3info emms-info later-do
emms-playlist-mode emms-player-vlc emms-player-mplayer
emms-player-simple emms-source-playlist emms-source-file locate
emms-setup emms emms-compat org-protocol slime-fancy slime-trace-dialog
slime-fontifying-fu slime-package-fu slime-references
slime-compiler-notes-tree slime-scratch slime-presentations bridge
slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl elp slime-parse slime gud apropos compile arc-mode
archive-mode hyperspec slime-autoloads refine git-timemachine vc-git
elmacro emr-c emr-elisp emr-lisp list-utils emr-iedit which-func imenu
emr-prog emr popup git-auto-commit-mode nyan-mode sotlisp skeleton
gnuplot info-look helm helm-source helm-multi-match helm-lib aurel
url-http url-auth url-gw nsm bui bui-list bui-info bui-entry bui-core
bui-history bui-button bui-utils cus-edit json map rase solar cal-dst
gnorb gnorb-org gnorb-registry gnus-registry registry gnus-art mm-uu
mml2015 mm-view mml-smime smime dig gnorb-gnus gnorb-utils nngnorb nnir
gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail
mail-source tls gnutls utf7 netrc gnus-spec gnus-int gnus-range gnus-win
nnoo smartparens lispy hydra lv swiper ivy ivy-overlay ffap iedit
iedit-lib multiple-cursors-core rect lispy-inline semantic/db eieio-base
semantic/util-modes semantic/util semantic semantic/tag semantic/lex
semantic/fw mode-local cedet ediff-merg ediff-wind ediff-diff ediff-mult
ediff-help ediff-init ediff-util ediff edebug help-fns radix-tree
lispy-tags key-chord company-oddmuse company-keywords company-etags
etags xref project company-gtags company-dabbrev-code company-dabbrev
company-files company-capf company-cmake company-xcode company-clang
company-semantic company-eclim company-template company-css company-nxml
company-bbdb company magit-obsolete magit-blame magit-stash magit-bisect
magit-remote magit-commit magit-sequence magit-notes magit-worktree
magit-branch magit-files magit-refs magit-status magit magit-repos
magit-apply magit-wip magit-log magit-diff smerge-mode diff-mode
magit-core magit-autorevert autorevert filenotify magit-process
magit-margin magit-mode magit-git crm magit-section magit-popup
git-commit magit-utils log-edit message rfc822 mml mml-sec epa epg
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader pcvs-util add-log with-editor async-bytecomp tramp-sh server
lentic-mode lentic-doc lentic-ox lentic-org lentic-chunk rx ox-texinfo
ox-org ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util
rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-md
ox-icalendar ox-html table ox-beamer ox-latex ox-ascii ox-publish ox eww
puny mm-url gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045
ietf-drums mail-utils mm-util mail-prsvr url-queue url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util mailcap shr svg dom subr-x browse-url lentic eieio-compat f s
m-buffer-at m-buffer m-buffer-macro ido-hacks ido expand-region
text-mode-expansions cc-mode-expansions the-org-mode-expansions
er-basic-expansions expand-region-core expand-region-custom
browse-kill-ring derived form-feed page-break-lines on-screen
wrap-region keyfreq stumpwm-mode dired-narrow delsel dired-hacks-utils
dash chronos notifications dbus xml ace-link avy camcorder dired-async
dired-aux dired dired-loaddefs async use-package diminish bind-key
finder-inf tex-site edmacro kmacro kotl-loaddefs screenshot-autoloads
info package epg-config url-handlers url-parse url-vars org-element
avl-tree org org-macro org-footnote org-pcomplete org-list org-faces
org-entities noutline outline easy-mmode org-version ob-octave
ob-makefile ob-forth ob-R ob-haskell ob-maxima ob-java ob-plantuml
ob-sqlite ob-sql ob-screen ob-J ob-io ob-shell ob-clojure ob-scheme
ob-gnuplot ob-dot ob-ditaa ob-lisp ob-css ob-js ob-org ob-ledger
ob-latex ob-calc calc-store calc-trail calc-ext calc calc-loaddefs
calc-macs ob-C cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles
cc-align cc-engine cc-vars cc-defs cl ob-python ob-awk ob-emacs-lisp ob
ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint tramp
tramp-compat tramp-loaddefs trampver ucs-normalize shell parse-time
advice ob-core ob-eval org-compat org-macs org-loaddefs cal-menu
calendar cal-loaddefs ert find-func seq ewoc debug .emacs-custom
timeclock paren avoid erc-list erc-menu erc-join erc-ring erc-networks
erc-pcomplete time-date pcomplete comint ansi-color ring erc-track
erc-match erc-button wid-edit erc-fill erc-stamp erc-netsplit
erc-goodies erc erc-backend erc-compat format-spec auth-source cl-seq
eieio byte-opt bytecomp byte-compile cl-extra help-mode easymenu cconv
eieio-core cl-macs gv eieio-loaddefs password-cache thingatpt pp time
desktop frameset cl-loaddefs pcase cl-lib cus-start cus-load mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript case-table epa-hook jka-cmpr-hook help
simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 2646319 264201)
 (symbols 48 104093 95)
 (miscs 40 56475 27789)
 (strings 32 463755 52984)
 (string-bytes 1 18221117)
 (vectors 16 165726)
 (vector-slots 8 3352450 138254)
 (floats 8 4075 3754)
 (intervals 56 187294 8808)
 (buffers 976 156))

-- 
Marco Wahl -- Freelancer
https://marcowahl.github.io

bug#25649: 26.0.50; Decryption of mail fails silently if tmp directory is full

[Lars Ingebrigtsen]

Marco Wahl <marcowahlsoft@gmail.com> writes:

> Precondition:
>
> - Have temp directory 100% full.
>
> - Have an encrypted (for you) email.
>
> Action:
>
> - Trigger the decrypt of that email in gnus.
>
> Effect:
>
> - The mailtext is omitted.  It looks like the email has no content.
>
> Wish:
>
> - Error indication.

Indeed.

I'm looking at this code, and there seems to be a bunch of error
reporting in place.  For instance:

(defun mm-possibly-verify-or-decrypt (parts ctl &optional from)
  (let ((type (car ctl))
	(subtype (cadr (split-string (car ctl) "/")))
	(mm-security-handle ctl) ;; (car CTL) is the type.

[...]

	  (if func
	      (setq parts (funcall func parts ctl))
	    (mm-set-handle-multipart-parameter
	     mm-security-handle 'gnus-details
	     (format "Unknown sign protocol (%s)" protocol))))))

[...]

    parts))

And mm-security-handle indeed has a file-related error message after
this.  But it's just discarded?  I mean, it's bound locally and then not
returned, so I think there's a thinko here somewhere...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#25649: 26.0.50; Decryption of mail fails silently if tmp directory is full

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> And mm-security-handle indeed has a file-related error message after
> this.  But it's just discarded?  I mean, it's bound locally and then not
> returned, so I think there's a thinko here somewhere...

I've now made it check the results and pass the errors on to the
caller.  Hopefully this doesn't break other use cases -- I'm not very
confident that this won't fail for some of the decryption methods.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no