From: Brahimi Saifullah <brahimi.saifullah@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 51995@debbugs.gnu.org
Subject: bug#51995: 29.0.50; `string-pixel-width' depends on the current window width
Date: Sun, 21 Nov 2021 21:53:27 -0300 [thread overview]
Message-ID: <84a6hxdn94.fsf@gmail.com> (raw)
In-Reply-To: <84czmvbepd.fsf@gmail.com>
>Can you explain how you are supposed to apply it?
>
>I tried:
>
> git apply buffer-text-pixel-size.diff
>
>But all it says is:
>
> error: corrupt patch at line 12
My bad, it seems the file got corrupted on my end. I downloaded it from
debbugs.gnu.org and the patch is recognized as valid, yet it does not apply:
Checking patch lisp/emacs-lisp/subr-x.el...
error: while searching for:
"Return the width of STRING in pixels."
(with-temp-buffer
(insert string)
(car (window-text-pixel-size
(current-buffer) (point-min) (point)))))
(provide 'subr-x)
error: patch failed: lisp/emacs-lisp/subr-x.el:446
error: lisp/emacs-lisp/subr-x.el: patch does not apply
(The only problem is that a new function was added at
the end of subr-x, the xdisp.c part does apply fine.)
I've also tested the patch further, using `buffer-text-size' on my
package's implementation of `string-pixel-width', and everything is
is working, including my tests. Thanks.
prev parent reply other threads:[~2021-11-22 0:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 5:04 bug#51995: 29.0.50; `string-pixel-width' depends on the current window width Brahimi Saifullah
2021-11-20 7:20 ` Eli Zaretskii
2021-11-20 8:48 ` martin rudalics
2021-11-20 9:35 ` Lars Ingebrigtsen
2021-11-20 21:36 ` Brahimi Saifullah
2021-11-20 21:42 ` Brahimi Saifullah
2021-11-21 6:34 ` Eli Zaretskii
2021-11-21 9:12 ` martin rudalics
2021-11-21 18:38 ` Brahimi Saifullah
2021-11-22 9:28 ` martin rudalics
2021-11-22 11:04 ` Lars Ingebrigtsen
2021-11-22 0:53 ` Brahimi Saifullah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84a6hxdn94.fsf@gmail.com \
--to=brahimi.saifullah@gmail.com \
--cc=51995@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).