From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#11508: 24.1.50; Off-by-one error in xg_select? Date: Mon, 21 May 2012 07:30:06 +0200 Message-ID: <8494C018-ABAE-4218-BEB5-A4C80FBB3FED@swipnet.se> References: <4FB64B05.6020709@cornell.edu> <3B902B7C-C59A-4933-A6AA-E23DB052704C@swipnet.se> <73ED1C31-12C1-4424-9DEC-632A1F0050D4@swipnet.se> <4FB973EB.9060705@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1337578236 16925 80.91.229.3 (21 May 2012 05:30:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 May 2012 05:30:36 +0000 (UTC) Cc: Andreas Schwab , "11508@debbugs.gnu.org" <11508@debbugs.gnu.org> To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 21 07:30:34 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SWLCS-0005Z8-VX for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2012 07:30:33 +0200 Original-Received: from localhost ([::1]:41958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWLCS-00073A-A8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2012 01:30:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWLCP-00072Y-9Y for bug-gnu-emacs@gnu.org; Mon, 21 May 2012 01:30:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWLCN-0001Gf-7n for bug-gnu-emacs@gnu.org; Mon, 21 May 2012 01:30:28 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWLCN-0001GX-4b for bug-gnu-emacs@gnu.org; Mon, 21 May 2012 01:30:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SWLCw-00037l-Ns for bug-gnu-emacs@gnu.org; Mon, 21 May 2012 01:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 May 2012 05:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11508 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11508-submit@debbugs.gnu.org id=B11508.133757825811998 (code B ref 11508); Mon, 21 May 2012 05:31:02 +0000 Original-Received: (at 11508) by debbugs.gnu.org; 21 May 2012 05:30:58 +0000 Original-Received: from localhost ([127.0.0.1]:36080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SWLCs-00037S-3m for submit@debbugs.gnu.org; Mon, 21 May 2012 01:30:58 -0400 Original-Received: from mailout.melmac.se ([62.20.26.67]:47489) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SWLCm-00037A-Bd for 11508@debbugs.gnu.org; Mon, 21 May 2012 01:30:55 -0400 Original-Received: from mail01.melmac.se (mail01.melmac.se [62.20.26.80]) by mailout.melmac.se (Postfix) with ESMTP id B33719CA6 for <11508@debbugs.gnu.org>; Mon, 21 May 2012 07:30:09 +0200 (CEST) Original-Received: (qmail 991 invoked by uid 89); 21 May 2012 06:25:49 -0000 Original-Received: from h-46-59-42-18.na.cust.bahnhof.se (HELO coolsville.localdomain) (boel.djarv@bdtv.se@46.59.42.18) by mail01.melmac.se with ESMTPA; 21 May 2012 06:25:49 -0000 Original-Received: from [172.20.199.248] (janiphone [172.20.199.248]) by coolsville.localdomain (Postfix) with ESMTPSA id 347917FA06C; Mon, 21 May 2012 07:30:09 +0200 (CEST) In-Reply-To: <4FB973EB.9060705@cornell.edu> X-Mailer: iPhone Mail (9B206) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60256 Archived-At: Hello.=20 Go ahead and make the change. Jan D.=20 21 maj 2012 kl. 00:44 skrev Ken Brown : > On 5/19/2012 5:52 AM, Andreas Schwab wrote: >> Jan Dj=C3=A4rv writes: >>=20 >>> So the question is, is it more effective to give select the exact value >>> (select works fine if nfds has a higher value than strictly neccessary),= >>> or always increment by one in lines 78 and 83? >>=20 >> IMHO it doesn't hurt to be exact, and the patch removes an inconsistency >> which makes it easier to understand the code. >=20 > So can I go ahead and make this change? Jan, do you still object? >=20 > Ken